Refactor webrtc_perf_tests into several source_sets.

Refactor webrtc_perf_tests into several source_sets.

BUG=webrtc:6954
Review-Url: https://codereview.webrtc.org/2609403002
Cr-Commit-Position: refs/heads/master@{#15902}
Committed: https://chromium.googlesource.com/external/webrtc/+/0b5a26a5768618e5d850aa7ea97cb348fe5302f7

[ehmaldonado_webrtc, 2017-01-04 12:07:34]

Description was changed from

==========
Refactor webrtc_perf_tests into several tests.

BUG=
==========

to

==========
Refactor webrtc_perf_tests into several tests.

BUG=webrtc:6954
==========

[ehmaldonado_webrtc, 2017-01-04 12:07:34]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-01-04 12:28:54]

lgtm w/ nit
Make sure to run trybots though.

https://codereview.webrtc.org/2609403002/diff/1/webrtc/call/BUILD.gn
File webrtc/call/BUILD.gn (right):

https://codereview.webrtc.org/2609403002/diff/1/webrtc/call/BUILD.gn#newcode78
webrtc/call/BUILD.gn:78: rtc_source_set("call_perf_tests") {
+1 blank line before this target improves readability IMO

[ehmaldonado_webrtc, 2017-01-04 15:34:49]

Patchset #4 (id:60001) has been deleted

[ehmaldonado_webrtc, 2017-01-04 15:42:15]

PTAL :)

[kjellander_webrtc, 2017-01-04 15:54:43]

Description was changed from

==========
Refactor webrtc_perf_tests into several tests.

BUG=webrtc:6954
==========

to

==========
Refactor webrtc_perf_tests into several source_sets.

BUG=webrtc:6954
==========

[kjellander_webrtc, 2017-01-04 15:55:46]

Still lgtm. Please run the test manually on your machine for one platform and
verify the number of tests are still the same, since this test doesn't run on
trybots.

I changed tests -> source_sets in the CL title.

[ehmaldonado_webrtc, 2017-01-04 16:36:03]

On 2017/01/04 15:55:46, kjellander_webrtc wrote:
> Still lgtm. Please run the test manually on your machine for one platform and
> verify the number of tests are still the same, since this test doesn't run on
> trybots.
> 
> I changed tests -> source_sets in the CL title.

Verified. Had to change a define of place.

[ehmaldonado_webrtc, 2017-01-04 16:36:21]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2017-01-04 16:36:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2609403002/#ps100001 (title:
"Moved define.")

[commit-bot: I haz the power, 2017-01-04 16:36:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-04 17:13:59]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1483547781268380,
"parent_rev": "758b6d7efafd4c959d5dde7b40cde05dd745d2fe", "commit_rev":
"0b5a26a5768618e5d850aa7ea97cb348fe5302f7"}

[commit-bot: I haz the power, 2017-01-04 17:14:01]

Description was changed from

==========
Refactor webrtc_perf_tests into several source_sets.

BUG=webrtc:6954
==========

to

==========
Refactor webrtc_perf_tests into several source_sets.

BUG=webrtc:6954

Review-Url: https://codereview.webrtc.org/2609403002
Cr-Commit-Position: refs/heads/master@{#15902}
Committed:
https://chromium.googlesource.com/external/webrtc/+/0b5a26a5768618e5d850aa7ea...
==========

[commit-bot: I haz the power, 2017-01-04 17:14:02]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/0b5a26a5768618e5d850aa7ea...

[kjellander_webrtc, 2017-01-04 20:01:13]

On 2017/01/04 16:36:03, ehmaldonado_webrtc wrote:
> On 2017/01/04 15:55:46, kjellander_webrtc wrote:
> > Still lgtm. Please run the test manually on your machine for one platform
and
> > verify the number of tests are still the same, since this test doesn't run
on
> > trybots.
> > 
> > I changed tests -> source_sets in the CL title.
> 
> Verified. Had to change a define of place.

*phew*. Good that you caught it!
Can you please compare a before+after build for Win, Mac and Linux too, just to
be sure?

[danilchap, 2017-01-05 12:57:37]

A revert of this CL (patchset #5 id:100001) has been created in
https://codereview.webrtc.org/2613913002/ by danilchap@webrtc.org.

The reason for reverting is: Probably cause unexpected performance regression
BUG=chromium:678569.