Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2613913002: Revert of Refactor webrtc_perf_tests into several source_sets. (Closed)

Created:
3 years, 11 months ago by danilchap
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, hlundin-webrtc, yujie_mao (webrtc), kwiberg-webrtc, zhuangzesen_agora.io, Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, aluebs-webrtc, peah-webrtc, minyue-webrtc, the sun, mflodman, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Refactor webrtc_perf_tests into several source_sets. (patchset #5 id:100001 of https://codereview.webrtc.org/2609403002/ ) Reason for revert: Probably cause unexpected performance regression BUG=chromium:678569 Original issue's description: > Refactor webrtc_perf_tests into several source_sets. > > BUG=webrtc:6954 > > Review-Url: https://codereview.webrtc.org/2609403002 > Cr-Commit-Position: refs/heads/master@{#15902} > Committed: https://chromium.googlesource.com/external/webrtc/+/0b5a26a5768618e5d850aa7ea97cb348fe5302f7 TBR=kjellander@webrtc.org,ehmaldonado@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2613913002 Cr-Commit-Position: refs/heads/master@{#15916} Committed: https://chromium.googlesource.com/external/webrtc/+/5fbcd228f0781526ce2cbafba0a1f39f481ad81b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -110 lines) Patch
M webrtc/BUILD.gn View 2 chunks +36 lines, -6 lines 0 comments Download
M webrtc/call/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +0 lines, -29 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
M webrtc/video/BUILD.gn View 2 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
danilchap
Created Revert of Refactor webrtc_perf_tests into several source_sets.
3 years, 11 months ago (2017-01-05 12:57:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2613913002/1
3 years, 11 months ago (2017-01-05 12:57:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/5fbcd228f0781526ce2cbafba0a1f39f481ad81b
3 years, 11 months ago (2017-01-05 12:57:54 UTC) #6
ehmaldonado_webrtc
3 years, 11 months ago (2017-01-05 13:11:18 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2615873002/ by ehmaldonado@webrtc.org.

The reason for reverting is: Try again..

Powered by Google App Engine
This is Rietveld 408576698