Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2614693002: Reland of Delete unused code from systeminfo. (Closed)

Created:
3 years, 11 months ago by kthelgason
Modified:
3 years, 11 months ago
Reviewers:
perkj_webrtc, skvlad
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Delete unused code from systeminfo. (patchset #1 id:1 of https://codereview.webrtc.org/2584563004/ ) Reason for revert: Relanding as downstream has been fixed. Original issue's description: > Revert of Delete unused code from systeminfo. (patchset #3 id:40001 of https://codereview.webrtc.org/2578323005/ ) > > Reason for revert: > Breaks downstream build. > > Original issue's description: > > Delete unused code from systeminfo. > > > > BUG=webrtc:6906 > > > > Review-Url: https://codereview.webrtc.org/2578323005 > > Cr-Commit-Position: refs/heads/master@{#15655} > > Committed: https://chromium.googlesource.com/external/webrtc/+/617ca316e9363986a54926a185fac799de3869c2 > > TBR=perkj@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > BUG=webrtc:6906 > > Review-Url: https://codereview.webrtc.org/2584563004 . > Cr-Commit-Position: refs/heads/master@{#15660} > Committed: https://chromium.googlesource.com/external/webrtc/+/ffb865f3e05fcba0c24baab27201ce2414b5430c TBR=perkj@webrtc.org,skvlad@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6906 Review-Url: https://codereview.webrtc.org/2614693002 Cr-Commit-Position: refs/heads/master@{#15956} Committed: https://chromium.googlesource.com/external/webrtc/+/62ffe9a33921e5037eac26bf00b6a74d98166152

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -421 lines) Patch
M webrtc/base/BUILD.gn View 1 2 chunks +0 lines, -5 lines 0 comments Download
D webrtc/base/systeminfo.h View 1 1 chunk +0 lines, -49 lines 0 comments Download
D webrtc/base/systeminfo.cc View 1 1 chunk +0 lines, -214 lines 0 comments Download
D webrtc/base/systeminfo_unittest.cc View 1 chunk +0 lines, -150 lines 0 comments Download
M webrtc/media/base/videocapturer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/system_wrappers/source/cpu_info.cc View 1 chunk +50 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
kthelgason
Created Reland of Delete unused code from systeminfo.
3 years, 11 months ago (2017-01-04 13:00:02 UTC) #1
kthelgason
ptal. The downstream project has removed it's dependency on this code and the import trybot ...
3 years, 11 months ago (2017-01-04 13:45:53 UTC) #2
perkj_webrtc
rs lgtm
3 years, 11 months ago (2017-01-05 19:25:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2614693002/1
3 years, 11 months ago (2017-01-09 08:14:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/builds/138) ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 11 months ago (2017-01-09 08:15:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2614693002/180001
3 years, 11 months ago (2017-01-09 08:26:51 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 09:22:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:180001) as
https://chromium.googlesource.com/external/webrtc/+/62ffe9a33921e5037eac26bf0...

Powered by Google App Engine
This is Rietveld 408576698