Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2578323005: Delete unused code from systeminfo. (Closed)

Created:
4 years ago by kthelgason
Modified:
4 years ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused code from systeminfo. BUG=webrtc:6906 Review-Url: https://codereview.webrtc.org/2578323005 Cr-Commit-Position: refs/heads/master@{#15655} Committed: https://chromium.googlesource.com/external/webrtc/+/617ca316e9363986a54926a185fac799de3869c2

Patch Set 1 #

Total comments: 1

Patch Set 2 : Delete unused code from systeminfo #

Patch Set 3 : Delete systeminfo entirely #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -420 lines) Patch
M webrtc/BUILD.gn View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/base/systeminfo.h View 1 2 1 chunk +0 lines, -49 lines 0 comments Download
M webrtc/base/systeminfo.cc View 1 2 1 chunk +0 lines, -213 lines 0 comments Download
M webrtc/base/systeminfo_unittest.cc View 1 2 1 chunk +0 lines, -150 lines 0 comments Download
M webrtc/media/base/videocapturer.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/system_wrappers/source/cpu_info.cc View 1 2 1 chunk +50 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (19 generated)
kthelgason
4 years ago (2016-12-16 12:03:06 UTC) #2
perkj_webrtc
https://codereview.webrtc.org/2578323005/diff/1/webrtc/base/systeminfo.h File webrtc/base/systeminfo.h (right): https://codereview.webrtc.org/2578323005/diff/1/webrtc/base/systeminfo.h#newcode20 webrtc/base/systeminfo.h:20: class SystemInfo { please replace class with ns https://google.github.io/styleguide/cppguide.html#Nonmember,_Static_Member,_and_Global_Functions ...
4 years ago (2016-12-16 12:05:41 UTC) #7
kthelgason
I ended up just deleting the files entirely and moving the code to the only ...
4 years ago (2016-12-16 12:29:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2578323005/40001
4 years ago (2016-12-16 12:34:49 UTC) #18
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-16 12:34:50 UTC) #21
perkj_webrtc
lgtm
4 years ago (2016-12-16 13:38:38 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2578323005/40001
4 years ago (2016-12-16 13:45:25 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/617ca316e9363986a54926a185fac799de3869c2
4 years ago (2016-12-16 14:07:07 UTC) #27
skvlad
4 years ago (2016-12-17 00:46:08 UTC) #28
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/2584563004/ by skvlad@webrtc.org.

The reason for reverting is: Breaks downstream build..

Powered by Google App Engine
This is Rietveld 408576698