Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2584563004: Revert of Delete unused code from systeminfo. (Closed)

Created:
4 years ago by skvlad
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete unused code from systeminfo. (patchset #3 id:40001 of https://codereview.webrtc.org/2578323005/ ) Reason for revert: Breaks downstream build. Original issue's description: > Delete unused code from systeminfo. > > BUG=webrtc:6906 > > Review-Url: https://codereview.webrtc.org/2578323005 > Cr-Commit-Position: refs/heads/master@{#15655} > Committed: https://chromium.googlesource.com/external/webrtc/+/617ca316e9363986a54926a185fac799de3869c2 TBR=perkj@webrtc.org,kthelgason@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. BUG=webrtc:6906 Review-Url: https://codereview.webrtc.org/2584563004 . Cr-Commit-Position: refs/heads/master@{#15660} Committed: https://chromium.googlesource.com/external/webrtc/+/ffb865f3e05fcba0c24baab27201ce2414b5430c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -50 lines) Patch
M webrtc/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/base/systeminfo.h View 1 chunk +49 lines, -0 lines 0 comments Download
A webrtc/base/systeminfo.cc View 1 chunk +213 lines, -0 lines 0 comments Download
A webrtc/base/systeminfo_unittest.cc View 1 chunk +150 lines, -0 lines 0 comments Download
M webrtc/media/base/videocapturer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/system_wrappers/source/cpu_info.cc View 1 chunk +2 lines, -50 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
skvlad
Created Revert of Delete unused code from systeminfo.
4 years ago (2016-12-17 00:46:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2584563004/1
4 years ago (2016-12-17 00:46:11 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-17 00:46:13 UTC) #5
skvlad
Committed patchset #1 (id:1) manually as ffb865f3e05fcba0c24baab27201ce2414b5430c (presubmit successful).
4 years ago (2016-12-17 00:48:35 UTC) #11
perkj_webrtc
lgtm
4 years ago (2016-12-19 07:44:53 UTC) #17
kthelgason
lgtm
4 years ago (2016-12-19 09:12:47 UTC) #18
kthelgason
3 years, 11 months ago (2017-01-04 13:00:01 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2614693002/ by kthelgason@webrtc.org.

The reason for reverting is: Relanding as downstream has been fixed..

Powered by Google App Engine
This is Rietveld 408576698