Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2609523002: Reland of Refactor webrtc/modules/desktop_capture for GN check (Closed)

Created:
3 years, 11 months ago by mbonadei
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Refactor webrtc/modules/desktop_capture for GN check Reason for revert: Trying to reland this CL. Original issue's description: > Revert of Refactor webrtc/modules/desktop_capture for GN check (patchset #1 id:1 of https://codereview.webrtc.org/2593713002/ ) > > Reason for revert: > Apparently breaks Chromium compile for unknown reason: > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/12314 > > Original issue's description: > > Refactor webrtc/modules/desktop_capture for GN check > > > > This moves some GN check configurations out of .gn to individual > > targets. > > > > The now checked target is: > > "//webrtc/modules/desktop_capture/*" > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2593713002 > > Cr-Commit-Position: refs/heads/master@{#15725} > > Committed: https://chromium.googlesource.com/external/webrtc/+/70870b921148fdc10d1131958a03d45f0f83f6fa > > TBR=sergeyu@chromium.org,mbonadei@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2597923002 > Cr-Commit-Position: refs/heads/master@{#15750} > Committed: https://chromium.googlesource.com/external/webrtc/+/d943c4845439aab311212b881d05ca0f2bb493f8 TBR=sergeyu@chromium.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2609523002 Cr-Commit-Position: refs/heads/master@{#15832} Committed: https://chromium.googlesource.com/external/webrtc/+/f423593f556f057a73b4fbd011c148b0d384caef

Patch Set 1 #

Patch Set 2 : Trying to break dependency with system_wrappers (.gn skipped to run chromium trybots) #

Patch Set 3 : Enabling `gn check` for desktop_capture (chromium trybots are green) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M .gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/BUILD.gn View 1 6 chunks +21 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_capture_types.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/shared_desktop_frame.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
mbonadei
Created Reland of actor webrtc/modules/desktop_capture for GN check
3 years, 11 months ago (2016-12-29 07:50:46 UTC) #1
kjellander_webrtc
I guess you're not done yet and that message is sent out when the CL ...
3 years, 11 months ago (2016-12-29 07:56:23 UTC) #3
mbonadei
On 2016/12/29 07:56:23, kjellander_webrtc wrote: > I guess you're not done yet and that message ...
3 years, 11 months ago (2016-12-29 07:59:00 UTC) #4
kjellander_webrtc
lgtm
3 years, 11 months ago (2016-12-29 09:43:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2609523002/90001
3 years, 11 months ago (2016-12-29 10:42:12 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2016-12-29 11:36:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:90001) as
https://chromium.googlesource.com/external/webrtc/+/f423593f556f057a73b4fbd01...

Powered by Google App Engine
This is Rietveld 408576698