Revert of Refactor webrtc/modules/desktop_capture for GN check

Revert of Refactor webrtc/modules/desktop_capture for GN check (patchset #1 id:1 of https://codereview.webrtc.org/2593713002/ )

Reason for revert:
Apparently breaks Chromium compile for unknown reason:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/12314

Original issue's description:
> Refactor webrtc/modules/desktop_capture for GN check
> 
> This moves some GN check configurations out of .gn to individual
> targets.
> 
> The now checked target is:
> "//webrtc/modules/desktop_capture/*"
> 
> BUG=webrtc:6828
> NOTRY=True
> 
> Review-Url: https://codereview.webrtc.org/2593713002
> Cr-Commit-Position: refs/heads/master@{#15725}
> Committed: https://chromium.googlesource.com/external/webrtc/+/70870b921148fdc10d1131958a03d45f0f83f6fa

TBR=sergeyu@chromium.org,mbonadei@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6828
Review-Url: https://codereview.webrtc.org/2597923002
Cr-Commit-Position: refs/heads/master@{#15750}
Committed: https://chromium.googlesource.com/external/webrtc/+/d943c4845439aab311212b881d05ca0f2bb493f8

[kjellander_webrtc, 2016-12-22 07:17:43]

Created Revert of Refactor webrtc/modules/desktop_capture for GN check

[kjellander_webrtc, 2016-12-22 07:19:44]

Manually solved merge conflict.

[kjellander_webrtc, 2016-12-22 07:19:48]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-12-22 07:19:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-22 07:19:59]

CQ is committing da patch.

Bot data: {"patchset_id": 70001, "attempt_start_ts": 1482391188107480,
"parent_rev": "444f1705d1ef773981a9a5e5db5226e8ab948997", "commit_rev":
"d943c4845439aab311212b881d05ca0f2bb493f8"}

[commit-bot: I haz the power, 2016-12-22 07:20:01]

Description was changed from

==========
Revert of Refactor webrtc/modules/desktop_capture for GN check (patchset #1 id:1
of https://codereview.webrtc.org/2593713002/ )

Reason for revert:
Apparently breaks Chromium compile for unknown reason:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...

Original issue's description:
> Refactor webrtc/modules/desktop_capture for GN check
> 
> This moves some GN check configurations out of .gn to individual
> targets.
> 
> The now checked target is:
> "//webrtc/modules/desktop_capture/*"
> 
> BUG=webrtc:6828
> NOTRY=True
> 
> Review-Url: https://codereview.webrtc.org/2593713002
> Cr-Commit-Position: refs/heads/master@{#15725}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/70870b921148fdc10d1131958...

TBR=sergeyu@chromium.org,mbonadei@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6828
==========

to

==========
Revert of Refactor webrtc/modules/desktop_capture for GN check (patchset #1 id:1
of https://codereview.webrtc.org/2593713002/ )

Reason for revert:
Apparently breaks Chromium compile for unknown reason:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...

Original issue's description:
> Refactor webrtc/modules/desktop_capture for GN check
> 
> This moves some GN check configurations out of .gn to individual
> targets.
> 
> The now checked target is:
> "//webrtc/modules/desktop_capture/*"
> 
> BUG=webrtc:6828
> NOTRY=True
> 
> Review-Url: https://codereview.webrtc.org/2593713002
> Cr-Commit-Position: refs/heads/master@{#15725}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/70870b921148fdc10d1131958...

TBR=sergeyu@chromium.org,mbonadei@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6828

Review-Url: https://codereview.webrtc.org/2597923002
Cr-Commit-Position: refs/heads/master@{#15750}
Committed:
https://chromium.googlesource.com/external/webrtc/+/d943c4845439aab311212b881...
==========

[commit-bot: I haz the power, 2016-12-22 07:20:02]

Committed patchset #2 (id:70001) as
https://chromium.googlesource.com/external/webrtc/+/d943c4845439aab311212b881...

[kjellander_webrtc, 2016-12-22 08:05:37]

On 2016/12/22 07:20:02, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:70001) as
>
https://chromium.googlesource.com/external/webrtc/+/d943c4845439aab311212b881...

This helped on the bots, but another seems to be needed to get them back into a
green state (https://codereview.webrtc.org/2594343002/). This is the risk with
having red bots - new errors can sneak in.

I'm going to work actively in Q1 to bring us protection from breakages in
Chromium by running Chromium trybots by default in our waterfalls.

[kjellander_webrtc, 2016-12-22 09:14:08]

On 2016/12/22 08:05:37, kjellander_webrtc wrote:
> On 2016/12/22 07:20:02, commit-bot: I haz the power wrote:
> > Committed patchset #2 (id:70001) as
> >
>
https://chromium.googlesource.com/external/webrtc/+/d943c4845439aab311212b881...
> 
> This helped on the bots, but another seems to be needed to get them back into
a
> green state (https://codereview.webrtc.org/2594343002/). This is the risk with
> having red bots - new errors can sneak in.
> 
> I'm going to work actively in Q1 to bring us protection from breakages in
> Chromium by running Chromium trybots by default in our waterfalls.

We had a look at this and the error in Chromium is quite strange. It seems to be
related to problems building the (new) dependency system_wrappers in the NaCl
environment:
[7151/7640] CXX
newlib_pnacl/obj/third_party/webrtc/system_wrappers/system_wrappers/aligned_malloc.o
FAILED:
newlib_pnacl/obj/third_party/webrtc/system_wrappers/system_wrappers/aligned_malloc.o

/b/c/cipd/goma/gomacc
../../native_client/toolchain/linux_x86/pnacl_newlib/bin/pnacl-clang++ -MMD -MF
newlib_pnacl/obj/third_party/webrtc/system_wrappers/system_wrappers/aligned_malloc.o.d
-DNACL_TC_REV=f7d719122cd7c2fe3ebc52e7c0b011c583bf3e9c -DV8_DEPRECATION_WARNINGS
-DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DUSE_PROPRIETARY_CODECS
-DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
-DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG
-DNVALGRIND -DWEBRTC_RESTRICT_LOGGING -DEXPAT_RELATIVE_PATH
-DENABLE_EXTERNAL_AUTH -DHAVE_OPENSSL_SSL_H -DHAVE_SCTP -DHAVE_SRTP
-DHAVE_WEBRTC_VIDEO -DHAVE_WEBRTC_VOICE -DLOGGING_INSIDE_WEBRTC
-DSSL_USE_OPENSSL -DUSE_WEBRTC_DEV_BRANCH -DFEATURE_ENABLE_SSL
-DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH
-DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DWEBRTC_CHROMIUM_BUILD
-DWEBRTC_POSIX -I../.. -Inewlib_pnacl/gen -I../../third_party/webrtc_overrides
-I../../third_party -fno-strict-aliasing -fcolor-diagnostics -Wall -Werror
-Wextra -Wno-missing-field-initializers -Wno-unused-parameter
-Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -O2
-fno-ident -fdata-sections -ffunction-sections -g2 -fvisibility=hidden
-fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti
-fno-exceptions -c
../../third_party/webrtc/system_wrappers/source/aligned_malloc.cc -o
newlib_pnacl/obj/third_party/webrtc/system_wrappers/system_wrappers/aligned_malloc.o
../../third_party/webrtc/system_wrappers/source/aligned_malloc.cc:13:10: fatal
error: 'memory.h' file not found
#include <memory.h>
         ^
1 error generated.
[7152/7640] LINK ./mcs_probe
[7153/7640] LINK ./gcm_unit_tests
[7154/7640] CXX
newlib_pnacl/obj/third_party/webrtc/system_wrappers/system_wrappers/clock.o
FAILED:
newlib_pnacl/obj/third_party/webrtc/system_wrappers/system_wrappers/clock.o 
/b/c/cipd/goma/gomacc
../../native_client/toolchain/linux_x86/pnacl_newlib/bin/pnacl-clang++ -MMD -MF
newlib_pnacl/obj/third_party/webrtc/system_wrappers/system_wrappers/clock.o.d
-DNACL_TC_REV=f7d719122cd7c2fe3ebc52e7c0b011c583bf3e9c -DV8_DEPRECATION_WARNINGS
-DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DUSE_PROPRIETARY_CODECS
-DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
-DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG
-DNVALGRIND -DWEBRTC_RESTRICT_LOGGING -DEXPAT_RELATIVE_PATH
-DENABLE_EXTERNAL_AUTH -DHAVE_OPENSSL_SSL_H -DHAVE_SCTP -DHAVE_SRTP
-DHAVE_WEBRTC_VIDEO -DHAVE_WEBRTC_VOICE -DLOGGING_INSIDE_WEBRTC
-DSSL_USE_OPENSSL -DUSE_WEBRTC_DEV_BRANCH -DFEATURE_ENABLE_SSL
-DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH
-DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DWEBRTC_CHROMIUM_BUILD
-DWEBRTC_POSIX -I../.. -Inewlib_pnacl/gen -I../../third_party/webrtc_overrides
-I../../third_party -fno-strict-aliasing -fcolor-diagnostics -Wall -Werror
-Wextra -Wno-missing-field-initializers -Wno-unused-parameter
-Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -O2
-fno-ident -fdata-sections -ffunction-sections -g2 -fvisibility=hidden
-fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti
-fno-exceptions -c ../../third_party/webrtc/system_wrappers/source/clock.cc -o
newlib_pnacl/obj/third_party/webrtc/system_wrappers/system_wrappers/clock.o
../../third_party/webrtc/system_wrappers/source/clock.cc:69:11: error: unknown
type name 'timeval'
  virtual timeval CurrentTimeVal() const = 0;
          ^
../../third_party/webrtc/system_wrappers/source/clock.cc:71:28: error: unknown
type name 'timeval'
  static void Adjust(const timeval& tv, uint32_t* adjusted_s,
                           ^
../../third_party/webrtc/system_wrappers/source/clock.cc:51:5: error: unknown
type name 'timeval'
    timeval tv = CurrentTimeVal();
    ^
../../third_party/webrtc/system_wrappers/source/clock.cc:60:5: error: unknown
type name 'timeval'
    timeval tv = CurrentTimeVal();
    ^
4 errors generated.

The best way to solve this would be to remove the referenced headers of
system_wrappers to avoid adding the dependency.

[mbonadei, 2016-12-29 07:50:46]

A revert of this CL (patchset #2 id:70001) has been created in
https://codereview.webrtc.org/2609523002/ by mbonadei@webrtc.org.

The reason for reverting is: Trying to reland this CL..