Refactor webrtc/modules/desktop_capture for GN check

Refactor webrtc/modules/desktop_capture for GN check

This moves some GN check configurations out of .gn to individual
targets.

The now checked target is:
"//webrtc/modules/desktop_capture/*"

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2593713002
Cr-Commit-Position: refs/heads/master@{#15725}
Committed: https://chromium.googlesource.com/external/webrtc/+/70870b921148fdc10d1131958a03d45f0f83f6fa

[mbonadei, 2016-12-20 17:21:11]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[mbonadei, 2016-12-20 17:22:21]

https://codereview.webrtc.org/2593713002/diff/1/webrtc/modules/desktop_captur...
File webrtc/modules/desktop_capture/BUILD.gn (right):

https://codereview.webrtc.org/2593713002/diff/1/webrtc/modules/desktop_captur...
webrtc/modules/desktop_capture/BUILD.gn:25: "shared_memory.cc",
I have moved `shared_memory.*` into :primitives to break the cyclic dependency
with :desktop_capture.

[kjellander_webrtc, 2016-12-20 18:36:20]

kjellander@webrtc.org changed reviewers:
+ sergeyu@chromium.org

[kjellander_webrtc, 2016-12-20 18:36:21]

lgtm, but let's wait for Sergey's review as well

[kjellander_webrtc, 2016-12-20 18:39:30]

Description was changed from

==========
Refactor webrtc/modules/desktop_capture for GN check

This moves some GN check configurations out of .gn to individual
targets.

The now checked target is:
"//webrtc/modules/desktop_capture/*"

BUG=6828
==========

to

==========
Refactor webrtc/modules/desktop_capture for GN check

This moves some GN check configurations out of .gn to individual
targets.

The now checked target is:
"//webrtc/modules/desktop_capture/*"

BUG=webrtc:6828
NOTRY=True
==========

[kjellander_webrtc, 2016-12-20 18:40:18]

On 2016/12/20 18:36:21, kjellander_webrtc wrote:
> lgtm, but let's wait for Sergey's review as well

I changed your BUG= field to read BUG=webrtc:6828. The prefix is needed to get
the right bug be posted (Chromium is the default).
I also added NOTRY=True

[Sergey Ulanov, 2016-12-20 20:15:13]

lgtm

[mbonadei, 2016-12-21 07:40:20]

The CQ bit was checked by mbonadei@webrtc.org

[commit-bot: I haz the power, 2016-12-21 07:40:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-21 07:42:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482306020036580, "parent_rev":
"bb0d56a5caf55e82868a6e9b632db194ad4f498c", "commit_rev":
"70870b921148fdc10d1131958a03d45f0f83f6fa"}

[commit-bot: I haz the power, 2016-12-21 07:42:07]

Description was changed from

==========
Refactor webrtc/modules/desktop_capture for GN check

This moves some GN check configurations out of .gn to individual
targets.

The now checked target is:
"//webrtc/modules/desktop_capture/*"

BUG=webrtc:6828
NOTRY=True
==========

to

==========
Refactor webrtc/modules/desktop_capture for GN check

This moves some GN check configurations out of .gn to individual
targets.

The now checked target is:
"//webrtc/modules/desktop_capture/*"

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2593713002
Cr-Commit-Position: refs/heads/master@{#15725}
Committed:
https://chromium.googlesource.com/external/webrtc/+/70870b921148fdc10d1131958...
==========

[commit-bot: I haz the power, 2016-12-21 07:42:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/70870b921148fdc10d1131958...

[kjellander (google.com), 2016-12-22 07:11:37]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2598953002/ by kjellander@google.com.

The reason for reverting is: Apparently breaks Chromium compile for unknown
reason:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui....

[kjellander_webrtc, 2016-12-22 07:17:43]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2597923002/ by kjellander@webrtc.org.

The reason for reverting is: Apparently breaks Chromium compile for unknown
reason:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui....