Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2582513002: Revert of Avoid precision loss in TrendlineEstimator from int64_t -> double conversion (Closed)

Created:
4 years ago by terelius
Modified:
4 years ago
Reviewers:
brandtr, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Avoid precision loss in TrendlineEstimator from int64_t -> double conversion (patchset #7 id:120001 of https://codereview.webrtc.org/2577463002/ ) Reason for revert: Multiple definitions of TestEstimator Original issue's description: > Avoid precision loss in TrendlineEstimator by passing the arrival time as an int64_t instead of a double. > > BUG=webrtc:6884 > > Committed: https://crrev.com/c12cbaf9dd0729dd45f3fc45a1938d1b3455e40a > Cr-Commit-Position: refs/heads/master@{#15631} TBR=stefan@webrtc.org,brandtr@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6884 Committed: https://crrev.com/43c382111dede5cb06a3b5d0d05a4f4ffd350520 Cr-Commit-Position: refs/heads/master@{#15636}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -58 lines) Patch
M webrtc/modules/congestion_controller/trendline_estimator.h View 3 chunks +2 lines, -8 lines 0 comments Download
M webrtc/modules/congestion_controller/trendline_estimator.cc View 4 chunks +12 lines, -22 lines 0 comments Download
M webrtc/modules/congestion_controller/trendline_estimator_unittest.cc View 1 chunk +69 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
terelius
Created Revert of Avoid precision loss in TrendlineEstimator from int64_t -> double conversion
4 years ago (2016-12-15 14:42:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2582513002/1
4 years ago (2016-12-15 14:42:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 14:42:46 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-15 14:42:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43c382111dede5cb06a3b5d0d05a4f4ffd350520
Cr-Commit-Position: refs/heads/master@{#15636}

Powered by Google App Engine
This is Rietveld 408576698