Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: webrtc/modules/congestion_controller/trendline_estimator.h

Issue 2582513002: Revert of Avoid precision loss in TrendlineEstimator from int64_t -> double conversion (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/congestion_controller/trendline_estimator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/congestion_controller/trendline_estimator.h
diff --git a/webrtc/modules/congestion_controller/trendline_estimator.h b/webrtc/modules/congestion_controller/trendline_estimator.h
index 7ca9b7d072beaf60fc3d6d202a191d5b3eb39136..0bf9bf27c74ce05e9da6f4a8989fecb7ae4e5c91 100644
--- a/webrtc/modules/congestion_controller/trendline_estimator.h
+++ b/webrtc/modules/congestion_controller/trendline_estimator.h
@@ -10,13 +10,11 @@
#ifndef WEBRTC_MODULES_CONGESTION_CONTROLLER_TRENDLINE_ESTIMATOR_H_
#define WEBRTC_MODULES_CONGESTION_CONTROLLER_TRENDLINE_ESTIMATOR_H_
-#include <stddef.h>
-#include <stdint.h>
-
#include <list>
#include <utility>
#include "webrtc/base/constructormagic.h"
+#include "webrtc/common_types.h"
namespace webrtc {
@@ -35,9 +33,7 @@
// Update the estimator with a new sample. The deltas should represent deltas
// between timestamp groups as defined by the InterArrival class.
- void Update(double recv_delta_ms,
- double send_delta_ms,
- int64_t arrival_time_ms);
+ void Update(double recv_delta_ms, double send_delta_ms, double now_ms);
// Returns the estimated trend k multiplied by some gain.
// 0 < k < 1 -> the delay increases, queues are filling up
@@ -55,8 +51,6 @@
const double threshold_gain_;
// Used by the existing threshold.
unsigned int num_of_deltas_;
- // Keep the arrival times small by using the change from the first packet.
- int64_t first_arrival_time_ms;
// Exponential backoff filtering.
double accumulated_delay_;
double smoothed_delay_;
« no previous file with comments | « no previous file | webrtc/modules/congestion_controller/trendline_estimator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698