Reland of Delete VideoFrame default constructor, and IsZeroSize method.

Reland of Delete VideoFrame default constructor, and IsZeroSize method. (patchset #1 id:1 of https://codereview.webrtc.org/2574123002/ )

Reason for revert:
Fixing perf tests.

Original issue's description:
> Revert of Delete VideoFrame default constructor, and IsZeroSize method. (patchset #5 id:80001 of https://codereview.webrtc.org/2541863002/ )
>
> Reason for revert:
> Crashes perf tests, e.g.,
>
> ./out/Debug/webrtc_perf_tests --gtest_filter='FullStackTest.ScreenshareSlidesVP8_2TL_VeryLossyNet'
>
> dies with an assert related to rtc::Optional.
>
> Original issue's description:
> > Delete VideoFrame default constructor, and IsZeroSize method.
> >
> > This ensures that the video_frame_buffer method never can return a
> > null pointer.
> >
> > BUG=webrtc:6591
> >
> > Committed: https://crrev.com/bfcf561923a42005e4c7d66d8e72e5932155f997
> > Cr-Commit-Position: refs/heads/master@{#15574}
>
> TBR=magjed@webrtc.org,stefan@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6591
>
> Committed: https://crrev.com/0989fbcad2ca4eb5805a77e8ebfefd3af06ade23
> Cr-Commit-Position: refs/heads/master@{#15597}

TBR=magjed@webrtc.org,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6591
Committed: https://crrev.com/df2ceb88a881f219cd319c574c1bc723e6736dc1
Cr-Commit-Position: refs/heads/master@{#15633}

[nisse-webrtc, 2016-12-14 13:16:46]

Created Reland of Delete VideoFrame default constructor, and IsZeroSize method.

[nisse-webrtc, 2016-12-14 14:09:46]

Found and fixed a bug, and 

 ./out/Debug/webrtc_perf_tests
--gtest_filter='FullStackTest.ScreenshareSlidesVP8_2TL_VeryLossyNet'

no longer crashes. Any further tests to do before relanding?

[nisse-webrtc, 2016-12-15 10:20:25]

nisse@webrtc.org changed reviewers:
+ brandtr@webrtc.org

[nisse-webrtc, 2016-12-15 10:20:25]

Rasmus: Any additional tests to de before relanding?

[magjed_webrtc, 2016-12-15 11:31:07]

Next time you should probably rebase in a separate patch set and then apply the
fix in yet another patch set. It's very difficult now to see what the fix is.

lgtm

[nisse-webrtc, 2016-12-15 11:51:56]

On 2016/12/15 11:31:07, magjed_webrtc wrote:
> Next time you should probably rebase in a separate patch set and then apply
the
> fix in yet another patch set. It's very difficult now to see what the fix is.

Sorry about that. Not sure how it happened, I can't recall doing any explicit
rebase.
Maybe it happened as part of git cl patch? So next time, I should do git cl
patch immediately 
followed by git cl upload?

This is the fix:

https://codereview.webrtc.org/2574183002/diff2/1:290001/webrtc/video/video_qu....

[brandtr, 2016-12-15 11:54:00]

On 2016/12/15 11:51:56, nisse-webrtc wrote:
> On 2016/12/15 11:31:07, magjed_webrtc wrote:
> > Next time you should probably rebase in a separate patch set and then apply
> the
> > fix in yet another patch set. It's very difficult now to see what the fix
is.
> 
> Sorry about that. Not sure how it happened, I can't recall doing any explicit
> rebase.
> Maybe it happened as part of git cl patch? So next time, I should do git cl
> patch immediately 
> followed by git cl upload?
> 
> This is the fix:
> 
>
https://codereview.webrtc.org/2574183002/diff2/1:290001/webrtc/video/video_qu....

lgtm.

Before landing, try running "./out/Debug/webrtc_perf_tests
--gtest_filter='FullStackTest.*'" as well however. That might take a couple of
minutes, but verifies that all other tests work too.

[nisse-webrtc, 2016-12-15 12:41:49]

nisse@webrtc.org changed reviewers:
+ pbos@webrtc.org

[nisse-webrtc, 2016-12-15 12:41:49]

On 2016/12/15 11:54:00, brandtr wrote:
> Before landing, try running "./out/Debug/webrtc_perf_tests
> --gtest_filter='FullStackTest.*'" as well however. That might take a couple of
> minutes, but verifies that all other tests work too.

Three failures (but no crashes):
[ RUN      ] FullStackTest.ForemanCifWithoutPacketlossH264
- Uh, I'm-I'm not quite dead, sir.
- Uh, I-I think uh, I could pull through, sir.
../../webrtc/video/video_quality_test.cc:348: Failure
Expected: (frames_processed) > (last_frames_processed), actual: 0 vs 0
Analyzer stalled while waiting for test to finish.
- Farewell, sweet Concorde!
[  FAILED  ] FullStackTest.ForemanCifWithoutPacketlossH264 (65048 ms)
[ RUN      ] FullStackTest.ForemanCifPlr5H264
- Uh, I'm-I'm not quite dead, sir.
- Uh, I-I think uh, I could pull through, sir.
../../webrtc/video/video_quality_test.cc:348: Failure
Expected: (frames_processed) > (last_frames_processed), actual: 0 vs 0
Analyzer stalled while waiting for test to finish.
- Farewell, sweet Concorde!
[  FAILED  ] FullStackTest.ForemanCifPlr5H264 (66039 ms)
[ RUN      ] FullStackTest.ForemanCifPlr5H264Flexfec
- Uh, I'm-I'm not quite dead, sir.
- Uh, I-I think uh, I could pull through, sir.
../../webrtc/video/video_quality_test.cc:348: Failure
Expected: (frames_processed) > (last_frames_processed), actual: 0 vs 0
Analyzer stalled while waiting for test to finish.
- Farewell, sweet Concorde!
[  FAILED  ] FullStackTest.ForemanCifPlr5H264Flexfec (63038 ms)

Not quite clear to me what this means. The test makes little sense to me,

      if (frames_processed == last_frames_processed) {
        EXPECT_GT(frames_processed, last_frames_processed)

Whenever the first condition is true, the EXPECT will fail.

Adding pbos, who committed that check a year ago.

[nisse-webrtc, 2016-12-15 14:29:16]

On 2016/12/15 12:41:49, nisse-webrtc wrote:
> On 2016/12/15 11:54:00, brandtr wrote:
> > Before landing, try running "./out/Debug/webrtc_perf_tests
> > --gtest_filter='FullStackTest.*'" as well however. That might take a couple
of
> > minutes, but verifies that all other tests work too.
> 
> Three failures (but no crashes):

I get the same three failures on the master branch. Relanding now.

[nisse-webrtc, 2016-12-15 14:29:35]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-12-15 14:29:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-15 14:29:53]

CQ is committing da patch.

Bot data: {"patchset_id": 290001, "attempt_start_ts": 1481812175929770,
"parent_rev": "b1c2bc6fb1d9af86d8c600effc610907e42d7e00", "commit_rev":
"058fb7eca0d8128cdd9913b06ffe5bb36a719447"}

[commit-bot: I haz the power, 2016-12-15 14:29:56]

Description was changed from

==========
Reland of Delete VideoFrame default constructor, and IsZeroSize method.
(patchset #1 id:1 of https://codereview.webrtc.org/2574123002/ )

Reason for revert:
Fixing perf tests.

Original issue's description:
> Revert of Delete VideoFrame default constructor, and IsZeroSize method.
(patchset #5 id:80001 of https://codereview.webrtc.org/2541863002/ )
> 
> Reason for revert:
> Crashes perf tests, e.g.,
> 
> ./out/Debug/webrtc_perf_tests
--gtest_filter='FullStackTest.ScreenshareSlidesVP8_2TL_VeryLossyNet'
> 
> dies with an assert related to rtc::Optional.
> 
> Original issue's description:
> > Delete VideoFrame default constructor, and IsZeroSize method.
> >
> > This ensures that the video_frame_buffer method never can return a
> > null pointer.
> >
> > BUG=webrtc:6591
> >
> > Committed: https://crrev.com/bfcf561923a42005e4c7d66d8e72e5932155f997
> > Cr-Commit-Position: refs/heads/master@{#15574}
> 
> TBR=magjed@webrtc.org,stefan@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6591
> 
> Committed: https://crrev.com/0989fbcad2ca4eb5805a77e8ebfefd3af06ade23
> Cr-Commit-Position: refs/heads/master@{#15597}

TBR=magjed@webrtc.org,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6591
==========

to

==========
Reland of Delete VideoFrame default constructor, and IsZeroSize method.
(patchset #1 id:1 of https://codereview.webrtc.org/2574123002/ )

Reason for revert:
Fixing perf tests.

Original issue's description:
> Revert of Delete VideoFrame default constructor, and IsZeroSize method.
(patchset #5 id:80001 of https://codereview.webrtc.org/2541863002/ )
> 
> Reason for revert:
> Crashes perf tests, e.g.,
> 
> ./out/Debug/webrtc_perf_tests
--gtest_filter='FullStackTest.ScreenshareSlidesVP8_2TL_VeryLossyNet'
> 
> dies with an assert related to rtc::Optional.
> 
> Original issue's description:
> > Delete VideoFrame default constructor, and IsZeroSize method.
> >
> > This ensures that the video_frame_buffer method never can return a
> > null pointer.
> >
> > BUG=webrtc:6591
> >
> > Committed: https://crrev.com/bfcf561923a42005e4c7d66d8e72e5932155f997
> > Cr-Commit-Position: refs/heads/master@{#15574}
> 
> TBR=magjed@webrtc.org,stefan@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6591
> 
> Committed: https://crrev.com/0989fbcad2ca4eb5805a77e8ebfefd3af06ade23
> Cr-Commit-Position: refs/heads/master@{#15597}

TBR=magjed@webrtc.org,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6591

Review-Url: https://codereview.webrtc.org/2574183002
==========

[commit-bot: I haz the power, 2016-12-15 14:29:57]

Committed patchset #2 (id:290001)

[commit-bot: I haz the power, 2016-12-15 14:30:03]

Description was changed from

==========
Reland of Delete VideoFrame default constructor, and IsZeroSize method.
(patchset #1 id:1 of https://codereview.webrtc.org/2574123002/ )

Reason for revert:
Fixing perf tests.

Original issue's description:
> Revert of Delete VideoFrame default constructor, and IsZeroSize method.
(patchset #5 id:80001 of https://codereview.webrtc.org/2541863002/ )
> 
> Reason for revert:
> Crashes perf tests, e.g.,
> 
> ./out/Debug/webrtc_perf_tests
--gtest_filter='FullStackTest.ScreenshareSlidesVP8_2TL_VeryLossyNet'
> 
> dies with an assert related to rtc::Optional.
> 
> Original issue's description:
> > Delete VideoFrame default constructor, and IsZeroSize method.
> >
> > This ensures that the video_frame_buffer method never can return a
> > null pointer.
> >
> > BUG=webrtc:6591
> >
> > Committed: https://crrev.com/bfcf561923a42005e4c7d66d8e72e5932155f997
> > Cr-Commit-Position: refs/heads/master@{#15574}
> 
> TBR=magjed@webrtc.org,stefan@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6591
> 
> Committed: https://crrev.com/0989fbcad2ca4eb5805a77e8ebfefd3af06ade23
> Cr-Commit-Position: refs/heads/master@{#15597}

TBR=magjed@webrtc.org,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6591

Review-Url: https://codereview.webrtc.org/2574183002
==========

to

==========
Reland of Delete VideoFrame default constructor, and IsZeroSize method.
(patchset #1 id:1 of https://codereview.webrtc.org/2574123002/ )

Reason for revert:
Fixing perf tests.

Original issue's description:
> Revert of Delete VideoFrame default constructor, and IsZeroSize method.
(patchset #5 id:80001 of https://codereview.webrtc.org/2541863002/ )
>
> Reason for revert:
> Crashes perf tests, e.g.,
>
> ./out/Debug/webrtc_perf_tests
--gtest_filter='FullStackTest.ScreenshareSlidesVP8_2TL_VeryLossyNet'
>
> dies with an assert related to rtc::Optional.
>
> Original issue's description:
> > Delete VideoFrame default constructor, and IsZeroSize method.
> >
> > This ensures that the video_frame_buffer method never can return a
> > null pointer.
> >
> > BUG=webrtc:6591
> >
> > Committed: https://crrev.com/bfcf561923a42005e4c7d66d8e72e5932155f997
> > Cr-Commit-Position: refs/heads/master@{#15574}
>
> TBR=magjed@webrtc.org,stefan@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6591
>
> Committed: https://crrev.com/0989fbcad2ca4eb5805a77e8ebfefd3af06ade23
> Cr-Commit-Position: refs/heads/master@{#15597}

TBR=magjed@webrtc.org,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6591

Committed: https://crrev.com/df2ceb88a881f219cd319c574c1bc723e6736dc1
Cr-Commit-Position: refs/heads/master@{#15633}
==========

[commit-bot: I haz the power, 2016-12-15 14:30:04]

Patchset 2 (id:??) landed as
https://crrev.com/df2ceb88a881f219cd319c574c1bc723e6736dc1
Cr-Commit-Position: refs/heads/master@{#15633}