webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc - Issue 2574183002: Reland of Delete VideoFrame default constructor, and IsZeroSize method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

Issue 2574183002: Reland of Delete VideoFrame default constructor, and IsZeroSize method. (Closed)

Patch Set: Use FrameComparison::input_time_ms. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

diff --git a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

index df0e40929f2b6bd366d6f036e584ba38c1153f47..2fbceb1d7904b8a5ff7714a30fcce6afe1bf9266 100644

--- a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

+++ b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

@@ -660,8 +660,6 @@ int VP8EncoderImpl::Encode(const VideoFrame& frame,

if (!inited_)

return WEBRTC_VIDEO_CODEC_UNINITIALIZED;

- if (frame.IsZeroSize())

- return WEBRTC_VIDEO_CODEC_ERR_PARAMETER;

if (encoded_complete_callback_ == NULL)

return WEBRTC_VIDEO_CODEC_UNINITIALIZED;