webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc - Issue 2574183002: Reland of Delete VideoFrame default constructor, and IsZeroSize method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

Issue 2574183002: Reland of Delete VideoFrame default constructor, and IsZeroSize method. (Closed)

Patch Set: Use FrameComparison::input_time_ms. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/codecs/test/videoprocessor.h ('k') | webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

diff --git a/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc b/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

index 6e3ae4cb435992b8dd6043a8dd89b4a17d1906b2..cb35fdc46241cae397eba09d773c7a3ac07a299c 100644

--- a/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

+++ b/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

@@ -300,7 +300,6 @@ int SimulcastEncoderAdapter::Encode(

// TODO(perkj): ensure that works going forward, and figure out how this

// affects webrtc:5683.

if ((dst_width == src_width && dst_height == src_height) ||

- input_image.IsZeroSize() ||

input_image.video_frame_buffer()->native_handle()) {

int ret = streaminfos_[stream_idx].encoder->Encode(

input_image, codec_specific_info, &stream_frame_types);