Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2573593003: Rename RtpPayloadTypeRegistry::SetCodec() to ::AddCodec(). (Closed)

Created:
4 years ago by johan
Modified:
4 years ago
Reviewers:
philipel, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman, sprang_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename RtpStreamReceiver::SetCodec() to ::AddCodec(). AddCodec represents better what this function actually does. BUG=None Committed: https://crrev.com/07e276c8d54ecee97452af3a9aae85d314523700 Cr-Commit-Position: refs/heads/master@{#15565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M webrtc/video/rtp_stream_receiver.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/rtp_stream_receiver.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
johan
Philipel, we have talked about this. Stefan is owner.
4 years ago (2016-12-13 09:01:40 UTC) #2
stefan-webrtc
lgtm
4 years ago (2016-12-13 09:22:27 UTC) #5
philipel
lgtm
4 years ago (2016-12-13 09:54:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2573593003/1
4 years ago (2016-12-13 10:02:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 10:23:07 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-13 10:23:49 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07e276c8d54ecee97452af3a9aae85d314523700
Cr-Commit-Position: refs/heads/master@{#15565}

Powered by Google App Engine
This is Rietveld 408576698