Skip RTCMediaStreamTrackStats.echoReturnLoss[Enhancement] default value.

Skip RTCMediaStreamTrackStats.echoReturnLoss[Enhancement] default value.

Due to the Chromium implementation[1] of GetAudioProcesssingStats,
echoReturnLoss and echoReturnLossEnhancement could default to -100 when
no value was available. This should be improved by using rtc::Optional
or AudioProcessorInterface::GetStats being able to return false, but
this requires a bunch of refactoring.

In the meantime we "blacklist" the value -100 which is a nonsense value
anyway. In that case echoReturnLoss[Enhancement] is correctly left
undefined.

[1] https://cs.chromium.org/chromium/src/content/renderer/media/media_stream_audio_processor_options.cc?sq=package:chromium&dr=C&rcl=1481530670&l=461

BUG=chromium:669877
Committed: https://crrev.com/9a394f0649d39737a791d17e73ad2603e3d162fb
Cr-Commit-Position: refs/heads/master@{#15611}

[hbos, 2016-12-12 14:22:39]

hbos@webrtc.org changed reviewers:
+ hta@webrtc.org, ivoc@webrtc.org

[hbos, 2016-12-12 14:22:40]

Please take a look, ivoc and hta.

[hta-webrtc, 2016-12-12 16:02:29]

lgtm

However, would be nice to have an unittest.

[ivoc, 2016-12-12 16:04:05]

lgtm, but note that there are various other audio stats that use dummy default
values.

[hbos, 2016-12-14 15:44:06]

On 2016/12/12 16:02:29, hta-webrtc wrote:
> lgtm
> 
> However, would be nice to have an unittest.

Done.

[hbos, 2016-12-14 15:44:27]

The CQ bit was checked by hbos@webrtc.org

[hbos, 2016-12-14 15:44:27]

The patchset sent to the CQ was uploaded after l-g-t-m from ivoc@webrtc.org,
hta@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2573443002/#ps20001 (title:
"Unittest for the -100 = undefined case")

[commit-bot: I haz the power, 2016-12-14 15:44:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-14 15:58:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481730267387360,
"parent_rev": "62c9f0373bb17affa4ee73a0c1a0b3293f989eef", "commit_rev":
"ba7ca79e42e63934073eae128098afcb4018a6d7"}

[commit-bot: I haz the power, 2016-12-14 15:58:25]

Description was changed from

==========
Skip RTCMediaStreamTrackStats.echoReturnLoss[Enhancement] default value.

Due to the Chromium implementation[1] of GetAudioProcesssingStats,
echoReturnLoss and echoReturnLossEnhancement could default to -100 when
no value was available. This should be improved by using rtc::Optional
or AudioProcessorInterface::GetStats being able to return false, but
this requires a bunch of refactoring.

In the meantime we "blacklist" the value -100 which is a nonsense value
anyway. In that case echoReturnLoss[Enhancement] is correctly left
undefined.

[1]
https://cs.chromium.org/chromium/src/content/renderer/media/media_stream_audi...

BUG=chromium:669877
==========

to

==========
Skip RTCMediaStreamTrackStats.echoReturnLoss[Enhancement] default value.

Due to the Chromium implementation[1] of GetAudioProcesssingStats,
echoReturnLoss and echoReturnLossEnhancement could default to -100 when
no value was available. This should be improved by using rtc::Optional
or AudioProcessorInterface::GetStats being able to return false, but
this requires a bunch of refactoring.

In the meantime we "blacklist" the value -100 which is a nonsense value
anyway. In that case echoReturnLoss[Enhancement] is correctly left
undefined.

[1]
https://cs.chromium.org/chromium/src/content/renderer/media/media_stream_audi...

BUG=chromium:669877

Review-Url: https://codereview.webrtc.org/2573443002
==========

[commit-bot: I haz the power, 2016-12-14 15:58:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 15:58:34]

Description was changed from

==========
Skip RTCMediaStreamTrackStats.echoReturnLoss[Enhancement] default value.

Due to the Chromium implementation[1] of GetAudioProcesssingStats,
echoReturnLoss and echoReturnLossEnhancement could default to -100 when
no value was available. This should be improved by using rtc::Optional
or AudioProcessorInterface::GetStats being able to return false, but
this requires a bunch of refactoring.

In the meantime we "blacklist" the value -100 which is a nonsense value
anyway. In that case echoReturnLoss[Enhancement] is correctly left
undefined.

[1]
https://cs.chromium.org/chromium/src/content/renderer/media/media_stream_audi...

BUG=chromium:669877

Review-Url: https://codereview.webrtc.org/2573443002
==========

to

==========
Skip RTCMediaStreamTrackStats.echoReturnLoss[Enhancement] default value.

Due to the Chromium implementation[1] of GetAudioProcesssingStats,
echoReturnLoss and echoReturnLossEnhancement could default to -100 when
no value was available. This should be improved by using rtc::Optional
or AudioProcessorInterface::GetStats being able to return false, but
this requires a bunch of refactoring.

In the meantime we "blacklist" the value -100 which is a nonsense value
anyway. In that case echoReturnLoss[Enhancement] is correctly left
undefined.

[1]
https://cs.chromium.org/chromium/src/content/renderer/media/media_stream_audi...

BUG=chromium:669877

Committed: https://crrev.com/9a394f0649d39737a791d17e73ad2603e3d162fb
Cr-Commit-Position: refs/heads/master@{#15611}
==========

[commit-bot: I haz the power, 2016-12-14 15:58:35]

Patchset 2 (id:??) landed as
https://crrev.com/9a394f0649d39737a791d17e73ad2603e3d162fb
Cr-Commit-Position: refs/heads/master@{#15611}