Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: webrtc/api/rtcstatscollector_unittest.cc

Issue 2573443002: Skip RTCMediaStreamTrackStats.echoReturnLoss[Enhancement] default value. (Closed)
Patch Set: Unittest for the -100 = undefined case Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/rtcstatscollector.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/rtcstatscollector_unittest.cc
diff --git a/webrtc/api/rtcstatscollector_unittest.cc b/webrtc/api/rtcstatscollector_unittest.cc
index b973044c94751582d187dbc112f02703b1ff06c8..283442f9f3f45e871b225b0195dfba38eb6d785a 100644
--- a/webrtc/api/rtcstatscollector_unittest.cc
+++ b/webrtc/api/rtcstatscollector_unittest.cc
@@ -1209,6 +1209,46 @@ TEST_F(RTCStatsCollectorTest,
}
TEST_F(RTCStatsCollectorTest,
+ CollectRTCMediaStreamStatsAndRTCMediaStreamTrackStats_Audio_Defaults) {
+ rtc::scoped_refptr<StreamCollection> local_streams =
+ StreamCollection::Create();
+ EXPECT_CALL(test_->pc(), local_streams())
+ .WillRepeatedly(Return(local_streams));
+
+ rtc::scoped_refptr<MediaStream> local_stream =
+ MediaStream::Create("LocalStreamLabel");
+ local_streams->AddStream(local_stream);
+
+ // Local audio track
+ AudioProcessorInterface::AudioProcessorStats local_audio_processor_stats;
+ local_audio_processor_stats.echo_return_loss = -100;
+ local_audio_processor_stats.echo_return_loss_enhancement = -100;
+ rtc::scoped_refptr<FakeAudioTrackForStats> local_audio_track =
+ FakeAudioTrackForStats::Create(
+ "LocalAudioTrackID",
+ MediaStreamTrackInterface::TrackState::kEnded,
+ 32767,
+ new FakeAudioProcessorForStats(local_audio_processor_stats));
+ local_stream->AddTrack(local_audio_track);
+
+ rtc::scoped_refptr<const RTCStatsReport> report = GetStatsReport();
+
+ RTCMediaStreamTrackStats expected_local_audio_track(
+ "RTCMediaStreamTrack_LocalAudioTrackID", report->timestamp_us());
+ expected_local_audio_track.track_identifier = local_audio_track->id();
+ expected_local_audio_track.remote_source = false;
+ expected_local_audio_track.ended = true;
+ expected_local_audio_track.detached = false;
+ expected_local_audio_track.audio_level = 1.0;
+ // Should be undefined: |expected_local_audio_track.echo_return_loss| and
+ // |expected_local_audio_track.echo_return_loss_enhancement|.
+ EXPECT_TRUE(report->Get(expected_local_audio_track.id()));
+ EXPECT_EQ(expected_local_audio_track,
+ report->Get(expected_local_audio_track.id())->cast_to<
+ RTCMediaStreamTrackStats>());
+}
+
+TEST_F(RTCStatsCollectorTest,
CollectRTCMediaStreamStatsAndRTCMediaStreamTrackStats_Video) {
rtc::scoped_refptr<StreamCollection> local_streams =
StreamCollection::Create();
« no previous file with comments | « webrtc/api/rtcstatscollector.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698