Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: webrtc/api/rtcstatscollector.cc

Issue 2573443002: Skip RTCMediaStreamTrackStats.echoReturnLoss[Enhancement] default value. (Closed)
Patch Set: Unittest for the -100 = undefined case Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/rtcstatscollector_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/rtcstatscollector.cc
diff --git a/webrtc/api/rtcstatscollector.cc b/webrtc/api/rtcstatscollector.cc
index 9998d9aafe89ed40eb212712adff98caec0cd275..5289c4820b916be021e1c23f34aab3cd75f562d7 100644
--- a/webrtc/api/rtcstatscollector.cc
+++ b/webrtc/api/rtcstatscollector.cc
@@ -317,10 +317,14 @@ void ProduceMediaStreamAndTrackStats(
if (audio_track->GetAudioProcessor()) {
AudioProcessorInterface::AudioProcessorStats audio_processor_stats;
audio_track->GetAudioProcessor()->GetStats(&audio_processor_stats);
- audio_track_stats->echo_return_loss = static_cast<double>(
- audio_processor_stats.echo_return_loss);
- audio_track_stats->echo_return_loss_enhancement = static_cast<double>(
- audio_processor_stats.echo_return_loss_enhancement);
+ if (audio_processor_stats.echo_return_loss != -100) {
+ audio_track_stats->echo_return_loss = static_cast<double>(
+ audio_processor_stats.echo_return_loss);
+ }
+ if (audio_processor_stats.echo_return_loss_enhancement != -100) {
+ audio_track_stats->echo_return_loss_enhancement = static_cast<double>(
+ audio_processor_stats.echo_return_loss_enhancement);
+ }
}
report->AddStats(std::move(audio_track_stats));
}
« no previous file with comments | « no previous file | webrtc/api/rtcstatscollector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698