Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2566143002: New PeerConnectionInterface::GetStats: No bogus default implementation. (Closed)

Created:
4 years ago by hbos
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

New PeerConnectionInterface::GetStats: No bogus default implementation. The Chromium mock implementation implements the new GetStats API, so we can remove this default implementation. BUG=chromium:627816 Committed: https://crrev.com/8f2309478da41cd8b829d022874dfd5ddc58551c Cr-Commit-Position: refs/heads/master@{#15563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M webrtc/api/peerconnectioninterface.h View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
hbos
Please take a look, deadbeef.
4 years ago (2016-12-12 15:21:40 UTC) #6
Taylor Brandstetter
lgtm
4 years ago (2016-12-13 00:28:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2566143002/1
4 years ago (2016-12-13 09:43:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 09:45:12 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8f2309478da41cd8b829d022874dfd5ddc58551c Cr-Commit-Position: refs/heads/master@{#15563}
4 years ago (2016-12-13 09:45:20 UTC) #15
hbos
4 years ago (2016-12-13 10:35:06 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2575493002/ by hbos@webrtc.org.

The reason for reverting is: Breaks google3 importer:
http://webrtc-buildbot-master.mtv.corp.google.com:21000/builders/WebRTC%20goo....

Powered by Google App Engine
This is Rietveld 408576698