Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: webrtc/api/peerconnectioninterface.h

Issue 2566143002: New PeerConnectionInterface::GetStats: No bogus default implementation. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/peerconnectioninterface.h
diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h
index 29badbd8bb6f8bdc687d8cbe6933adf87ee4a452..25c1d1bdfbfcd7441773fd7ffa06b0bdd4481fc0 100644
--- a/webrtc/api/peerconnectioninterface.h
+++ b/webrtc/api/peerconnectioninterface.h
@@ -474,10 +474,8 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
StatsOutputLevel level) = 0;
// Gets stats using the new stats collection API, see webrtc/api/stats/. These
// will replace old stats collection API when the new API has matured enough.
- // TODO(hbos): Default implementation that does nothing only exists as to not
- // break third party projects. As soon as they have been updated this should
- // be changed to "= 0;".
- virtual void GetStats(RTCStatsCollectorCallback* callback) {}
+ // Master bug: crbug.com/627816
+ virtual void GetStats(RTCStatsCollectorCallback* callback) = 0;
virtual rtc::scoped_refptr<DataChannelInterface> CreateDataChannel(
const std::string& label,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698