Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: webrtc/api/peerconnectioninterface.h

Issue 2566143002: New PeerConnectionInterface::GetStats: No bogus default implementation. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 456 matching lines...) Expand 10 before | Expand all | Expand 10 after
467 virtual std::vector<rtc::scoped_refptr<RtpReceiverInterface>> GetReceivers() 467 virtual std::vector<rtc::scoped_refptr<RtpReceiverInterface>> GetReceivers()
468 const { 468 const {
469 return std::vector<rtc::scoped_refptr<RtpReceiverInterface>>(); 469 return std::vector<rtc::scoped_refptr<RtpReceiverInterface>>();
470 } 470 }
471 471
472 virtual bool GetStats(StatsObserver* observer, 472 virtual bool GetStats(StatsObserver* observer,
473 MediaStreamTrackInterface* track, 473 MediaStreamTrackInterface* track,
474 StatsOutputLevel level) = 0; 474 StatsOutputLevel level) = 0;
475 // Gets stats using the new stats collection API, see webrtc/api/stats/. These 475 // Gets stats using the new stats collection API, see webrtc/api/stats/. These
476 // will replace old stats collection API when the new API has matured enough. 476 // will replace old stats collection API when the new API has matured enough.
477 // TODO(hbos): Default implementation that does nothing only exists as to not 477 // Master bug: crbug.com/627816
478 // break third party projects. As soon as they have been updated this should 478 virtual void GetStats(RTCStatsCollectorCallback* callback) = 0;
479 // be changed to "= 0;".
480 virtual void GetStats(RTCStatsCollectorCallback* callback) {}
481 479
482 virtual rtc::scoped_refptr<DataChannelInterface> CreateDataChannel( 480 virtual rtc::scoped_refptr<DataChannelInterface> CreateDataChannel(
483 const std::string& label, 481 const std::string& label,
484 const DataChannelInit* config) = 0; 482 const DataChannelInit* config) = 0;
485 483
486 virtual const SessionDescriptionInterface* local_description() const = 0; 484 virtual const SessionDescriptionInterface* local_description() const = 0;
487 virtual const SessionDescriptionInterface* remote_description() const = 0; 485 virtual const SessionDescriptionInterface* remote_description() const = 0;
488 486
489 // Create a new offer. 487 // Create a new offer.
490 // The CreateSessionDescriptionObserver callback will be called when done. 488 // The CreateSessionDescriptionObserver callback will be called when done.
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
813 cricket::WebRtcVideoEncoderFactory* encoder_factory, 811 cricket::WebRtcVideoEncoderFactory* encoder_factory,
814 cricket::WebRtcVideoDecoderFactory* decoder_factory) { 812 cricket::WebRtcVideoDecoderFactory* decoder_factory) {
815 return CreatePeerConnectionFactory( 813 return CreatePeerConnectionFactory(
816 worker_and_network_thread, worker_and_network_thread, signaling_thread, 814 worker_and_network_thread, worker_and_network_thread, signaling_thread,
817 default_adm, encoder_factory, decoder_factory); 815 default_adm, encoder_factory, decoder_factory);
818 } 816 }
819 817
820 } // namespace webrtc 818 } // namespace webrtc
821 819
822 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_ 820 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698