Move /webrtc/api/android files to /webrtc/sdk/android

Move /webrtc/api/android files to /webrtc/sdk/android

I decided to make one webrtc/sdk/android/BUILD.gn for both tests and Java/jni src.

External dependencies needs to be updated after this CL.

Future work is required to clean up the Android api and move
implementation details to /webrtc/sdk/android/src.

BUG=webrtc:5882, webrtc:6804
NOPRESUBMIT=True

Committed: https://crrev.com/768c64877e8ab88e1864b5017241325f28a3ef34
Cr-Commit-Position: refs/heads/master@{#15443}

[magjed_webrtc, 2016-12-01 13:15:41]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 13:15:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-01 13:22:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 13:22:55]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10928)

[magjed_webrtc, 2016-12-01 13:28:08]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 13:28:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-01 13:34:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 13:34:51]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10931)

[magjed_webrtc, 2016-12-01 13:49:11]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 13:49:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-01 13:55:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 13:55:10]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10935)

[magjed_webrtc, 2016-12-01 14:11:34]

Description was changed from

==========
Move /webrtc/api/android files to /webrtc/sdk/android

BUG=webrtc:5882,webrtc:6804
==========

to

==========
Move /webrtc/api/android files to /webrtc/sdk/android

In order to not break external dependencies, these temporary workarounds
have been made:
 * Re-export libjingle_peerconnection_so, libjingle_peerconnection_jni,
   and libjingle_peerconnection_metrics_default_jni from
   webrtc/api/BUILD.gn.
 * Create a symlink from webrtc/api/android/java/src/org to
   webrtc/sdk/android/src/java/org.

These workarounds are planned to be removed ASAP once external
dependencies are updated.

BUG=webrtc:5882,webrtc:6804
==========

[magjed_webrtc, 2016-12-01 14:13:24]

Description was changed from

==========
Move /webrtc/api/android files to /webrtc/sdk/android

In order to not break external dependencies, these temporary workarounds
have been made:
 * Re-export libjingle_peerconnection_so, libjingle_peerconnection_jni,
   and libjingle_peerconnection_metrics_default_jni from
   webrtc/api/BUILD.gn.
 * Create a symlink from webrtc/api/android/java/src/org to
   webrtc/sdk/android/src/java/org.

These workarounds are planned to be removed ASAP once external
dependencies are updated.

BUG=webrtc:5882,webrtc:6804
==========

to

==========
Move /webrtc/api/android files to /webrtc/sdk/android

In order to not break external dependencies, these temporary workarounds
have been made:
 * Re-export libjingle_peerconnection_so, libjingle_peerconnection_jni,
   and libjingle_peerconnection_metrics_default_jni from
   webrtc/api/BUILD.gn.
 * Create a symlink from webrtc/api/android/java/src/org to
   webrtc/sdk/android/src/java/org.

These workarounds are planned to be removed ASAP once external
dependencies are updated.

The PRESUBMIT is failing because cpplint.py fails on the moved jni
files. I don't want to include unrelated changes in this CL, so I will
ignore PRESUBMIT before submitting.

BUG=webrtc:5882,webrtc:6804
==========

[magjed_webrtc, 2016-12-01 14:28:21]

Description was changed from

==========
Move /webrtc/api/android files to /webrtc/sdk/android

In order to not break external dependencies, these temporary workarounds
have been made:
 * Re-export libjingle_peerconnection_so, libjingle_peerconnection_jni,
   and libjingle_peerconnection_metrics_default_jni from
   webrtc/api/BUILD.gn.
 * Create a symlink from webrtc/api/android/java/src/org to
   webrtc/sdk/android/src/java/org.

These workarounds are planned to be removed ASAP once external
dependencies are updated.

The PRESUBMIT is failing because cpplint.py fails on the moved jni
files. I don't want to include unrelated changes in this CL, so I will
ignore PRESUBMIT before submitting.

BUG=webrtc:5882,webrtc:6804
==========

to

==========
Move /webrtc/api/android files to /webrtc/sdk/android

In order to not break external dependencies, these temporary workarounds
have been made:
 * Re-export libjingle_peerconnection_so, libjingle_peerconnection_jni,
   and libjingle_peerconnection_metrics_default_jni from
   webrtc/api/BUILD.gn.
 * Create a symlink from webrtc/api/android/java/src/org to
   webrtc/sdk/android/src/java/org.

These workarounds are planned to be removed ASAP once external
dependencies are updated.

The PRESUBMIT is failing because cpplint.py fails on the moved jni
files. I don't want to include unrelated changes in this CL, so I will
ignore PRESUBMIT before submitting.

Future work is required to create a /webrtc/sdk/android/api folder and
move files from /webrtc/sdk/android/src there.

BUG=webrtc:5882,webrtc:6804
==========

[magjed_webrtc, 2016-12-01 15:11:46]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 15:11:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-01 15:18:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 15:18:27]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10942)

[magjed_webrtc, 2016-12-01 16:02:23]

Description was changed from

==========
Move /webrtc/api/android files to /webrtc/sdk/android

In order to not break external dependencies, these temporary workarounds
have been made:
 * Re-export libjingle_peerconnection_so, libjingle_peerconnection_jni,
   and libjingle_peerconnection_metrics_default_jni from
   webrtc/api/BUILD.gn.
 * Create a symlink from webrtc/api/android/java/src/org to
   webrtc/sdk/android/src/java/org.

These workarounds are planned to be removed ASAP once external
dependencies are updated.

The PRESUBMIT is failing because cpplint.py fails on the moved jni
files. I don't want to include unrelated changes in this CL, so I will
ignore PRESUBMIT before submitting.

Future work is required to create a /webrtc/sdk/android/api folder and
move files from /webrtc/sdk/android/src there.

BUG=webrtc:5882,webrtc:6804
==========

to

==========
Move /webrtc/api/android files to /webrtc/sdk/android

In order to not break external dependencies, these temporary workarounds
have been made:
 * Re-export libjingle_peerconnection_so, libjingle_peerconnection_jni,
   and libjingle_peerconnection_metrics_default_jni from
   webrtc/api/BUILD.gn.
 * Create a symlink from webrtc/api/android/java/src/org to
   webrtc/sdk/android/src/java/org.

These workarounds are planned to be removed ASAP once external
dependencies are updated.

The PRESUBMIT is failing because cpplint.py fails on the moved jni
files. I don't want to include unrelated changes in this CL, so I will
ignore PRESUBMIT before submitting.

Future work is required to create a /webrtc/sdk/android/api folder and
move files from /webrtc/sdk/android/src there.

BUG=webrtc:5882,webrtc:6804
NOPRESUBMIT=True
==========

[magjed_webrtc, 2016-12-02 11:56:15]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 11:56:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-02 12:01:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 12:01:13]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
  android_clang_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/build...)
  android_compile_mips_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_mips_db...)
  android_compile_x86_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_rel...)
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/19180)

[magjed_webrtc, 2016-12-02 12:48:35]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 12:48:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-02 12:51:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 12:51:15]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
  android_compile_x86_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/19183)

[magjed_webrtc, 2016-12-02 12:53:17]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 12:53:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2016-12-02 12:55:11]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 12:55:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-02 13:06:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 13:06:34]

Dry run: Try jobs failed on following builders:
  android_compile_mips_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_mips_db...)

[magjed_webrtc, 2016-12-02 13:31:34]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 13:31:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2016-12-02 13:51:41]

Patchset #7 (id:120001) has been deleted

[magjed_webrtc, 2016-12-02 13:51:52]

Patchset #6 (id:100001) has been deleted

[magjed_webrtc, 2016-12-02 13:52:09]

Patchset #6 (id:140001) has been deleted

[magjed_webrtc, 2016-12-02 13:52:23]

Patchset #5 (id:80001) has been deleted

[magjed_webrtc, 2016-12-02 13:52:37]

Patchset #4 (id:60001) has been deleted

[magjed_webrtc, 2016-12-02 13:52:52]

Patchset #3 (id:40001) has been deleted

[magjed_webrtc, 2016-12-02 13:53:10]

Patchset #2 (id:20001) has been deleted

[magjed_webrtc, 2016-12-02 13:53:26]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-12-02 13:54:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 13:54:08]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2016-12-02 13:54:19]

Description was changed from

==========
Move /webrtc/api/android files to /webrtc/sdk/android

In order to not break external dependencies, these temporary workarounds
have been made:
 * Re-export libjingle_peerconnection_so, libjingle_peerconnection_jni,
   and libjingle_peerconnection_metrics_default_jni from
   webrtc/api/BUILD.gn.
 * Create a symlink from webrtc/api/android/java/src/org to
   webrtc/sdk/android/src/java/org.

These workarounds are planned to be removed ASAP once external
dependencies are updated.

The PRESUBMIT is failing because cpplint.py fails on the moved jni
files. I don't want to include unrelated changes in this CL, so I will
ignore PRESUBMIT before submitting.

Future work is required to create a /webrtc/sdk/android/api folder and
move files from /webrtc/sdk/android/src there.

BUG=webrtc:5882,webrtc:6804
NOPRESUBMIT=True
==========

to

==========
Move /webrtc/api/android files to /webrtc/sdk/android

External dependencies needs to be updated after this CL.

Future work is required to create a /webrtc/sdk/android/api folder and
move files from /webrtc/sdk/android/src there.

BUG=webrtc:5882,webrtc:6804
NOPRESUBMIT=True
==========

[magjed_webrtc, 2016-12-02 13:54:20]

magjed@webrtc.org changed reviewers:
+ kjellander@webrtc.org, sakal@webrtc.org

[magjed_webrtc, 2016-12-02 13:55:20]

Description was changed from

==========
Move /webrtc/api/android files to /webrtc/sdk/android

External dependencies needs to be updated after this CL.

Future work is required to create a /webrtc/sdk/android/api folder and
move files from /webrtc/sdk/android/src there.

BUG=webrtc:5882,webrtc:6804
NOPRESUBMIT=True
==========

to

==========
Move /webrtc/api/android files to /webrtc/sdk/android

I decided to make one webrtc/sdk/android/BUILD.gn for both tests and Java/jni
src.

External dependencies needs to be updated after this CL.

Future work is required to create a /webrtc/sdk/android/api folder and
move files from /webrtc/sdk/android/src there.

BUG=webrtc:5882,webrtc:6804
NOPRESUBMIT=True
==========

[magjed_webrtc, 2016-12-02 14:05:20]

Description was changed from

==========
Move /webrtc/api/android files to /webrtc/sdk/android

I decided to make one webrtc/sdk/android/BUILD.gn for both tests and Java/jni
src.

External dependencies needs to be updated after this CL.

Future work is required to create a /webrtc/sdk/android/api folder and
move files from /webrtc/sdk/android/src there.

BUG=webrtc:5882,webrtc:6804
NOPRESUBMIT=True
==========

to

==========
Move /webrtc/api/android files to /webrtc/sdk/android

I decided to make one webrtc/sdk/android/BUILD.gn for both tests and Java/jni
src.

External dependencies needs to be updated after this CL.

Future work is required to create a /webrtc/sdk/android/api folder and
move proper API files from /webrtc/sdk/android/src there.

BUG=webrtc:5882,webrtc:6804
NOPRESUBMIT=True
==========

[magjed_webrtc, 2016-12-02 14:06:01]

Please take a look.

[kjellander_webrtc, 2016-12-02 14:16:45]

lgtm but run chromium and internal trybots

[sakal, 2016-12-05 11:51:59]

https://codereview.webrtc.org/2547483003/diff/180001/webrtc/sdk/android/BUILD.gn
File webrtc/sdk/android/BUILD.gn (right):

https://codereview.webrtc.org/2547483003/diff/180001/webrtc/sdk/android/BUILD...
webrtc/sdk/android/BUILD.gn:13: group("android") {
I don't think this group makes sense right now. It is not used right? In the
future, it might be a target for a jar file that has both the Java and JNI.

[magjed_webrtc, 2016-12-05 13:55:23]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 13:55:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2016-12-05 13:56:53]

> lgtm but run chromium and internal trybots
The internal trybot will go red (it requires external updates) and I can't try
the chromium bots because of patch failures when you are moving or removing
files (https://bugs.chromium.org/p/chromium/issues/detail?id=666669).

https://codereview.webrtc.org/2547483003/diff/180001/webrtc/sdk/android/BUILD.gn
File webrtc/sdk/android/BUILD.gn (right):

https://codereview.webrtc.org/2547483003/diff/180001/webrtc/sdk/android/BUILD...
webrtc/sdk/android/BUILD.gn:13: group("android") {
On 2016/12/05 11:51:58, sakal wrote:
> I don't think this group makes sense right now. It is not used right? In the
> future, it might be a target for a jar file that has both the Java and JNI.

Done.

[kjellander_webrtc, 2016-12-05 14:11:26]

On 2016/12/05 13:56:53, magjed_webrtc wrote:
> > lgtm but run chromium and internal trybots
> The internal trybot will go red (it requires external updates) and I can't try
> the chromium bots because of patch failures when you are moving or removing
> files (https://bugs.chromium.org/p/chromium/issues/detail?id=666669).

You could make a patch set where you don't remove the files and try. But I'll
try to get to fix that bug this week!

> 
>
https://codereview.webrtc.org/2547483003/diff/180001/webrtc/sdk/android/BUILD.gn
> File webrtc/sdk/android/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2547483003/diff/180001/webrtc/sdk/android/BUILD...
> webrtc/sdk/android/BUILD.gn:13: group("android") {
> On 2016/12/05 11:51:58, sakal wrote:
> > I don't think this group makes sense right now. It is not used right? In the
> > future, it might be a target for a jar file that has both the Java and JNI.
> 
> Done.

[commit-bot: I haz the power, 2016-12-05 14:19:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 14:19:29]

Dry run: This issue passed the CQ dry run.

[sakal, 2016-12-05 14:50:18]

lgtm

[magjed_webrtc, 2016-12-06 12:07:27]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 12:07:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2016-12-06 12:18:47]

Description was changed from

==========
Move /webrtc/api/android files to /webrtc/sdk/android

I decided to make one webrtc/sdk/android/BUILD.gn for both tests and Java/jni
src.

External dependencies needs to be updated after this CL.

Future work is required to create a /webrtc/sdk/android/api folder and
move proper API files from /webrtc/sdk/android/src there.

BUG=webrtc:5882,webrtc:6804
NOPRESUBMIT=True
==========

to

==========
Move /webrtc/api/android files to /webrtc/sdk/android

I decided to make one webrtc/sdk/android/BUILD.gn for both tests and Java/jni
src.

External dependencies needs to be updated after this CL.

Future work is required to clean up the Android api and move
implementation details to /webrtc/sdk/android/src.

BUG=webrtc:5882,webrtc:6804
NOPRESUBMIT=True
==========

[commit-bot: I haz the power, 2016-12-06 12:26:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 12:26:44]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2016-12-06 12:28:37]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2016-12-06 12:28:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org, sakal@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2547483003/#ps220001 (title:
"Move to api folder under Android instead of src")

[commit-bot: I haz the power, 2016-12-06 12:28:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-06 12:29:39]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1481027317042120,
"parent_rev": "f8df79cf677093b82b2c4830e4fcc4f8fc3840f6", "commit_rev":
"533e2b2b84a698ad50f85b811ea59df278bea4f1"}

[commit-bot: I haz the power, 2016-12-06 12:29:42]

Description was changed from

==========
Move /webrtc/api/android files to /webrtc/sdk/android

I decided to make one webrtc/sdk/android/BUILD.gn for both tests and Java/jni
src.

External dependencies needs to be updated after this CL.

Future work is required to clean up the Android api and move
implementation details to /webrtc/sdk/android/src.

BUG=webrtc:5882,webrtc:6804
NOPRESUBMIT=True
==========

to

==========
Move /webrtc/api/android files to /webrtc/sdk/android

I decided to make one webrtc/sdk/android/BUILD.gn for both tests and Java/jni
src.

External dependencies needs to be updated after this CL.

Future work is required to clean up the Android api and move
implementation details to /webrtc/sdk/android/src.

BUG=webrtc:5882,webrtc:6804
NOPRESUBMIT=True
==========

[commit-bot: I haz the power, 2016-12-06 12:29:45]

Committed patchset #4 (id:220001)

[commit-bot: I haz the power, 2016-12-06 12:29:54]

Description was changed from

==========
Move /webrtc/api/android files to /webrtc/sdk/android

I decided to make one webrtc/sdk/android/BUILD.gn for both tests and Java/jni
src.

External dependencies needs to be updated after this CL.

Future work is required to clean up the Android api and move
implementation details to /webrtc/sdk/android/src.

BUG=webrtc:5882,webrtc:6804
NOPRESUBMIT=True
==========

to

==========
Move /webrtc/api/android files to /webrtc/sdk/android

I decided to make one webrtc/sdk/android/BUILD.gn for both tests and Java/jni
src.

External dependencies needs to be updated after this CL.

Future work is required to clean up the Android api and move
implementation details to /webrtc/sdk/android/src.

BUG=webrtc:5882,webrtc:6804
NOPRESUBMIT=True

Committed: https://crrev.com/768c64877e8ab88e1864b5017241325f28a3ef34
Cr-Commit-Position: refs/heads/master@{#15443}
==========

[commit-bot: I haz the power, 2016-12-06 12:29:56]

Patchset 4 (id:??) landed as
https://crrev.com/768c64877e8ab88e1864b5017241325f28a3ef34
Cr-Commit-Position: refs/heads/master@{#15443}