Use RotateDesktopFrame in DirectX capturer

Use RotateDesktopFrame in DirectX capturer

To support rotation in DirectX capturer, several other changes are also
required.
1. Removing AddRect in RotateDesktopFrame, this is a performance improvement.
DxgiOutputDuplicator creates a rotated DesktopRegion, which can be directly
add to updated_region.
2. DxgiOutputDuplicator::SourceRect() is not accurate, the rectangle in source
is controlled by |offset| or |rotation_| + |offset|, instead of desktop_rect().
3. The |region| in DxgiTexture::CopyFrom() is not accurate. It needs an
unrotated DesktopRegion which offsets by |offset| instead of desktop_rect(). To
avoid generating both rotated and unrotated updated_region, this parameter has
been removed. This impacts DxgiTextureStagning performance a little bit (1.5ms).
Refer to bug for details.

BUG=webrtc:6646
Committed: https://crrev.com/e61fbfffda8d09080c964489b8ebed80e9d1cb29
Cr-Commit-Position: refs/heads/master@{#15308}

[Hzj_jie, 2016-11-28 01:25:12]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 01:25:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[Hzj_jie, 2016-11-28 01:26:16]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[Hzj_jie, 2016-11-28 01:26:19]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-11-28 01:26:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-28 01:34:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 01:34:10]

Dry run: Try jobs failed on following builders:
  win_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/3563)

[Hzj_jie, 2016-11-28 02:07:56]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 02:08:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[Hzj_jie, 2016-11-28 02:10:19]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-11-28 02:22:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 02:22:57]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2016-11-28 02:29:01]

Description was changed from

==========
Use RotateDesktopFrame in DirectX capturer

BUG=webrtc:6646
==========

to

==========
Use RotateDesktopFrame in DirectX capturer

To support rotation in DirectX capturer, several other changes are also
required.
1. Removing AddRect in RotateDesktopFrame, this is a performance improvement.
DxgiOutputDuplicator creates a rotated DesktopRegion, which can be directly
append to updated_region.
2. DxgiOutputDuplicator::SourceRect() is not accurate, the rectangle in source
is controlled by |offset| or |rotation_| + |offset|, instead of desktop_rect().
3. The |region| in DxgiTexture::CopyFrom() is not accurate. It needs an
unrotated DesktopRegion which offsets by |offset| instead of desktop_rect(). To
avoid generating both rotated and unrotated updated_region, this parameter has
been removed. This impacts DxgiTextureStagning performance a little bit (1.5ms).
Refer to bug for details. But considering generating a DesktopRegion also costs
some time (according to DesktopRegionTest.DISABLED_Performance, it takes ~1ms to
finish one round.), and Windows tends to return a larger updated area, I do not
think the optimization in DxgiTextureStaging can still provide a significant
benefit (less than 1ms AFAICT, but significantly increase the code complexity).
If we do prefer this optimization, I would start from a RotateDesktopRegion()
function.

BUG=webrtc:6646
==========

[Hzj_jie, 2016-11-28 02:29:01]

zijiehe@chromium.org changed reviewers:
+ jamiewalch@chromium.org, sergeyu@chromium.org

[Hzj_jie, 2016-11-28 02:29:57]

Description was changed from

==========
Use RotateDesktopFrame in DirectX capturer

To support rotation in DirectX capturer, several other changes are also
required.
1. Removing AddRect in RotateDesktopFrame, this is a performance improvement.
DxgiOutputDuplicator creates a rotated DesktopRegion, which can be directly
append to updated_region.
2. DxgiOutputDuplicator::SourceRect() is not accurate, the rectangle in source
is controlled by |offset| or |rotation_| + |offset|, instead of desktop_rect().
3. The |region| in DxgiTexture::CopyFrom() is not accurate. It needs an
unrotated DesktopRegion which offsets by |offset| instead of desktop_rect(). To
avoid generating both rotated and unrotated updated_region, this parameter has
been removed. This impacts DxgiTextureStagning performance a little bit (1.5ms).
Refer to bug for details. But considering generating a DesktopRegion also costs
some time (according to DesktopRegionTest.DISABLED_Performance, it takes ~1ms to
finish one round.), and Windows tends to return a larger updated area, I do not
think the optimization in DxgiTextureStaging can still provide a significant
benefit (less than 1ms AFAICT, but significantly increase the code complexity).
If we do prefer this optimization, I would start from a RotateDesktopRegion()
function.

BUG=webrtc:6646
==========

to

==========
Use RotateDesktopFrame in DirectX capturer

To support rotation in DirectX capturer, several other changes are also
required.
1. Removing AddRect in RotateDesktopFrame, this is a performance improvement.
DxgiOutputDuplicator creates a rotated DesktopRegion, which can be directly
add to updated_region.
2. DxgiOutputDuplicator::SourceRect() is not accurate, the rectangle in source
is controlled by |offset| or |rotation_| + |offset|, instead of desktop_rect().
3. The |region| in DxgiTexture::CopyFrom() is not accurate. It needs an
unrotated DesktopRegion which offsets by |offset| instead of desktop_rect(). To
avoid generating both rotated and unrotated updated_region, this parameter has
been removed. This impacts DxgiTextureStagning performance a little bit (1.5ms).
Refer to bug for details. But considering generating a DesktopRegion also costs
some time (according to DesktopRegionTest.DISABLED_Performance, it takes ~1ms to
finish one round.), and Windows tends to return a larger updated area, I do not
think the optimization in DxgiTextureStaging can still provide a significant
benefit (less than 1ms AFAICT, but significantly increase the code complexity).
If we do prefer this optimization, I would start from a RotateDesktopRegion()
function.

BUG=webrtc:6646
==========

[Hzj_jie, 2016-11-28 02:36:01]

Description was changed from

==========
Use RotateDesktopFrame in DirectX capturer

To support rotation in DirectX capturer, several other changes are also
required.
1. Removing AddRect in RotateDesktopFrame, this is a performance improvement.
DxgiOutputDuplicator creates a rotated DesktopRegion, which can be directly
add to updated_region.
2. DxgiOutputDuplicator::SourceRect() is not accurate, the rectangle in source
is controlled by |offset| or |rotation_| + |offset|, instead of desktop_rect().
3. The |region| in DxgiTexture::CopyFrom() is not accurate. It needs an
unrotated DesktopRegion which offsets by |offset| instead of desktop_rect(). To
avoid generating both rotated and unrotated updated_region, this parameter has
been removed. This impacts DxgiTextureStagning performance a little bit (1.5ms).
Refer to bug for details. But considering generating a DesktopRegion also costs
some time (according to DesktopRegionTest.DISABLED_Performance, it takes ~1ms to
finish one round.), and Windows tends to return a larger updated area, I do not
think the optimization in DxgiTextureStaging can still provide a significant
benefit (less than 1ms AFAICT, but significantly increase the code complexity).
If we do prefer this optimization, I would start from a RotateDesktopRegion()
function.

BUG=webrtc:6646
==========

to

==========
Use RotateDesktopFrame in DirectX capturer

To support rotation in DirectX capturer, several other changes are also
required.
1. Removing AddRect in RotateDesktopFrame, this is a performance improvement.
DxgiOutputDuplicator creates a rotated DesktopRegion, which can be directly
add to updated_region.
2. DxgiOutputDuplicator::SourceRect() is not accurate, the rectangle in source
is controlled by |offset| or |rotation_| + |offset|, instead of desktop_rect().
3. The |region| in DxgiTexture::CopyFrom() is not accurate. It needs an
unrotated DesktopRegion which offsets by |offset| instead of desktop_rect(). To
avoid generating both rotated and unrotated updated_region, this parameter has
been removed. This impacts DxgiTextureStagning performance a little bit (1.5ms).
Refer to bug for details.

BUG=webrtc:6646
==========

[Sergey Ulanov, 2016-11-28 23:12:35]

lgtm

https://codereview.webrtc.org/2530303002/diff/40001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/win/dxgi_output_duplicator.cc (right):

https://codereview.webrtc.org/2530303002/diff/40001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/win/dxgi_output_duplicator.cc:40: Rotation
DXGI_MODE_ROTATIONToRotation(DXGI_MODE_ROTATION rotation) {
Call it DxgiRotationToRotation()?

https://codereview.webrtc.org/2530303002/diff/40001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/win/dxgi_output_duplicator.cc:59:
rect.Translate(-offset.x(), -offset.y());
nit: This could be expressed Translate(DesktopVector().subtract(offset)), and
then this function won't be needed. But feel free to keep it if you think it's
more readable this way.

https://codereview.webrtc.org/2530303002/diff/40001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/win/dxgi_output_duplicator.cc:199: source_rect,
"git cl format" please. It will put multiple args per line.

https://codereview.webrtc.org/2530303002/diff/40001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h (right):

https://codereview.webrtc.org/2530303002/diff/40001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h:117: Rotation
reverse_rotation_;
nit: This is a trivial function of rotation_. I don't think it's necessary to
store it here. Instead just call ReverseRotation(rotation_) whenever it's
needed.

[Hzj_jie, 2016-11-29 00:23:47]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 00:23:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-29 00:46:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 00:46:46]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2016-11-29 01:21:39]

https://codereview.webrtc.org/2530303002/diff/40001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/win/dxgi_output_duplicator.cc (right):

https://codereview.webrtc.org/2530303002/diff/40001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/win/dxgi_output_duplicator.cc:40: Rotation
DXGI_MODE_ROTATIONToRotation(DXGI_MODE_ROTATION rotation) {
On 2016/11/28 23:12:35, Sergey Ulanov wrote:
> Call it DxgiRotationToRotation()?

Done.

https://codereview.webrtc.org/2530303002/diff/40001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/win/dxgi_output_duplicator.cc:59:
rect.Translate(-offset.x(), -offset.y());
On 2016/11/28 23:12:35, Sergey Ulanov wrote:
> nit: This could be expressed Translate(DesktopVector().subtract(offset)), and
> then this function won't be needed. But feel free to keep it if you think it's
> more readable this way.

Acknowledged.

https://codereview.webrtc.org/2530303002/diff/40001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/win/dxgi_output_duplicator.cc:199: source_rect,
On 2016/11/28 23:12:35, Sergey Ulanov wrote:
> "git cl format" please. It will put multiple args per line.

Done.

https://codereview.webrtc.org/2530303002/diff/40001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h (right):

https://codereview.webrtc.org/2530303002/diff/40001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h:117: Rotation
reverse_rotation_;
On 2016/11/28 23:12:35, Sergey Ulanov wrote:
> nit: This is a trivial function of rotation_. I don't think it's necessary to
> store it here. Instead just call ReverseRotation(rotation_) whenever it's
> needed.

Done.

[Hzj_jie, 2016-11-29 22:48:00]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 22:48:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-29 22:49:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 22:49:42]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2016-11-29 23:14:30]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 23:14:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-29 23:29:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 23:29:06]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2016-11-30 00:08:10]

The CQ bit was checked by zijiehe@chromium.org

[Hzj_jie, 2016-11-30 00:08:10]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.webrtc.org/2530303002/#ps80001 (title:
"Sync latest changes")

[commit-bot: I haz the power, 2016-11-30 00:08:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-30 00:09:51]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480464490277470,
"parent_rev": "ab9d30b35420ff8ca911ed4c049f4e4db6231f83", "commit_rev":
"97ce234e92b3a8ecf118aa03f824a3d49ab0accf"}

[commit-bot: I haz the power, 2016-11-30 00:09:55]

Description was changed from

==========
Use RotateDesktopFrame in DirectX capturer

To support rotation in DirectX capturer, several other changes are also
required.
1. Removing AddRect in RotateDesktopFrame, this is a performance improvement.
DxgiOutputDuplicator creates a rotated DesktopRegion, which can be directly
add to updated_region.
2. DxgiOutputDuplicator::SourceRect() is not accurate, the rectangle in source
is controlled by |offset| or |rotation_| + |offset|, instead of desktop_rect().
3. The |region| in DxgiTexture::CopyFrom() is not accurate. It needs an
unrotated DesktopRegion which offsets by |offset| instead of desktop_rect(). To
avoid generating both rotated and unrotated updated_region, this parameter has
been removed. This impacts DxgiTextureStagning performance a little bit (1.5ms).
Refer to bug for details.

BUG=webrtc:6646
==========

to

==========
Use RotateDesktopFrame in DirectX capturer

To support rotation in DirectX capturer, several other changes are also
required.
1. Removing AddRect in RotateDesktopFrame, this is a performance improvement.
DxgiOutputDuplicator creates a rotated DesktopRegion, which can be directly
add to updated_region.
2. DxgiOutputDuplicator::SourceRect() is not accurate, the rectangle in source
is controlled by |offset| or |rotation_| + |offset|, instead of desktop_rect().
3. The |region| in DxgiTexture::CopyFrom() is not accurate. It needs an
unrotated DesktopRegion which offsets by |offset| instead of desktop_rect(). To
avoid generating both rotated and unrotated updated_region, this parameter has
been removed. This impacts DxgiTextureStagning performance a little bit (1.5ms).
Refer to bug for details.

BUG=webrtc:6646
==========

[commit-bot: I haz the power, 2016-11-30 00:09:56]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-11-30 00:10:02]

Description was changed from

==========
Use RotateDesktopFrame in DirectX capturer

To support rotation in DirectX capturer, several other changes are also
required.
1. Removing AddRect in RotateDesktopFrame, this is a performance improvement.
DxgiOutputDuplicator creates a rotated DesktopRegion, which can be directly
add to updated_region.
2. DxgiOutputDuplicator::SourceRect() is not accurate, the rectangle in source
is controlled by |offset| or |rotation_| + |offset|, instead of desktop_rect().
3. The |region| in DxgiTexture::CopyFrom() is not accurate. It needs an
unrotated DesktopRegion which offsets by |offset| instead of desktop_rect(). To
avoid generating both rotated and unrotated updated_region, this parameter has
been removed. This impacts DxgiTextureStagning performance a little bit (1.5ms).
Refer to bug for details.

BUG=webrtc:6646
==========

to

==========
Use RotateDesktopFrame in DirectX capturer

To support rotation in DirectX capturer, several other changes are also
required.
1. Removing AddRect in RotateDesktopFrame, this is a performance improvement.
DxgiOutputDuplicator creates a rotated DesktopRegion, which can be directly
add to updated_region.
2. DxgiOutputDuplicator::SourceRect() is not accurate, the rectangle in source
is controlled by |offset| or |rotation_| + |offset|, instead of desktop_rect().
3. The |region| in DxgiTexture::CopyFrom() is not accurate. It needs an
unrotated DesktopRegion which offsets by |offset| instead of desktop_rect(). To
avoid generating both rotated and unrotated updated_region, this parameter has
been removed. This impacts DxgiTextureStagning performance a little bit (1.5ms).
Refer to bug for details.

BUG=webrtc:6646

Committed: https://crrev.com/e61fbfffda8d09080c964489b8ebed80e9d1cb29
Cr-Commit-Position: refs/heads/master@{#15308}
==========

[commit-bot: I haz the power, 2016-11-30 00:10:03]

Patchset 3 (id:??) landed as
https://crrev.com/e61fbfffda8d09080c964489b8ebed80e9d1cb29
Cr-Commit-Position: refs/heads/master@{#15308}