Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2489843002: Revert of Extract bitrate allocation of spatial/temporal layers out of codec impl. (Closed)

Created:
4 years, 1 month ago by sprang_webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Extract bitrate allocation of spatial/temporal layers out of codec impl. (patchset #17 id:320001 of https://codereview.webrtc.org/2434073003/ ) Reason for revert: Breaks perf tests. Original issue's description: > Extract bitrate allocation of spatial/temporal layers out of codec impl. > > This CL makes a number of intervowen changes: > > * Add BitrateAllocation struct, that contains a codec independent view > of how the target bitrate is distributed over spatial and temporal > layers. > > * Adds the BitrateAllocator interface, which takes a bitrate and frame > rate and produces a BitrateAllocation. > > * A default (non layered) implementation is added, and > SimulcastRateAllocator is extended to fully handle VP8 allocation. > This includes capturing TemporalLayer instances created by the > encoder. > > * ViEEncoder now owns both the bitrate allocator and the temporal layer > factories for VP8. This allows allocation to happen fully outside of > the encoder implementation. > > This refactoring will make it possible for ViEEncoder to signal the > full picture of target bitrates to the RTCP module. > > BUG=webrtc:6301 > > Committed: https://crrev.com/8f46c679d24a05b3f08e02c6d91ec9637f34e24f > Cr-Commit-Position: refs/heads/master@{#14998} TBR=stefan@webrtc.org,perkj@webrtc.org,mflodman@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6301 Committed: https://crrev.com/4bc98d4e1b5649141c5e53ee775d1b035f52402f Cr-Commit-Position: refs/heads/master@{#15001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+872 lines, -1710 lines) Patch
M webrtc/api/android/jni/androidmediaencoder_jni.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/common_types.h View 4 chunks +1 line, -35 lines 0 comments Download
M webrtc/common_types.cc View 3 chunks +0 lines, -87 lines 0 comments Download
M webrtc/common_video/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_video/common_video.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/common_video/include/video_bitrate_allocator.h View 1 chunk +0 lines, -30 lines 0 comments Download
M webrtc/media/engine/fakewebrtcvideoengine.h View 2 chunks +18 lines, -19 lines 0 comments Download
M webrtc/modules/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 2 chunks +4 lines, -14 lines 0 comments Download
M webrtc/modules/video_coding/codecs/i420/include/i420.h View 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 3 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 12 chunks +23 lines, -40 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/default_temporal_layers.h View 4 chunks +7 lines, -13 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/default_temporal_layers.cc View 8 chunks +20 lines, -70 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/default_temporal_layers_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/realtime_temporal_layers.cc View 7 chunks +30 lines, -64 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h View 4 chunks +13 lines, -12 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc View 4 chunks +42 lines, -55 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc View 4 chunks +10 lines, -29 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc View 6 chunks +62 lines, -58 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc View 13 chunks +18 lines, -32 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h View 24 chunks +133 lines, -45 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/temporal_layers.h View 4 chunks +12 lines, -36 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc View 4 chunks +1 line, -9 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.h View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 8 chunks +106 lines, -84 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 2 chunks +9 lines, -14 lines 0 comments Download
M webrtc/modules/video_coding/generic_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/generic_encoder.cc View 2 chunks +5 lines, -17 lines 0 comments Download
M webrtc/modules/video_coding/include/mock/mock_video_codec_interface.h View 1 chunk +0 lines, -3 lines 0 comments Download
D webrtc/modules/video_coding/include/video_codec_initializer.h View 1 chunk +0 lines, -59 lines 0 comments Download
M webrtc/modules/video_coding/include/video_coding.h View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/modules/video_coding/utility/default_video_bitrate_allocator.h View 1 chunk +0 lines, -33 lines 0 comments Download
D webrtc/modules/video_coding/utility/default_video_bitrate_allocator.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D webrtc/modules/video_coding/utility/default_video_bitrate_allocator_unittest.cc View 1 chunk +0 lines, -80 lines 0 comments Download
M webrtc/modules/video_coding/utility/simulcast_rate_allocator.h View 1 chunk +5 lines, -17 lines 0 comments Download
M webrtc/modules/video_coding/utility/simulcast_rate_allocator.cc View 1 chunk +46 lines, -112 lines 0 comments Download
M webrtc/modules/video_coding/utility/simulcast_rate_allocator_unittest.cc View 13 chunks +36 lines, -55 lines 0 comments Download
M webrtc/modules/video_coding/utility/video_coding_utility.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/video_coding/video_codec_initializer.cc View 1 chunk +0 lines, -229 lines 0 comments Download
M webrtc/modules/video_coding/video_coding.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 2 chunks +2 lines, -10 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.cc View 4 chunks +1 line, -22 lines 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 6 chunks +12 lines, -39 lines 0 comments Download
M webrtc/modules/video_coding/video_sender_unittest.cc View 12 chunks +23 lines, -62 lines 0 comments Download
M webrtc/test/configurable_frame_size_encoder.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/test/configurable_frame_size_encoder.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M webrtc/test/fake_encoder.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/test/fake_encoder.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/video/video_encoder.cc View 3 chunks +8 lines, -14 lines 0 comments Download
M webrtc/video/video_encoder_unittest.cc View 6 chunks +4 lines, -26 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 6 chunks +14 lines, -21 lines 0 comments Download
M webrtc/video/vie_encoder.h View 2 chunks +5 lines, -2 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 7 chunks +155 lines, -20 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M webrtc/video_encoder.h View 4 chunks +4 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sprang_webrtc
Created Revert of Extract bitrate allocation of spatial/temporal layers out of codec impl.
4 years, 1 month ago (2016-11-09 14:14:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2489843002/1
4 years, 1 month ago (2016-11-09 14:14:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 14:14:51 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 14:15:05 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bc98d4e1b5649141c5e53ee775d1b035f52402f
Cr-Commit-Position: refs/heads/master@{#15001}

Powered by Google App Engine
This is Rietveld 408576698