Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: webrtc/modules/video_coding/utility/default_video_bitrate_allocator_unittest.cc

Issue 2489843002: Revert of Extract bitrate allocation of spatial/temporal layers out of codec impl. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/utility/default_video_bitrate_allocator_unittest.cc
diff --git a/webrtc/modules/video_coding/utility/default_video_bitrate_allocator_unittest.cc b/webrtc/modules/video_coding/utility/default_video_bitrate_allocator_unittest.cc
deleted file mode 100644
index df5643353ecb51864cc636a3629f865865409892..0000000000000000000000000000000000000000
--- a/webrtc/modules/video_coding/utility/default_video_bitrate_allocator_unittest.cc
+++ /dev/null
@@ -1,80 +0,0 @@
-/*
- * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
- *
- * Use of this source code is governed by a BSD-style license
- * that can be found in the LICENSE file in the root of the source
- * tree. An additional intellectual property rights grant can be found
- * in the file PATENTS. All contributing project authors may
- * be found in the AUTHORS file in the root of the source tree.
- */
-
-#include <limits>
-#include <memory>
-
-#include "webrtc/modules/video_coding/utility/default_video_bitrate_allocator.h"
-#include "webrtc/test/gtest.h"
-
-namespace webrtc {
-namespace {
-uint32_t kMaxBitrateBps = 1000000;
-uint32_t kMinBitrateBps = 50000;
-uint32_t kMaxFramerate = 30;
-} // namespace
-
-class DefaultVideoBitrateAllocatorTest : public ::testing::Test {
- public:
- DefaultVideoBitrateAllocatorTest() {}
- virtual ~DefaultVideoBitrateAllocatorTest() {}
-
- void SetUp() override {
- codec_.codecType = kVideoCodecVP8;
- codec_.minBitrate = kMinBitrateBps / 1000;
- codec_.maxBitrate = kMaxBitrateBps / 1000;
- codec_.targetBitrate = (kMinBitrateBps + kMaxBitrateBps) / 2000;
- codec_.maxFramerate = kMaxFramerate;
- allocator_.reset(new DefaultVideoBitrateAllocator(codec_));
- }
-
- protected:
- VideoCodec codec_;
- std::unique_ptr<DefaultVideoBitrateAllocator> allocator_;
-};
-
-TEST_F(DefaultVideoBitrateAllocatorTest, ZeroIsOff) {
- BitrateAllocation allocation = allocator_->GetAllocation(0, kMaxFramerate);
- EXPECT_EQ(0u, allocation.get_sum_bps());
-}
-
-TEST_F(DefaultVideoBitrateAllocatorTest, CapsToMin) {
- BitrateAllocation allocation = allocator_->GetAllocation(1, kMaxFramerate);
- EXPECT_EQ(kMinBitrateBps, allocation.get_sum_bps());
-
- allocation = allocator_->GetAllocation(kMinBitrateBps - 1, kMaxFramerate);
- EXPECT_EQ(kMinBitrateBps, allocation.get_sum_bps());
-
- allocation = allocator_->GetAllocation(kMinBitrateBps, kMaxFramerate);
- EXPECT_EQ(kMinBitrateBps, allocation.get_sum_bps());
-}
-
-TEST_F(DefaultVideoBitrateAllocatorTest, CapsToMax) {
- BitrateAllocation allocation =
- allocator_->GetAllocation(kMaxBitrateBps, kMaxFramerate);
- EXPECT_EQ(kMaxBitrateBps, allocation.get_sum_bps());
-
- allocation = allocator_->GetAllocation(kMaxBitrateBps + 1, kMaxFramerate);
- EXPECT_EQ(kMaxBitrateBps, allocation.get_sum_bps());
-
- allocation = allocator_->GetAllocation(std::numeric_limits<uint32_t>::max(),
- kMaxFramerate);
- EXPECT_EQ(kMaxBitrateBps, allocation.get_sum_bps());
-}
-
-TEST_F(DefaultVideoBitrateAllocatorTest, GoodInBetween) {
- BitrateAllocation allocation =
- allocator_->GetAllocation(kMinBitrateBps + 1, kMaxFramerate);
- EXPECT_EQ(kMinBitrateBps + 1, allocation.get_sum_bps());
-
- allocation = allocator_->GetAllocation(kMaxBitrateBps - 1, kMaxFramerate);
- EXPECT_EQ(kMaxBitrateBps - 1, allocation.get_sum_bps());
-}
-} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698