Revert of Extract bitrate allocation of spatial/temporal layers out of codec impl.

webrtc/modules/video_coding/codecs/vp8/default_temporal_layers.cc

 /* Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
 *
 *  Use of this source code is governed by a BSD-style license
 *  that can be found in the LICENSE file in the root of the source
 *  tree. An additional intellectual property rights grant can be found
 *  in the file PATENTS.  All contributing project authors may
 *  be found in the AUTHORS file in the root of the source tree.
 */
 
 #include "webrtc/modules/video_coding/codecs/vp8/default_temporal_layers.h"
 
 #include <assert.h>
 #include <stdlib.h>
 #include <string.h>
 
-#include <algorithm>
-#include <vector>
-
-#include "webrtc/base/checks.h"
 #include "webrtc/modules/include/module_common_types.h"
 #include "webrtc/modules/video_coding/include/video_codec_interface.h"
 #include "webrtc/modules/video_coding/codecs/vp8/include/vp8_common_types.h"
 
 #include "vpx/vpx_encoder.h"
 #include "vpx/vp8cx.h"
 
 namespace webrtc {
 
-DefaultTemporalLayers::DefaultTemporalLayers(int number_of_temporal_layers,
+DefaultTemporalLayers::DefaultTemporalLayers(int numberOfTemporalLayers,
                                              uint8_t initial_tl0_pic_idx)
-    : number_of_temporal_layers_(number_of_temporal_layers),
+    : number_of_temporal_layers_(numberOfTemporalLayers),
       temporal_ids_length_(0),
       temporal_pattern_length_(0),
       tl0_pic_idx_(initial_tl0_pic_idx),
       pattern_idx_(255),
       timestamp_(0),
       last_base_layer_sync_(false) {
-  RTC_CHECK_GE(kMaxTemporalStreams, number_of_temporal_layers);
-  RTC_CHECK_GE(number_of_temporal_layers, 0);
+  assert(kMaxTemporalStreams >= numberOfTemporalLayers);
   memset(temporal_ids_, 0, sizeof(temporal_ids_));
   memset(temporal_pattern_, 0, sizeof(temporal_pattern_));
 }
 
 int DefaultTemporalLayers::CurrentLayerId() const {
   assert(temporal_ids_length_ > 0);
   int index = pattern_idx_ % temporal_ids_length_;
   assert(index >= 0);
   return temporal_ids_[index];
 }
 
-std::vector<uint32_t> DefaultTemporalLayers::OnRatesUpdated(
-    int bitrate_kbps,
-    int max_bitrate_kbps,
-    int framerate) {
-  std::vector<uint32_t> bitrates;
-  const int num_layers = std::max(1, number_of_temporal_layers_);
-  for (int i = 0; i < num_layers; ++i) {
-    float layer_bitrate =
-        bitrate_kbps * kVp8LayerRateAlloction[num_layers - 1][i];
-    bitrates.push_back(static_cast<uint32_t>(layer_bitrate + 0.5));
-  }
-  new_bitrates_kbps_ = rtc::Optional<std::vector<uint32_t>>(bitrates);
-
-  // Allocation table is of aggregates, transform to individual rates.
-  uint32_t sum = 0;
-  for (int i = 0; i < num_layers; ++i) {
-    uint32_t layer_bitrate = bitrates[i];
-    RTC_DCHECK_LE(sum, bitrates[i]);
-    bitrates[i] -= sum;
-    sum = layer_bitrate;
-
-    if (sum >= static_cast<uint32_t>(bitrate_kbps)) {
-      // Sum adds up; any subsequent layers will be 0.
-      bitrates.resize(i + 1);
-      break;
-    }
-  }
-
-  return bitrates;
-}
-
-bool DefaultTemporalLayers::UpdateConfiguration(vpx_codec_enc_cfg_t* cfg) {
-  if (!new_bitrates_kbps_)
-    return false;
-
+bool DefaultTemporalLayers::ConfigureBitrates(int bitrateKbit,
+                                              int max_bitrate_kbit,
+                                              int framerate,
+                                              vpx_codec_enc_cfg_t* cfg) {
   switch (number_of_temporal_layers_) {
     case 0:
-      FALLTHROUGH();
     case 1:
       temporal_ids_length_ = 1;
       temporal_ids_[0] = 0;
       cfg->ts_number_layers = number_of_temporal_layers_;
       cfg->ts_periodicity = temporal_ids_length_;
-      cfg->ts_target_bitrate[0] = (*new_bitrates_kbps_)[0];
+      cfg->ts_target_bitrate[0] = bitrateKbit;
       cfg->ts_rate_decimator[0] = 1;
       memcpy(cfg->ts_layer_id, temporal_ids_,
              sizeof(unsigned int) * temporal_ids_length_);
       temporal_pattern_length_ = 1;
       temporal_pattern_[0] = kTemporalUpdateLastRefAll;
       break;
     case 2:
       temporal_ids_length_ = 2;
       temporal_ids_[0] = 0;
       temporal_ids_[1] = 1;
       cfg->ts_number_layers = number_of_temporal_layers_;
       cfg->ts_periodicity = temporal_ids_length_;
       // Split stream 60% 40%.
       // Bitrate API for VP8 is the agregated bitrate for all lower layers.
-      cfg->ts_target_bitrate[0] = (*new_bitrates_kbps_)[0];
-      cfg->ts_target_bitrate[1] = (*new_bitrates_kbps_)[1];
+      cfg->ts_target_bitrate[0] = bitrateKbit * kVp8LayerRateAlloction[1][0];
+      cfg->ts_target_bitrate[1] = bitrateKbit;
       cfg->ts_rate_decimator[0] = 2;
       cfg->ts_rate_decimator[1] = 1;
       memcpy(cfg->ts_layer_id, temporal_ids_,
              sizeof(unsigned int) * temporal_ids_length_);
       temporal_pattern_length_ = 8;
       temporal_pattern_[0] = kTemporalUpdateLastAndGoldenRefAltRef;
       temporal_pattern_[1] = kTemporalUpdateGoldenWithoutDependencyRefAltRef;
       temporal_pattern_[2] = kTemporalUpdateLastRefAltRef;
       temporal_pattern_[3] = kTemporalUpdateGoldenRefAltRef;
       temporal_pattern_[4] = kTemporalUpdateLastRefAltRef;
       temporal_pattern_[5] = kTemporalUpdateGoldenRefAltRef;
       temporal_pattern_[6] = kTemporalUpdateLastRefAltRef;
       temporal_pattern_[7] = kTemporalUpdateNone;
       break;
     case 3:
       temporal_ids_length_ = 4;
       temporal_ids_[0] = 0;
       temporal_ids_[1] = 2;
       temporal_ids_[2] = 1;
       temporal_ids_[3] = 2;
       cfg->ts_number_layers = number_of_temporal_layers_;
       cfg->ts_periodicity = temporal_ids_length_;
       // Split stream 40% 20% 40%.
       // Bitrate API for VP8 is the agregated bitrate for all lower layers.
-      cfg->ts_target_bitrate[0] = (*new_bitrates_kbps_)[0];
-      cfg->ts_target_bitrate[1] = (*new_bitrates_kbps_)[1];
-      cfg->ts_target_bitrate[2] = (*new_bitrates_kbps_)[2];
+      cfg->ts_target_bitrate[0] = bitrateKbit * kVp8LayerRateAlloction[2][0];
+      cfg->ts_target_bitrate[1] = bitrateKbit * kVp8LayerRateAlloction[2][1];
+      cfg->ts_target_bitrate[2] = bitrateKbit;
       cfg->ts_rate_decimator[0] = 4;
       cfg->ts_rate_decimator[1] = 2;
       cfg->ts_rate_decimator[2] = 1;
       memcpy(cfg->ts_layer_id, temporal_ids_,
              sizeof(unsigned int) * temporal_ids_length_);
       temporal_pattern_length_ = 8;
       temporal_pattern_[0] = kTemporalUpdateLastAndGoldenRefAltRef;
       temporal_pattern_[1] = kTemporalUpdateNoneNoRefGoldenRefAltRef;
       temporal_pattern_[2] = kTemporalUpdateGoldenWithoutDependencyRefAltRef;
       temporal_pattern_[3] = kTemporalUpdateNone;
       temporal_pattern_[4] = kTemporalUpdateLastRefAltRef;
       temporal_pattern_[5] = kTemporalUpdateNone;
       temporal_pattern_[6] = kTemporalUpdateGoldenRefAltRef;
       temporal_pattern_[7] = kTemporalUpdateNone;
       break;
     case 4:
       temporal_ids_length_ = 8;
       temporal_ids_[0] = 0;
       temporal_ids_[1] = 3;
       temporal_ids_[2] = 2;
       temporal_ids_[3] = 3;
       temporal_ids_[4] = 1;
       temporal_ids_[5] = 3;
       temporal_ids_[6] = 2;
       temporal_ids_[7] = 3;
       // Split stream 25% 15% 20% 40%.
       // Bitrate API for VP8 is the agregated bitrate for all lower layers.
       cfg->ts_number_layers = 4;
       cfg->ts_periodicity = temporal_ids_length_;
-      cfg->ts_target_bitrate[0] = (*new_bitrates_kbps_)[0];
-      cfg->ts_target_bitrate[1] = (*new_bitrates_kbps_)[1];
-      cfg->ts_target_bitrate[2] = (*new_bitrates_kbps_)[2];
-      cfg->ts_target_bitrate[3] = (*new_bitrates_kbps_)[3];
+      cfg->ts_target_bitrate[0] = bitrateKbit * kVp8LayerRateAlloction[3][0];
+      cfg->ts_target_bitrate[1] = bitrateKbit * kVp8LayerRateAlloction[3][1];
+      cfg->ts_target_bitrate[2] = bitrateKbit * kVp8LayerRateAlloction[3][2];
+      cfg->ts_target_bitrate[3] = bitrateKbit;
       cfg->ts_rate_decimator[0] = 8;
       cfg->ts_rate_decimator[1] = 4;
       cfg->ts_rate_decimator[2] = 2;
       cfg->ts_rate_decimator[3] = 1;
       memcpy(cfg->ts_layer_id, temporal_ids_,
              sizeof(unsigned int) * temporal_ids_length_);
       temporal_pattern_length_ = 16;
       temporal_pattern_[0] = kTemporalUpdateLast;
       temporal_pattern_[1] = kTemporalUpdateNone;
       temporal_pattern_[2] = kTemporalUpdateAltrefWithoutDependency;
       temporal_pattern_[3] = kTemporalUpdateNone;
       temporal_pattern_[4] = kTemporalUpdateGoldenWithoutDependency;
       temporal_pattern_[5] = kTemporalUpdateNone;
       temporal_pattern_[6] = kTemporalUpdateAltref;
       temporal_pattern_[7] = kTemporalUpdateNone;
       temporal_pattern_[8] = kTemporalUpdateLast;
       temporal_pattern_[9] = kTemporalUpdateNone;
       temporal_pattern_[10] = kTemporalUpdateAltref;
       temporal_pattern_[11] = kTemporalUpdateNone;
       temporal_pattern_[12] = kTemporalUpdateGolden;
       temporal_pattern_[13] = kTemporalUpdateNone;
       temporal_pattern_[14] = kTemporalUpdateAltref;
       temporal_pattern_[15] = kTemporalUpdateNone;
       break;
     default:
-      RTC_NOTREACHED();
+      assert(false);
       return false;
   }
-
-  new_bitrates_kbps_ = rtc::Optional<std::vector<uint32_t>>();
-
   return true;
 }
 
 int DefaultTemporalLayers::EncodeFlags(uint32_t timestamp) {
   assert(number_of_temporal_layers_ > 0);
   assert(kMaxTemporalPattern >= temporal_pattern_length_);
   assert(0 < temporal_pattern_length_);
   int flags = 0;
   int patternIdx = ++pattern_idx_ % temporal_pattern_length_;
   assert(kMaxTemporalPattern >= patternIdx);
@@ skipping 105 matching lines @@
     if (vp8_info->temporalIdx == 0 && timestamp != timestamp_) {
       timestamp_ = timestamp;
       tl0_pic_idx_++;
     }
     last_base_layer_sync_ = base_layer_sync;
     vp8_info->tl0PicIdx = tl0_pic_idx_;
   }
 }
 
 TemporalLayers* TemporalLayersFactory::Create(
-    int simulcast_id,
     int temporal_layers,
     uint8_t initial_tl0_pic_idx) const {
-  TemporalLayers* tl =
-      new DefaultTemporalLayers(temporal_layers, initial_tl0_pic_idx);
-  if (listener_)
-    listener_->OnTemporalLayersCreated(simulcast_id, tl);
-  return tl;
+  return new DefaultTemporalLayers(temporal_layers, initial_tl0_pic_idx);
 }
-
-void TemporalLayersFactory::SetListener(TemporalLayersListener* listener) {
-  listener_ = listener;
-}
-
 }  // namespace webrtc