Remove newMediaPlaybackUi flag from content/ and Blink.

Remove newMediaPlaybackUi flag from content/ and Blink.

The flag has been enabled by default for a while and makes the code more
complex. We no longer test the old code path which is likely broken at
this point.

A follow-up CL will remove the files that are now obsolete.

BUG=658520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76
Cr-Commit-Position: refs/heads/master@{#427658}

[mlamouri (slow - plz ping), 2016-10-22 13:40:21]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[mlamouri (slow - plz ping), 2016-10-22 13:40:21]

Description was changed from

==========
Remove newMediaPlaybackUi flag from content/ and Blink.

The flag has been enabled by default for a while and makes the code more
complex. We no longer test the old code path which is likely broken at
this point.

A follow-up CL will remove the files that are now obsolete.

BUG=658520
==========

to

==========
Remove newMediaPlaybackUi flag from content/ and Blink.

The flag has been enabled by default for a while and makes the code more
complex. We no longer test the old code path which is likely broken at
this point.

A follow-up CL will remove the files that are now obsolete.

BUG=658520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-10-22 13:40:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 14:16:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 14:16:31]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[mlamouri (slow - plz ping), 2016-10-24 10:28:21]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 10:28:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2016-10-24 10:30:13]

mlamouri@chromium.org changed reviewers:
+ foolip@chromium.org, jochen@chromium.org, liberato@chromium.org

[mlamouri (slow - plz ping), 2016-10-24 10:30:13]

foolip@, PTAL at:
  third_party/WebKit

jochen@, PTAL at:
  content/child/runtime_features.cc
  content/public/common/content_features.cc
  content/public/common/content_features.h

+liberato@ FYI

Thanks :)

[foolip, 2016-10-24 11:31:50]

lgtm % nits

https://codereview.chromium.org/2447503002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp (right):

https://codereview.chromium.org/2447503002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp:48: static const
int mediaSliderThumbTouchWidthNew = 36;  // Touch zone size.
Drop New suffixes here.

https://codereview.chromium.org/2447503002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp:132: static Image*
soundLevel3 = platformResource("mediaplayerSoundLevel3New");
In a follow up, it would be good to rename all of the fooNew to just foo.

https://codereview.chromium.org/2447503002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp:406: Image*
mediaSliderThumb = platformResource("mediaplayerSliderThumbNew");
static here to match other and previous behavior inside getMediaSliderThumb.

https://codereview.chromium.org/2447503002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp:438: static const
Color startColor = Color(0x42, 0x85, 0xf4);
No other Color instances are static. Intentional change?

[mlamouri (slow - plz ping), 2016-10-24 12:37:24]

https://codereview.chromium.org/2447503002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp (right):

https://codereview.chromium.org/2447503002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp:48: static const
int mediaSliderThumbTouchWidthNew = 36;  // Touch zone size.
On 2016/10/24 at 11:31:50, foolip wrote:
> Drop New suffixes here.

Done in the last CLs (with renaming).

https://codereview.chromium.org/2447503002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp:132: static Image*
soundLevel3 = platformResource("mediaplayerSoundLevel3New");
On 2016/10/24 at 11:31:50, foolip wrote:
> In a follow up, it would be good to rename all of the fooNew to just foo.

Ditto.

https://codereview.chromium.org/2447503002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp:406: Image*
mediaSliderThumb = platformResource("mediaplayerSliderThumbNew");
On 2016/10/24 at 11:31:50, foolip wrote:
> static here to match other and previous behavior inside getMediaSliderThumb.

Done.

https://codereview.chromium.org/2447503002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp:438: static const
Color startColor = Color(0x42, 0x85, 0xf4);
On 2016/10/24 at 11:31:50, foolip wrote:
> No other Color instances are static. Intentional change?

Yes. These colour are always the same. The other place where we use Color, the
colour are changing.

Ideally, we should have the Color as static const in the namespace but I
prefered to not have this CL do this.

[mlamouri (slow - plz ping), 2016-10-24 12:40:23]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 12:40:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[liberato (no reviews please), 2016-10-24 14:38:44]

lgtm.  yay! :)

-fl

https://codereview.chromium.org/2447503002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/shadow/MediaControls.cpp (right):

https://codereview.chromium.org/2447503002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/shadow/MediaControls.cpp:500: // If there is
audio, then we want it unless hiding audio is enabled and
s/hiding audio is enabled and//

[commit-bot: I haz the power, 2016-10-24 16:15:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 16:15:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mlamouri (slow - plz ping), 2016-10-24 17:09:27]

https://codereview.chromium.org/2447503002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/shadow/MediaControls.cpp (right):

https://codereview.chromium.org/2447503002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/shadow/MediaControls.cpp:500: // If there is
audio, then we want it unless hiding audio is enabled and
On 2016/10/24 at 14:38:44, liberato wrote:
> s/hiding audio is enabled and//

Done.

[mlamouri (slow - plz ping), 2016-10-24 17:09:40]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 17:10:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 19:13:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 19:13:05]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[mlamouri (slow - plz ping), 2016-10-25 12:26:27]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 12:26:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 14:45:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 14:45:52]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-10-26 08:21:03]

lgtm

[mlamouri (slow - plz ping), 2016-10-26 10:21:36]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-10-26 10:21:36]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org,
liberato@chromium.org
Link to the patchset: https://codereview.chromium.org/2447503002/#ps80001
(title: "fix mistake caught by tests")

[commit-bot: I haz the power, 2016-10-26 10:21:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 10:26:12]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-26 10:28:43]

Description was changed from

==========
Remove newMediaPlaybackUi flag from content/ and Blink.

The flag has been enabled by default for a while and makes the code more
complex. We no longer test the old code path which is likely broken at
this point.

A follow-up CL will remove the files that are now obsolete.

BUG=658520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove newMediaPlaybackUi flag from content/ and Blink.

The flag has been enabled by default for a while and makes the code more
complex. We no longer test the old code path which is likely broken at
this point.

A follow-up CL will remove the files that are now obsolete.

BUG=658520
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76
Cr-Commit-Position: refs/heads/master@{#427658}
==========

[commit-bot: I haz the power, 2016-10-26 10:28:44]

Patchset 5 (id:??) landed as
https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76
Cr-Commit-Position: refs/heads/master@{#427658}