Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: content/child/runtime_features.cc

Issue 2447503002: Remove newMediaPlaybackUi flag from content/ and Blink. (Closed)
Patch Set: fix mistake caught by tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/public/common/content_features.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/runtime_features.h" 5 #include "content/child/runtime_features.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/feature_list.h" 10 #include "base/feature_list.h"
(...skipping 21 matching lines...) Expand all
32 // Android does not yet support SharedWorker. crbug.com/154571 32 // Android does not yet support SharedWorker. crbug.com/154571
33 WebRuntimeFeatures::enableSharedWorker(false); 33 WebRuntimeFeatures::enableSharedWorker(false);
34 // Android does not yet support NavigatorContentUtils. 34 // Android does not yet support NavigatorContentUtils.
35 WebRuntimeFeatures::enableNavigatorContentUtils(false); 35 WebRuntimeFeatures::enableNavigatorContentUtils(false);
36 WebRuntimeFeatures::enableOrientationEvent(true); 36 WebRuntimeFeatures::enableOrientationEvent(true);
37 WebRuntimeFeatures::enableFastMobileScrolling(true); 37 WebRuntimeFeatures::enableFastMobileScrolling(true);
38 WebRuntimeFeatures::enableMediaCapture(true); 38 WebRuntimeFeatures::enableMediaCapture(true);
39 // Android won't be able to reliably support non-persistent notifications, the 39 // Android won't be able to reliably support non-persistent notifications, the
40 // intended behavior for which is in flux by itself. 40 // intended behavior for which is in flux by itself.
41 WebRuntimeFeatures::enableNotificationConstructor(false); 41 WebRuntimeFeatures::enableNotificationConstructor(false);
42 WebRuntimeFeatures::enableNewMediaPlaybackUi(true);
43 // Android does not yet support switching of audio output devices 42 // Android does not yet support switching of audio output devices
44 WebRuntimeFeatures::enableAudioOutputDevices(false); 43 WebRuntimeFeatures::enableAudioOutputDevices(false);
45 #else 44 #else
46 WebRuntimeFeatures::enableNavigatorContentUtils(true); 45 WebRuntimeFeatures::enableNavigatorContentUtils(true);
47 #endif // defined(OS_ANDROID) 46 #endif // defined(OS_ANDROID)
48 47
49 #if defined(OS_ANDROID) || defined(USE_AURA) 48 #if defined(OS_ANDROID) || defined(USE_AURA)
50 WebRuntimeFeatures::enableCompositedSelectionUpdate(true); 49 WebRuntimeFeatures::enableCompositedSelectionUpdate(true);
51 #endif 50 #endif
52 51
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 if (command_line.HasSwitch(switches::kEnableWebFontsInterventionTrigger)) 233 if (command_line.HasSwitch(switches::kEnableWebFontsInterventionTrigger))
235 WebRuntimeFeatures::enableWebFontsInterventionTrigger(true); 234 WebRuntimeFeatures::enableWebFontsInterventionTrigger(true);
236 235
237 WebRuntimeFeatures::enableScrollAnchoring( 236 WebRuntimeFeatures::enableScrollAnchoring(
238 base::FeatureList::IsEnabled(features::kScrollAnchoring) || 237 base::FeatureList::IsEnabled(features::kScrollAnchoring) ||
239 enableExperimentalWebPlatformFeatures); 238 enableExperimentalWebPlatformFeatures);
240 239
241 if (command_line.HasSwitch(switches::kEnableSlimmingPaintV2)) 240 if (command_line.HasSwitch(switches::kEnableSlimmingPaintV2))
242 WebRuntimeFeatures::enableSlimmingPaintV2(true); 241 WebRuntimeFeatures::enableSlimmingPaintV2(true);
243 242
244 // Note that it might already by true for OS_ANDROID, above. This is for
245 // non-android versions.
246 if (base::FeatureList::IsEnabled(features::kNewMediaPlaybackUi))
247 WebRuntimeFeatures::enableNewMediaPlaybackUi(true);
248
249 if (base::FeatureList::IsEnabled( 243 if (base::FeatureList::IsEnabled(
250 features::kNonValidatingReloadOnNormalReload)) { 244 features::kNonValidatingReloadOnNormalReload)) {
251 WebRuntimeFeatures::enableReloadwithoutSubResourceCacheRevalidation(true); 245 WebRuntimeFeatures::enableReloadwithoutSubResourceCacheRevalidation(true);
252 } 246 }
253 247
254 if (base::FeatureList::IsEnabled(features::kDocumentWriteEvaluator)) 248 if (base::FeatureList::IsEnabled(features::kDocumentWriteEvaluator))
255 WebRuntimeFeatures::enableDocumentWriteEvaluator(true); 249 WebRuntimeFeatures::enableDocumentWriteEvaluator(true);
256 250
257 WebRuntimeFeatures::enableMediaDocumentDownloadButton( 251 WebRuntimeFeatures::enableMediaDocumentDownloadButton(
258 base::FeatureList::IsEnabled(features::kMediaDocumentDownloadButton)); 252 base::FeatureList::IsEnabled(features::kMediaDocumentDownloadButton));
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 if (command_line.HasSwitch(switches::kDisableBlinkFeatures)) { 325 if (command_line.HasSwitch(switches::kDisableBlinkFeatures)) {
332 std::vector<std::string> disabled_features = base::SplitString( 326 std::vector<std::string> disabled_features = base::SplitString(
333 command_line.GetSwitchValueASCII(switches::kDisableBlinkFeatures), 327 command_line.GetSwitchValueASCII(switches::kDisableBlinkFeatures),
334 ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL); 328 ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
335 for (const std::string& feature : disabled_features) 329 for (const std::string& feature : disabled_features)
336 WebRuntimeFeatures::enableFeatureFromString(feature, false); 330 WebRuntimeFeatures::enableFeatureFromString(feature, false);
337 } 331 }
338 } 332 }
339 333
340 } // namespace content 334 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/public/common/content_features.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698