Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2447663002: Remove obsolete media player resources. (Closed)

Created:
4 years, 1 month ago by mlamouri (slow - plz ping)
Modified:
4 years, 1 month ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-css, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, jam, mlamouri+watch-blink_chromium.org, rwlbuis, nessy, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete media player resources. Following https://codereview.chromium.org/2447503002 This clean up the resources that became obsolete now that the old media player can no longer be used in Chromium. BUG=658520 Committed: https://crrev.com/81de2a463baa494992cdf9152e5330e5c7bfc37b Cr-Commit-Position: refs/heads/master@{#427660}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -665 lines) Patch
M content/child/blink_platform_impl.cc View 4 chunks +0 lines, -69 lines 0 comments Download
D third_party/WebKit/Source/core/css/mediaControls.css View 1 chunk +0 lines, -490 lines 0 comments Download
D third_party/WebKit/Source/core/css/mediaControlsAndroid.css View 1 1 chunk +0 lines, -82 lines 0 comments Download
M third_party/WebKit/public/blink_image_resources.grd View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/public/blink_resources.grd View 2 chunks +0 lines, -2 lines 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_cast_off.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_cast_on.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_closedcaption.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_closedcaption_disabled.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_closedcaptions_icon.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_fullscreen.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_fullscreen_disabled.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_overlay_cast_off.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_overlay_play.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_pause.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_play.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_play_disabled.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_slider_thumb.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_sound_disabled.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_sound_level0.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_sound_level1.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_sound_level2.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_sound_level3.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_subtitles_icon.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_trackselection_checkmark.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_volume_slider_thumb.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_volume_slider_thumb_disabled.png View Binary file 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
mlamouri (slow - plz ping)
foolip@, PTAL at: third_party/WebKit jochen@, PTAL at: content/child/blink_platform_impl.cc +liberato@ FYI Thanks :)
4 years, 1 month ago (2016-10-24 10:32:38 UTC) #2
foolip
lgtm, I guess renaming fooNew.* files to foo.* makes sense as a CL after this ...
4 years, 1 month ago (2016-10-24 11:34:31 UTC) #3
mlamouri (slow - plz ping)
On 2016/10/24 at 11:34:31, foolip wrote: > lgtm, I guess renaming fooNew.* files to foo.* ...
4 years, 1 month ago (2016-10-24 12:38:03 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-10-26 08:21:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447663002/20001
4 years, 1 month ago (2016-10-26 10:28:04 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 10:32:57 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 10:34:34 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81de2a463baa494992cdf9152e5330e5c7bfc37b
Cr-Commit-Position: refs/heads/master@{#427660}

Powered by Google App Engine
This is Rietveld 408576698