Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2443903002: Remove all "new" suffixes from media player assets. (Closed)

Created:
4 years, 1 month ago by mlamouri (slow - plz ping)
Modified:
4 years, 1 month ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-css, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, jam, mlamouri+watch-blink_chromium.org, rwlbuis, nessy, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all "new" suffixes from media player assets. Now that the "old" assets are out, we should leave the "new" namespace for things that might actually be new-er :) BUG=658520 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1 Cr-Commit-Position: refs/heads/master@{#427788}

Patch Set 1 #

Patch Set 2 : rename things in MediaControlsPainter #

Patch Set 3 : rebase #

Patch Set 4 : update css file expected name #

Patch Set 5 : fix name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -729 lines) Patch
M content/child/blink_platform_impl.cc View 1 4 chunks +34 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/css/mediaControls.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/css/mediaControlsAndroid.css View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/Source/core/css/mediaControlsAndroidNew.css View 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/WebKit/Source/core/css/mediaControlsNew.css View 1 chunk +0 lines, -534 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp View 1 2 3 4 15 chunks +50 lines, -72 lines 0 comments Download
M third_party/WebKit/public/blink_image_resources.grd View 1 1 chunk +16 lines, -16 lines 0 comments Download
M third_party/WebKit/public/blink_resources.grd View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/public/default_100_percent/blink/mediaplayer_cast_off.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_cast_off_new.png View Binary file 0 comments Download
A + third_party/WebKit/public/default_100_percent/blink/mediaplayer_cast_on.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_cast_on_new.png View Binary file 0 comments Download
A + third_party/WebKit/public/default_100_percent/blink/mediaplayer_closedcaption.png View Binary file 0 comments Download
A + third_party/WebKit/public/default_100_percent/blink/mediaplayer_closedcaption_disabled.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_closedcaption_disabled_new.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_closedcaption_new.png View Binary file 0 comments Download
A + third_party/WebKit/public/default_100_percent/blink/mediaplayer_closedcaptions_icon.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_closedcaptions_icon_new.png View Binary file 0 comments Download
A + third_party/WebKit/public/default_100_percent/blink/mediaplayer_overlay_cast_off.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_overlay_cast_off_new.png View Binary file 0 comments Download
A + third_party/WebKit/public/default_100_percent/blink/mediaplayer_overlay_cast_on.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_overlay_cast_on_new.png View Binary file 0 comments Download
A + third_party/WebKit/public/default_100_percent/blink/mediaplayer_overlay_play.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_overlay_play_new.png View Binary file 0 comments Download
A + third_party/WebKit/public/default_100_percent/blink/mediaplayer_pause.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_pause_new.png View Binary file 0 comments Download
A + third_party/WebKit/public/default_100_percent/blink/mediaplayer_play.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_play_new.png View Binary file 0 comments Download
A + third_party/WebKit/public/default_100_percent/blink/mediaplayer_slider_thumb.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_slider_thumb_new.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_sound_level0_new.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_sound_level3_new.png View Binary file 0 comments Download
A + third_party/WebKit/public/default_100_percent/blink/mediaplayer_sound_muted.png View 1 Binary file 0 comments Download
A + third_party/WebKit/public/default_100_percent/blink/mediaplayer_sound_not_muted.png View 1 Binary file 0 comments Download
A + third_party/WebKit/public/default_100_percent/blink/mediaplayer_subtitles_icon.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_subtitles_icon_new.png View Binary file 0 comments Download
A + third_party/WebKit/public/default_100_percent/blink/mediaplayer_trackselection_checkmark.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_trackselection_checkmark_new.png View Binary file 0 comments Download
A + third_party/WebKit/public/default_100_percent/blink/mediaplayer_volume_slider_thumb.png View Binary file 0 comments Download
D third_party/WebKit/public/default_100_percent/blink/mediaplayer_volume_slider_thumb_new.png View Binary file 0 comments Download

Messages

Total messages: 28 (20 generated)
mlamouri (slow - plz ping)
foolip@, PTAL at: third_party/WebKit jochen@, PTAL at: content/child/runtime_features.cc content/public/common/content_features.cc content/public/common/content_features.h +liberato@ FYI Thanks :)
4 years, 1 month ago (2016-10-24 12:15:09 UTC) #4
foolip
lgtm Thanks!
4 years, 1 month ago (2016-10-24 12:20:00 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-10-26 08:21:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443903002/60001
4 years, 1 month ago (2016-10-26 15:59:22 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/55910)
4 years, 1 month ago (2016-10-26 17:02:57 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443903002/80001
4 years, 1 month ago (2016-10-26 18:25:37 UTC) #25
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-10-26 21:10:05 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 21:12:25 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1
Cr-Commit-Position: refs/heads/master@{#427788}

Powered by Google App Engine
This is Rietveld 408576698