Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2375383003: Remove std::unique_ptr<>::release() on ScopedVector::insert

Created:
4 years, 2 months ago by tzik
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, tfarina, Matt Giuca, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove std::unique_ptr<>::release() on ScopedVector::insert BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/profiles/profile_impl_io_data.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/dom_distiller/core/distiller_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync/engine_impl/cycle/data_type_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/app_list_item_list.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (4 generated)
tzik
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-09-29 09:21:09 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375383003/1
4 years, 2 months ago (2016-09-29 09:21:31 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-09-29 10:02:32 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 10:02:33 UTC) #4
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698