Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: components/sync/engine_impl/cycle/data_type_tracker.cc

Issue 2375383003: Remove std::unique_ptr<>::release() on ScopedVector::insert
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/dom_distiller/core/distiller_unittest.cc ('k') | ui/app_list/app_list_item_list.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/engine_impl/cycle/data_type_tracker.cc
diff --git a/components/sync/engine_impl/cycle/data_type_tracker.cc b/components/sync/engine_impl/cycle/data_type_tracker.cc
index 7040d4fe5baf5b152b77a44fb33833c73f83b87e..4a4634919f84f21ea73d1f483ebf5dafabb7d9d2 100644
--- a/components/sync/engine_impl/cycle/data_type_tracker.cc
+++ b/components/sync/engine_impl/cycle/data_type_tracker.cc
@@ -70,7 +70,7 @@ void DataTypeTracker::RecordRemoteInvalidation(
// Insert before the existing and get iterator to inserted.
ScopedVector<InvalidationInterface>::iterator it2 =
- pending_invalidations_.insert(it, incoming.release());
+ pending_invalidations_.insert(it, std::move(incoming));
// Increment that iterator to the old one, then acknowledge and remove it.
++it2;
@@ -79,7 +79,7 @@ void DataTypeTracker::RecordRemoteInvalidation(
} else {
// The incoming has a version not in the pending_invalidations_ list.
// Add it to the list at the proper position.
- pending_invalidations_.insert(it, incoming.release());
+ pending_invalidations_.insert(it, std::move(incoming));
}
// The incoming invalidation may have caused us to exceed our buffer size.
« no previous file with comments | « components/dom_distiller/core/distiller_unittest.cc ('k') | ui/app_list/app_list_item_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698