Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: components/dom_distiller/core/distiller_unittest.cc

Issue 2375383003: Remove std::unique_ptr<>::release() on ScopedVector::insert
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/core/distiller_unittest.cc
diff --git a/components/dom_distiller/core/distiller_unittest.cc b/components/dom_distiller/core/distiller_unittest.cc
index 6e91ce812d97cec53a021ef648ece9e15d86a09d..648964ff510280be580856dafabb69f0b7673b17 100644
--- a/components/dom_distiller/core/distiller_unittest.cc
+++ b/components/dom_distiller/core/distiller_unittest.cc
@@ -554,7 +554,7 @@ TEST_F(DistillerTest, MultiplePagesDistillationFailure) {
distiller_data->distilled_values.begin() + failed_page_num);
distiller_data->distilled_values.insert(
distiller_data->distilled_values.begin() + failed_page_num,
- base::Value::CreateNullValue().release());
+ base::Value::CreateNullValue());
// Expect only calls till the failed page number.
distiller_.reset(
new DistillerImpl(url_fetcher_factory_, DomDistillerOptions()));
@@ -585,7 +585,7 @@ TEST_F(DistillerTest, DistillMultiplePagesFirstEmpty) {
distiller_data->distilled_values.begin() + empty_page_num);
distiller_data->distilled_values.insert(
distiller_data->distilled_values.begin() + empty_page_num,
- distilled_value.release());
+ std::move(distilled_value));
distiller_.reset(
new DistillerImpl(url_fetcher_factory_, DomDistillerOptions()));
@@ -616,7 +616,7 @@ TEST_F(DistillerTest, DistillMultiplePagesSecondEmpty) {
distiller_data->distilled_values.begin() + empty_page_num);
distiller_data->distilled_values.insert(
distiller_data->distilled_values.begin() + empty_page_num,
- distilled_value.release());
+ std::move(distilled_value));
distiller_.reset(
new DistillerImpl(url_fetcher_factory_, DomDistillerOptions()));
« no previous file with comments | « chrome/browser/profiles/profile_impl_io_data.cc ('k') | components/sync/engine_impl/cycle/data_type_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698