Issue 2325623002: webrtc/base: Use RTC_DCHECK() instead of assert()

Issue 2325623002: webrtc/base: Use RTC_DCHECK() instead of assert() (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc

Modified:
4 years, 3 months ago

Reviewers:
ossu

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

webrtc/base: Use RTC_DCHECK() instead of assert() Committed: https://crrev.com/22487b2d0ad64af4278f02ecccb79afc2545415e Cr-Commit-Position: refs/heads/master@{#14192}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -47 lines)			Patch
M	webrtc/base/bytebuffer.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webrtc/base/fileutils.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	webrtc/base/firewallsocketserver.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	webrtc/base/flags.h	View	2 chunks	+8 lines, -10 lines	0 comments	Download
M	webrtc/base/flags.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	webrtc/base/maccocoasocketserver.mm	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webrtc/base/maccocoathreadhelper.mm	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	webrtc/base/nattypes.cc	View	2 chunks	+13 lines, -7 lines	0 comments	Download
M	webrtc/base/physicalsocketserver.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	webrtc/base/sec_buffer.h	View	1 chunk	+3 lines, -10 lines	0 comments	Download
M	webrtc/base/virtualsocketserver.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	webrtc/base/winping.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Dependent Patchsets:

Total messages: 15 (8 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2325623002/60001

4 years, 3 months ago (2016-09-12 11:36:30 UTC) #8

commit-bot: I haz the power

Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...

4 years, 3 months ago (2016-09-12 13:37:00 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2325623002/60001

4 years, 3 months ago (2016-09-13 08:15:53 UTC) #12

commit-bot: I haz the power

4 years, 3 months ago (2016-09-13 08:17:25 UTC) #15

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/22487b2d0ad64af4278f02ecccb79afc2545415e
Cr-Commit-Position: refs/heads/master@{#14192}