Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2320053003: webrtc/modules/audio_processing: Use RTC_DCHECK() instead of assert() (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
aleloi
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

webrtc/modules/audio_processing: Use RTC_DCHECK() instead of assert() Committed: https://crrev.com/9e2be5f292c574ca88e145ebb15b0ffd63f9b87c Cr-Commit-Position: refs/heads/master@{#14211}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove #include <cassert> #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -150 lines) Patch
M webrtc/modules/audio_processing/aec/aec_core.cc View 1 2 8 chunks +12 lines, -12 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_resampler.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core_c.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core_mips.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core_neon.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/audio_processing/agc/agc.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/agc/agc_manager_direct.cc View 1 5 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/agc/loudness_histogram.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/audio_buffer.cc View 8 chunks +18 lines, -15 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 1 2 4 chunks +5 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/common.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/gain_control_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/rms_level.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/transient/transient_detector.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M webrtc/modules/audio_processing/transient/wpd_node.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/transient/wpd_tree.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/utility/delay_estimator.cc View 10 chunks +13 lines, -12 lines 0 comments Download
M webrtc/modules/audio_processing/utility/delay_estimator_wrapper.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/audio_processing/vad/pitch_based_vad.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/vad/standalone_vad.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/vad/vad_audio_proc.h View 1 chunk +19 lines, -16 lines 0 comments Download
M webrtc/modules/audio_processing/vad/vad_audio_proc.cc View 8 chunks +8 lines, -7 lines 0 comments Download
M webrtc/modules/audio_processing/vad/vad_circular_buffer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/voice_detection_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
kwiberg-webrtc
4 years, 3 months ago (2016-09-12 09:11:11 UTC) #3
aleloi
lgtm with nit. https://codereview.webrtc.org/2320053003/diff/20001/webrtc/modules/audio_processing/agc/agc_manager_direct.cc File webrtc/modules/audio_processing/agc/agc_manager_direct.cc (right): https://codereview.webrtc.org/2320053003/diff/20001/webrtc/modules/audio_processing/agc/agc_manager_direct.cc#newcode13 webrtc/modules/audio_processing/agc/agc_manager_direct.cc:13: #include <cassert> This should be removed ...
4 years, 3 months ago (2016-09-12 10:04:56 UTC) #4
kwiberg-webrtc
New patch set uploaded. https://codereview.webrtc.org/2320053003/diff/20001/webrtc/modules/audio_processing/agc/agc_manager_direct.cc File webrtc/modules/audio_processing/agc/agc_manager_direct.cc (right): https://codereview.webrtc.org/2320053003/diff/20001/webrtc/modules/audio_processing/agc/agc_manager_direct.cc#newcode13 webrtc/modules/audio_processing/agc/agc_manager_direct.cc:13: #include <cassert> On 2016/09/12 10:04:56, ...
4 years, 3 months ago (2016-09-13 11:15:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2320053003/40001
4 years, 3 months ago (2016-09-13 11:15:17 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/8485) mac_gyp_dbg on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 3 months ago (2016-09-13 11:16:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2320053003/60001
4 years, 3 months ago (2016-09-13 11:24:36 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-09-13 13:25:00 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2320053003/60001
4 years, 3 months ago (2016-09-14 12:03:44 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 3 months ago (2016-09-14 12:23:26 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 12:23:36 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9e2be5f292c574ca88e145ebb15b0ffd63f9b87c
Cr-Commit-Position: refs/heads/master@{#14211}

Powered by Google App Engine
This is Rietveld 408576698