Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: webrtc/base/nattypes.cc

Issue 2325623002: webrtc/base: Use RTC_DCHECK() instead of assert() (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/maccocoathreadhelper.mm ('k') | webrtc/base/physicalsocketserver.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include <assert.h> 11 #include "webrtc/base/nattypes.h"
12 12
13 #include "webrtc/base/nattypes.h" 13 #include "webrtc/base/checks.h"
14 14
15 namespace rtc { 15 namespace rtc {
16 16
17 class SymmetricNAT : public NAT { 17 class SymmetricNAT : public NAT {
18 public: 18 public:
19 bool IsSymmetric() override { return true; } 19 bool IsSymmetric() override { return true; }
20 bool FiltersIP() override { return true; } 20 bool FiltersIP() override { return true; }
21 bool FiltersPort() override { return true; } 21 bool FiltersPort() override { return true; }
22 }; 22 };
23 23
(...skipping 13 matching lines...) Expand all
37 37
38 class PortRestrictedNAT : public NAT { 38 class PortRestrictedNAT : public NAT {
39 public: 39 public:
40 bool IsSymmetric() override { return false; } 40 bool IsSymmetric() override { return false; }
41 bool FiltersIP() override { return true; } 41 bool FiltersIP() override { return true; }
42 bool FiltersPort() override { return true; } 42 bool FiltersPort() override { return true; }
43 }; 43 };
44 44
45 NAT* NAT::Create(NATType type) { 45 NAT* NAT::Create(NATType type) {
46 switch (type) { 46 switch (type) {
47 case NAT_OPEN_CONE: return new OpenConeNAT(); 47 case NAT_OPEN_CONE:
48 case NAT_ADDR_RESTRICTED: return new AddressRestrictedNAT(); 48 return new OpenConeNAT();
49 case NAT_PORT_RESTRICTED: return new PortRestrictedNAT(); 49 case NAT_ADDR_RESTRICTED:
50 case NAT_SYMMETRIC: return new SymmetricNAT(); 50 return new AddressRestrictedNAT();
51 default: assert(0); return 0; 51 case NAT_PORT_RESTRICTED:
52 return new PortRestrictedNAT();
53 case NAT_SYMMETRIC:
54 return new SymmetricNAT();
55 default:
56 RTC_NOTREACHED();
57 return 0;
52 } 58 }
53 } 59 }
54 60
55 } // namespace rtc 61 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/base/maccocoathreadhelper.mm ('k') | webrtc/base/physicalsocketserver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698