Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: webrtc/base/firewallsocketserver.cc

Issue 2325623002: webrtc/base: Use RTC_DCHECK() instead of assert() (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/fileutils.cc ('k') | webrtc/base/flags.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/base/firewallsocketserver.h" 11 #include "webrtc/base/firewallsocketserver.h"
12 12
13 #include <assert.h>
14
15 #include <algorithm> 13 #include <algorithm>
16 14
17 #include "webrtc/base/asyncsocket.h" 15 #include "webrtc/base/asyncsocket.h"
16 #include "webrtc/base/checks.h"
18 #include "webrtc/base/logging.h" 17 #include "webrtc/base/logging.h"
19 18
20 namespace rtc { 19 namespace rtc {
21 20
22 class FirewallSocket : public AsyncSocketAdapter { 21 class FirewallSocket : public AsyncSocketAdapter {
23 public: 22 public:
24 FirewallSocket(FirewallSocketServer* server, AsyncSocket* socket, int type) 23 FirewallSocket(FirewallSocketServer* server, AsyncSocket* socket, int type)
25 : AsyncSocketAdapter(socket), server_(server), type_(type) { 24 : AsyncSocketAdapter(socket), server_(server), type_(type) {
26 } 25 }
27 26
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 delete sock; 212 delete sock;
214 return NULL; 213 return NULL;
215 } 214 }
216 return new FirewallSocket(this, sock, type); 215 return new FirewallSocket(this, sock, type);
217 } 216 }
218 217
219 FirewallManager::FirewallManager() { 218 FirewallManager::FirewallManager() {
220 } 219 }
221 220
222 FirewallManager::~FirewallManager() { 221 FirewallManager::~FirewallManager() {
223 assert(servers_.empty()); 222 RTC_DCHECK(servers_.empty());
224 } 223 }
225 224
226 void FirewallManager::AddServer(FirewallSocketServer* server) { 225 void FirewallManager::AddServer(FirewallSocketServer* server) {
227 CritScope scope(&crit_); 226 CritScope scope(&crit_);
228 servers_.push_back(server); 227 servers_.push_back(server);
229 } 228 }
230 229
231 void FirewallManager::RemoveServer(FirewallSocketServer* server) { 230 void FirewallManager::RemoveServer(FirewallSocketServer* server) {
232 CritScope scope(&crit_); 231 CritScope scope(&crit_);
233 servers_.erase(std::remove(servers_.begin(), servers_.end(), server), 232 servers_.erase(std::remove(servers_.begin(), servers_.end(), server),
(...skipping 11 matching lines...) Expand all
245 244
246 void FirewallManager::ClearRules() { 245 void FirewallManager::ClearRules() {
247 CritScope scope(&crit_); 246 CritScope scope(&crit_);
248 for (std::vector<FirewallSocketServer*>::const_iterator it = 247 for (std::vector<FirewallSocketServer*>::const_iterator it =
249 servers_.begin(); it != servers_.end(); ++it) { 248 servers_.begin(); it != servers_.end(); ++it) {
250 (*it)->ClearRules(); 249 (*it)->ClearRules();
251 } 250 }
252 } 251 }
253 252
254 } // namespace rtc 253 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/base/fileutils.cc ('k') | webrtc/base/flags.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698