Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2302893002: Reland of Add pps id and sps id parsing to the h.264 depacketizer. (Closed)

Created:
4 years, 3 months ago by stefan-webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add pps id and sps id parsing to the h.264 depacketizer. (patchset #1 id:1 of https://codereview.webrtc.org/2265023002/ ) Reason for revert: Reland this now that downstream tests have been fixed. Original issue's description: > Revert of Add pps id and sps id parsing to the h.264 depacketizer. (patchset #5 id:80001 of https://codereview.webrtc.org/2238253002/ ) > > Reason for revert: > Breaks some h264 bitstream tests downstream. Reverting for now. > > Original issue's description: > > Add pps id and sps id parsing to the h.264 depacketizer. > > > > BUG=webrtc:6208 > > > > Committed: https://crrev.com/abcc3de169d8896ad60e920e5677600fb3d40180 > > Cr-Commit-Position: refs/heads/master@{#13838} > > TBR=sprang@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6208 > > Committed: https://crrev.com/83d79cd4a2bfbdd1abc1f75480488df4446f5fe0 > Cr-Commit-Position: refs/heads/master@{#13844} TBR=sprang@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6208 Committed: https://crrev.com/8a5cef8d0a594a1f46f6eeb2a37d785f3afe236d Cr-Commit-Position: refs/heads/master@{#14042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -122 lines) Patch
M webrtc/common_video/h264/pps_parser.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/common_video/h264/pps_parser.cc View 3 chunks +23 lines, -2 lines 0 comments Download
M webrtc/common_video/h264/pps_parser_unittest.cc View 5 chunks +25 lines, -4 lines 0 comments Download
M webrtc/common_video/h264/sps_parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_video/h264/sps_parser.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/common_video/h264/sps_parser_unittest.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M webrtc/common_video/h264/sps_vui_rewriter.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M webrtc/common_video/h264/sps_vui_rewriter_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/modules/include/module_common_types.h View 2 chunks +10 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 8 chunks +123 lines, -81 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc View 5 chunks +67 lines, -24 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
stefan-webrtc
Created Reland of Add pps id and sps id parsing to the h.264 depacketizer.
4 years, 3 months ago (2016-09-01 14:10:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2302893002/1
4 years, 3 months ago (2016-09-01 14:11:10 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on ...
4 years, 3 months ago (2016-09-01 16:11:43 UTC) #5
kjellander_webrtc
lgtm
4 years, 3 months ago (2016-09-01 19:26:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2302893002/1
4 years, 3 months ago (2016-09-01 19:33:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-01 21:33:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2302893002/1
4 years, 3 months ago (2016-09-02 11:00:02 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 11:07:32 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 11:07:44 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a5cef8d0a594a1f46f6eeb2a37d785f3afe236d
Cr-Commit-Position: refs/heads/master@{#14042}

Powered by Google App Engine
This is Rietveld 408576698