Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2265023002: Revert of Add pps id and sps id parsing to the h.264 depacketizer. (Closed)

Created:
4 years, 4 months ago by kjellander_webrtc
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add pps id and sps id parsing to the h.264 depacketizer. (patchset #5 id:80001 of https://codereview.webrtc.org/2238253002/ ) Reason for revert: Breaks some h264 bitstream tests downstream. Reverting for now. Original issue's description: > Add pps id and sps id parsing to the h.264 depacketizer. > > BUG=webrtc:6208 > > Committed: https://crrev.com/abcc3de169d8896ad60e920e5677600fb3d40180 > Cr-Commit-Position: refs/heads/master@{#13838} TBR=sprang@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6208 Committed: https://crrev.com/83d79cd4a2bfbdd1abc1f75480488df4446f5fe0 Cr-Commit-Position: refs/heads/master@{#13844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -274 lines) Patch
M webrtc/common_video/h264/pps_parser.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/common_video/h264/pps_parser.cc View 3 chunks +2 lines, -23 lines 0 comments Download
M webrtc/common_video/h264/pps_parser_unittest.cc View 5 chunks +4 lines, -25 lines 0 comments Download
M webrtc/common_video/h264/sps_parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_video/h264/sps_parser.cc View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/common_video/h264/sps_parser_unittest.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M webrtc/common_video/h264/sps_vui_rewriter.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M webrtc/common_video/h264/sps_vui_rewriter_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M webrtc/modules/include/module_common_types.h View 2 chunks +0 lines, -10 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 8 chunks +81 lines, -123 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc View 5 chunks +24 lines, -67 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_webrtc
Created Revert of Add pps id and sps id parsing to the h.264 depacketizer.
4 years, 4 months ago (2016-08-22 12:34:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2265023002/1
4 years, 4 months ago (2016-08-22 12:34:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 12:34:40 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/83d79cd4a2bfbdd1abc1f75480488df4446f5fe0 Cr-Commit-Position: refs/heads/master@{#13844}
4 years, 4 months ago (2016-08-22 12:34:51 UTC) #6
stefan-webrtc
4 years, 3 months ago (2016-09-01 14:10:40 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2302893002/ by stefan@webrtc.org.

The reason for reverting is: Reland this now that downstream tests have been
fixed..

Powered by Google App Engine
This is Rietveld 408576698