Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2238253002: Add pps id and sps id parsing to the h.264 depacketizer. (Closed)

Created:
4 years, 4 months ago by stefan-webrtc
Modified:
4 years, 4 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add pps id and sps id parsing to the h.264 depacketizer. BUG=webrtc:6208 Committed: https://crrev.com/abcc3de169d8896ad60e920e5677600fb3d40180 Cr-Commit-Position: refs/heads/master@{#13838}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Changed vector for an array. #

Patch Set 4 : Move rbsp parsing from rtp format h264. #

Patch Set 5 : Retry without including h264_common.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -119 lines) Patch
M webrtc/common_video/h264/pps_parser.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/common_video/h264/pps_parser.cc View 1 2 3 3 chunks +23 lines, -2 lines 0 comments Download
M webrtc/common_video/h264/pps_parser_unittest.cc View 1 2 3 5 chunks +25 lines, -4 lines 0 comments Download
M webrtc/common_video/h264/sps_parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_video/h264/sps_parser.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/common_video/h264/sps_parser_unittest.cc View 1 3 chunks +9 lines, -4 lines 0 comments Download
M webrtc/common_video/h264/sps_vui_rewriter.cc View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M webrtc/common_video/h264/sps_vui_rewriter_unittest.cc View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/modules/include/module_common_types.h View 1 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 1 2 3 4 8 chunks +123 lines, -81 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc View 1 2 5 chunks +64 lines, -21 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
stefan-webrtc
4 years, 4 months ago (2016-08-12 12:40:01 UTC) #2
stefan-webrtc
Changed vector for an array.
4 years, 4 months ago (2016-08-12 13:16:33 UTC) #3
stefan-webrtc
ptal
4 years, 4 months ago (2016-08-16 09:28:32 UTC) #4
sprang_webrtc
lgtm
4 years, 4 months ago (2016-08-16 10:52:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2238253002/60001
4 years, 4 months ago (2016-08-16 12:16:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/299)
4 years, 4 months ago (2016-08-16 13:21:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2238253002/60001
4 years, 4 months ago (2016-08-16 16:18:35 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_drmemory_light on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/builds/14067)
4 years, 4 months ago (2016-08-16 16:31:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2238253002/80001
4 years, 4 months ago (2016-08-17 13:05:16 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 4 months ago (2016-08-17 15:05:48 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2238253002/80001
4 years, 4 months ago (2016-08-22 07:32:29 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-22 08:20:40 UTC) #21
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/abcc3de169d8896ad60e920e5677600fb3d40180 Cr-Commit-Position: refs/heads/master@{#13838}
4 years, 4 months ago (2016-08-22 08:20:51 UTC) #23
kjellander_webrtc
4 years, 4 months ago (2016-08-22 12:34:27 UTC) #24
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.webrtc.org/2265023002/ by kjellander@webrtc.org.

The reason for reverting is: Breaks some h264 bitstream tests downstream.
Reverting for now..

Powered by Google App Engine
This is Rietveld 408576698