Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2296613002: Delete talk directory, and references from build_ios_libs.sh. (Closed)

Created:
4 years, 3 months ago by nisse-webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete talk directory, and references from build_ios_libs.sh. BUG=webrtc:4256 Committed: https://crrev.com/3d21e23df22d885b6a58720bec0f131391d40508 Cr-Commit-Position: refs/heads/master@{#14040}

Patch Set 1 #

Patch Set 2 : Drop a few remaining references to talk/. #

Total comments: 10

Patch Set 3 : Add licensing info for files copied from talk/base. #

Total comments: 3

Patch Set 4 : Update filenames for c -> c++ conversion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -8597 lines) Patch
D COPYING View 1 1 chunk +0 lines, -1 line 0 comments Download
M LICENSE_THIRD_PARTY View 1 1 chunk +1 line, -1 line 0 comments Download
M PRESUBMIT.py View 1 2 chunks +1 line, -1 line 0 comments Download
M all.gyp View 1 1 chunk +0 lines, -12 lines 0 comments Download
D talk/COPYING View 1 chunk +0 lines, -25 lines 0 comments Download
D talk/LICENSE_THIRD_PARTY View 1 chunk +0 lines, -27 lines 0 comments Download
D talk/OWNERS View 1 chunk +0 lines, -13 lines 0 comments Download
D talk/PRESUBMIT.py View 1 chunk +0 lines, -94 lines 0 comments Download
D talk/app/webrtc/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D talk/app/webrtc/legacy_objc_api.gyp View 1 chunk +0 lines, -193 lines 0 comments Download
D talk/app/webrtc/legacy_objc_api_tests.gyp View 1 chunk +0 lines, -94 lines 0 comments Download
D talk/app/webrtc/objc/.clang-format View 1 chunk +0 lines, -10 lines 0 comments Download
D talk/app/webrtc/objc/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D talk/app/webrtc/objc/README View 1 chunk +0 lines, -68 lines 0 comments Download
D talk/app/webrtc/objc/RTCAVFoundationVideoSource.mm View 1 chunk +0 lines, -74 lines 0 comments Download
D talk/app/webrtc/objc/RTCAVFoundationVideoSource+Internal.h View 1 chunk +0 lines, -36 lines 0 comments Download
D talk/app/webrtc/objc/RTCAudioTrack.mm View 1 chunk +0 lines, -45 lines 0 comments Download
D talk/app/webrtc/objc/RTCAudioTrack+Internal.h View 1 chunk +0 lines, -37 lines 0 comments Download
D talk/app/webrtc/objc/RTCDataChannel.mm View 1 chunk +0 lines, -292 lines 0 comments Download
D talk/app/webrtc/objc/RTCDataChannel+Internal.h View 1 chunk +0 lines, -55 lines 0 comments Download
D talk/app/webrtc/objc/RTCEAGLVideoView.m View 1 chunk +0 lines, -277 lines 0 comments Download
D talk/app/webrtc/objc/RTCEnumConverter.h View 1 chunk +0 lines, -83 lines 0 comments Download
D talk/app/webrtc/objc/RTCEnumConverter.mm View 1 chunk +0 lines, -223 lines 0 comments Download
D talk/app/webrtc/objc/RTCI420Frame.mm View 1 chunk +0 lines, -109 lines 0 comments Download
D talk/app/webrtc/objc/RTCI420Frame+Internal.h View 1 chunk +0 lines, -36 lines 0 comments Download
D talk/app/webrtc/objc/RTCICECandidate.mm View 1 chunk +0 lines, -87 lines 0 comments Download
D talk/app/webrtc/objc/RTCICECandidate+Internal.h View 1 chunk +0 lines, -39 lines 0 comments Download
D talk/app/webrtc/objc/RTCICEServer.mm View 1 chunk +0 lines, -75 lines 0 comments Download
D talk/app/webrtc/objc/RTCICEServer+Internal.h View 1 chunk +0 lines, -38 lines 0 comments Download
D talk/app/webrtc/objc/RTCLogging.mm View 1 chunk +0 lines, -64 lines 0 comments Download
D talk/app/webrtc/objc/RTCMediaConstraints.mm View 1 chunk +0 lines, -76 lines 0 comments Download
D talk/app/webrtc/objc/RTCMediaConstraints+Internal.h View 1 chunk +0 lines, -40 lines 0 comments Download
D talk/app/webrtc/objc/RTCMediaConstraintsNative.h View 1 chunk +0 lines, -50 lines 0 comments Download
D talk/app/webrtc/objc/RTCMediaConstraintsNative.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D talk/app/webrtc/objc/RTCMediaSource.mm View 1 chunk +0 lines, -65 lines 0 comments Download
D talk/app/webrtc/objc/RTCMediaSource+Internal.h View 1 chunk +0 lines, -40 lines 0 comments Download
D talk/app/webrtc/objc/RTCMediaStream.mm View 1 chunk +0 lines, -146 lines 0 comments Download
D talk/app/webrtc/objc/RTCMediaStream+Internal.h View 1 chunk +0 lines, -40 lines 0 comments Download
D talk/app/webrtc/objc/RTCMediaStreamTrack.mm View 1 chunk +0 lines, -124 lines 0 comments Download
D talk/app/webrtc/objc/RTCMediaStreamTrack+Internal.h View 1 chunk +0 lines, -40 lines 0 comments Download
D talk/app/webrtc/objc/RTCNSGLVideoView.m View 1 chunk +0 lines, -158 lines 0 comments Download
D talk/app/webrtc/objc/RTCOpenGLVideoRenderer.mm View 1 chunk +0 lines, -503 lines 0 comments Download
D talk/app/webrtc/objc/RTCPair.m View 1 chunk +0 lines, -47 lines 0 comments Download
D talk/app/webrtc/objc/RTCPeerConnection.mm View 1 chunk +0 lines, -311 lines 0 comments Download
D talk/app/webrtc/objc/RTCPeerConnection+Internal.h View 1 chunk +0 lines, -48 lines 0 comments Download
D talk/app/webrtc/objc/RTCPeerConnectionFactory.mm View 1 chunk +0 lines, -159 lines 0 comments Download
D talk/app/webrtc/objc/RTCPeerConnectionFactory+Internal.h View 1 chunk +0 lines, -37 lines 0 comments Download
D talk/app/webrtc/objc/RTCPeerConnectionInterface.mm View 1 chunk +0 lines, -133 lines 0 comments Download
D talk/app/webrtc/objc/RTCPeerConnectionInterface+Internal.h View 1 chunk +0 lines, -39 lines 0 comments Download
D talk/app/webrtc/objc/RTCPeerConnectionObserver.h View 1 chunk +0 lines, -75 lines 0 comments Download
D talk/app/webrtc/objc/RTCPeerConnectionObserver.mm View 1 chunk +0 lines, -108 lines 0 comments Download
D talk/app/webrtc/objc/RTCSessionDescription.mm View 1 chunk +0 lines, -81 lines 0 comments Download
D talk/app/webrtc/objc/RTCSessionDescription+Internal.h View 1 chunk +0 lines, -41 lines 0 comments Download
D talk/app/webrtc/objc/RTCStatsReport.mm View 1 chunk +0 lines, -69 lines 0 comments Download
D talk/app/webrtc/objc/RTCStatsReport+Internal.h View 1 chunk +0 lines, -36 lines 0 comments Download
D talk/app/webrtc/objc/RTCVideoCapturer.mm View 1 chunk +0 lines, -67 lines 0 comments Download
D talk/app/webrtc/objc/RTCVideoCapturer+Internal.h View 1 chunk +0 lines, -38 lines 0 comments Download
D talk/app/webrtc/objc/RTCVideoRendererAdapter.h View 1 chunk +0 lines, -40 lines 0 comments Download
D talk/app/webrtc/objc/RTCVideoRendererAdapter.mm View 1 chunk +0 lines, -82 lines 0 comments Download
D talk/app/webrtc/objc/RTCVideoSource.mm View 1 chunk +0 lines, -44 lines 0 comments Download
D talk/app/webrtc/objc/RTCVideoSource+Internal.h View 1 chunk +0 lines, -37 lines 0 comments Download
D talk/app/webrtc/objc/RTCVideoTrack.mm View 1 chunk +0 lines, -123 lines 0 comments Download
D talk/app/webrtc/objc/RTCVideoTrack+Internal.h View 1 chunk +0 lines, -40 lines 0 comments Download
D talk/app/webrtc/objc/avfoundationvideocapturer.h View 1 chunk +0 lines, -89 lines 0 comments Download
D talk/app/webrtc/objc/avfoundationvideocapturer.mm View 1 chunk +0 lines, -562 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCAVFoundationVideoSource.h View 1 chunk +0 lines, -51 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCAudioSource.h View 1 chunk +0 lines, -40 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCAudioTrack.h View 1 chunk +0 lines, -39 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCDataChannel.h View 1 chunk +0 lines, -118 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCEAGLVideoView.h View 1 chunk +0 lines, -46 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCFileLogger.h View 1 chunk +0 lines, -91 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCI420Frame.h View 1 chunk +0 lines, -53 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCICECandidate.h View 1 chunk +0 lines, -56 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCICEServer.h View 1 chunk +0 lines, -49 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCLogging.h View 1 chunk +0 lines, -92 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCMediaConstraints.h View 1 chunk +0 lines, -39 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCMediaSource.h View 1 chunk +0 lines, -44 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCMediaStream.h View 1 chunk +0 lines, -51 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCMediaStreamTrack.h View 1 chunk +0 lines, -58 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCNSGLVideoView.h View 1 chunk +0 lines, -47 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCOpenGLVideoRenderer.h View 1 chunk +0 lines, -73 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCPair.h View 1 chunk +0 lines, -45 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCPeerConnection.h View 1 chunk +0 lines, -127 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCPeerConnectionDelegate.h View 1 chunk +0 lines, -72 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCPeerConnectionFactory.h View 1 chunk +0 lines, -77 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCPeerConnectionInterface.h View 1 chunk +0 lines, -83 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCSessionDescription.h View 1 chunk +0 lines, -50 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCSessionDescriptionDelegate.h View 1 chunk +0 lines, -49 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCStatsDelegate.h View 1 chunk +0 lines, -39 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCStatsReport.h View 1 chunk +0 lines, -45 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCTypes.h View 1 chunk +0 lines, -77 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCVideoCapturer.h View 1 chunk +0 lines, -42 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCVideoRenderer.h View 1 chunk +0 lines, -43 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCVideoSource.h View 1 chunk +0 lines, -39 lines 0 comments Download
D talk/app/webrtc/objc/public/RTCVideoTrack.h View 1 chunk +0 lines, -55 lines 0 comments Download
D talk/app/webrtc/objctests/Info.plist View 1 chunk +0 lines, -24 lines 0 comments Download
D talk/app/webrtc/objctests/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D talk/app/webrtc/objctests/README View 1 chunk +0 lines, -1 line 0 comments Download
D talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.h View 1 chunk +0 lines, -60 lines 0 comments Download
D talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.m View 1 chunk +0 lines, -263 lines 0 comments Download
D talk/app/webrtc/objctests/RTCPeerConnectionTest.mm View 1 chunk +0 lines, -350 lines 0 comments Download
D talk/app/webrtc/objctests/RTCSessionDescriptionSyncObserver.h View 1 chunk +0 lines, -49 lines 0 comments Download
D talk/app/webrtc/objctests/RTCSessionDescriptionSyncObserver.m View 1 chunk +0 lines, -103 lines 0 comments Download
D talk/app/webrtc/objctests/mac/main.mm View 1 chunk +0 lines, -37 lines 0 comments Download
D talk/build/common.gypi View 1 chunk +0 lines, -127 lines 0 comments Download
D talk/codereview.settings View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/LICENSE_THIRD_PARTY View 1 2 3 2 chunks +69 lines, -0 lines 0 comments Download
M webrtc/build/ios/build_ios_libs.sh View 5 chunks +10 lines, -18 lines 0 comments Download
M webrtc/build/ios/merge_ios_libs.gyp View 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/webrtc_examples.gyp View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
nisse-webrtc
This cl deletes talk/ and almost all references to it (git grep talk/). The mac ...
4 years, 3 months ago (2016-08-30 09:15:51 UTC) #2
kjellander_webrtc
lgtm! If anyone relies on these sources, they can always use our recently created branch. ...
4 years, 3 months ago (2016-08-31 15:39:28 UTC) #3
kjellander_webrtc
I guess I meant lgtm with comments addressed :) https://codereview.webrtc.org/2296613002/diff/20001/COPYING File COPYING (left): https://codereview.webrtc.org/2296613002/diff/20001/COPYING#oldcode1 COPYING:1: ...
4 years, 3 months ago (2016-08-31 15:39:52 UTC) #4
nisse-webrtc
Can anyone else review the build/ios changes while tkchin is travelling? https://codereview.webrtc.org/2296613002/diff/20001/COPYING File COPYING (left): ...
4 years, 3 months ago (2016-09-01 13:32:06 UTC) #5
kjellander_webrtc
I'm owner in build/ as well and did take a look at the scripts. You'll ...
4 years, 3 months ago (2016-09-01 13:49:15 UTC) #6
nisse-webrtc
Tommi, do you approve of deleting this now? Latest from Zeke was that we can ...
4 years, 3 months ago (2016-09-01 14:04:27 UTC) #8
tommi
lgtm since tkchin approves
4 years, 3 months ago (2016-09-01 14:25:04 UTC) #9
kjellander_webrtc
On 2016/09/01 14:04:27, nisse-webrtc wrote: > Tommi, do you approve of deleting this now? > ...
4 years, 3 months ago (2016-09-01 19:14:07 UTC) #10
kjellander_webrtc
one more comment. https://codereview.webrtc.org/2296613002/diff/40001/webrtc/LICENSE_THIRD_PARTY File webrtc/LICENSE_THIRD_PARTY (right): https://codereview.webrtc.org/2296613002/diff/40001/webrtc/LICENSE_THIRD_PARTY#newcode5 webrtc/LICENSE_THIRD_PARTY:5: base/base64.c On 2016/09/01 14:04:27, nisse-webrtc wrote: ...
4 years, 3 months ago (2016-09-01 19:16:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2296613002/60001
4 years, 3 months ago (2016-09-02 07:54:10 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_asan on master.tryserver.webrtc (JOB_FAILED, no build URL)
4 years, 3 months ago (2016-09-02 08:28:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2296613002/60001
4 years, 3 months ago (2016-09-02 08:33:21 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-02 10:07:10 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 10:07:18 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3d21e23df22d885b6a58720bec0f131391d40508
Cr-Commit-Position: refs/heads/master@{#14040}

Powered by Google App Engine
This is Rietveld 408576698