Delete talk directory, and references from build_ios_libs.sh.

Delete talk directory, and references from build_ios_libs.sh.

BUG=webrtc:4256
Committed: https://crrev.com/3d21e23df22d885b6a58720bec0f131391d40508
Cr-Commit-Position: refs/heads/master@{#14040}

[nisse-webrtc, 2016-08-30 09:15:49]

nisse@webrtc.org changed reviewers:
+ kjellander@webrtc.org, tkchin@webrtc.org

[nisse-webrtc, 2016-08-30 09:15:51]

This cl deletes talk/ and almost all references to it (git grep talk/). The mac
and ios bots I tried now seem happy.

Do we need a top-level COPYING file, or is LICENSE good enough?

From comments in PRESUBMIT.py, it seems it could be simplified when talk is
gone, but I haven't tried to do anything about that.

[kjellander_webrtc, 2016-08-31 15:39:28]

lgtm! If anyone relies on these sources, they can always use our recently
created branch.

On 2016/08/30 09:15:51, nisse-webrtc wrote:
> This cl deletes talk/ and almost all references to it (git grep talk/). The
mac
> and ios bots I tried now seem happy.
> 
> Do we need a top-level COPYING file, or is LICENSE good enough?

I dunno, I'd be safe and copy the contents of the old one into the top level
COPYING file.

> 
> From comments in PRESUBMIT.py, it seems it could be simplified when talk is
> gone, but I haven't tried to do anything about that.

We can do that in a follow-up CL.

[kjellander_webrtc, 2016-08-31 15:39:52]

I guess I meant lgtm with comments addressed :)

https://codereview.webrtc.org/2296613002/diff/20001/COPYING
File COPYING (left):

https://codereview.webrtc.org/2296613002/diff/20001/COPYING#oldcode1
COPYING:1: Refer to talk/COPYING.
I suggest copying the contents of that file into this.

https://codereview.webrtc.org/2296613002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/2296613002/diff/20001/PRESUBMIT.py#newcode461
PRESUBMIT.py:461: # TODO(nisse): talk/ is no more, so make below checks simpler?
That would be nice, to use presubmit_canned_checks.PanProjectChecks instead of
duplicating a lot like below!
See
https://cs.chromium.org/chromium/tools/depot_tools/presubmit_canned_checks.py...

https://codereview.webrtc.org/2296613002/diff/20001/talk/LICENSE_THIRD_PARTY
File talk/LICENSE_THIRD_PARTY (left):

https://codereview.webrtc.org/2296613002/diff/20001/talk/LICENSE_THIRD_PARTY#...
talk/LICENSE_THIRD_PARTY:1: This source tree contains third party source code
which is governed by third
These files actually live in webrtc/base/ now so I think we should keep this and
move it into webrtc/ instead.
I guess it was just missed when moving those sources from talk/base to
webrtc/base.

[nisse-webrtc, 2016-09-01 13:32:06]

Can anyone else review the build/ios changes while tkchin is travelling?

https://codereview.webrtc.org/2296613002/diff/20001/COPYING
File COPYING (left):

https://codereview.webrtc.org/2296613002/diff/20001/COPYING#oldcode1
COPYING:1: Refer to talk/COPYING.
On 2016/08/31 15:39:52, kjellander_webrtc wrote:
> I suggest copying the contents of that file into this.

talk/COPYING says "Copyright (c) 2013, Google Inc.", while webrtc/LICENSE says
"Copyright (c) 2011, The WebRTC project authors."

It seems a bit sloppy and confusing to have both. Which one is correct?

https://codereview.webrtc.org/2296613002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/2296613002/diff/20001/PRESUBMIT.py#newcode461
PRESUBMIT.py:461: # TODO(nisse): talk/ is no more, so make below checks simpler?
On 2016/08/31 15:39:52, kjellander_webrtc wrote:
> That would be nice, to use presubmit_canned_checks.PanProjectChecks instead of
> duplicating a lot like below!
> See
>
https://cs.chromium.org/chromium/tools/depot_tools/presubmit_canned_checks.py...

I'd need some more detailed guidance if you want me to do that in this cl, I'm
not familiar at all with the presubmit logic.

https://codereview.webrtc.org/2296613002/diff/20001/talk/LICENSE_THIRD_PARTY
File talk/LICENSE_THIRD_PARTY (left):

https://codereview.webrtc.org/2296613002/diff/20001/talk/LICENSE_THIRD_PARTY#...
talk/LICENSE_THIRD_PARTY:1: This source tree contains third party source code
which is governed by third
On 2016/08/31 15:39:52, kjellander_webrtc wrote:
> These files actually live in webrtc/base/ now so I think we should keep this
and
> move it into webrtc/ instead.
> I guess it was just missed when moving those sources from talk/base to
> webrtc/base.

Hmm. A file webrtc/LICENSE_THIRD_PARTY already exists, but with a different
structure to this one. 

I'm copying info about these files, except that I dropped the "Governed by"
lines which didn't fit in the new style, and I dropped libudev.h, which I
couldn't find in the tree.

[kjellander_webrtc, 2016-09-01 13:49:15]

I'm owner in build/ as well and did take a look at the scripts.
You'll still need a root owner approval though

https://codereview.webrtc.org/2296613002/diff/20001/COPYING
File COPYING (left):

https://codereview.webrtc.org/2296613002/diff/20001/COPYING#oldcode1
COPYING:1: Refer to talk/COPYING.
On 2016/09/01 13:32:06, nisse-webrtc wrote:
> On 2016/08/31 15:39:52, kjellander_webrtc wrote:
> > I suggest copying the contents of that file into this.
> 
> talk/COPYING says "Copyright (c) 2013, Google Inc.", while webrtc/LICENSE says
> "Copyright (c) 2011, The WebRTC project authors."
> 
> It seems a bit sloppy and confusing to have both. Which one is correct?

We should go with the WebRTC one.

https://codereview.webrtc.org/2296613002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/2296613002/diff/20001/PRESUBMIT.py#newcode461
PRESUBMIT.py:461: # TODO(nisse): talk/ is no more, so make below checks simpler?
On 2016/09/01 13:32:06, nisse-webrtc wrote:
> On 2016/08/31 15:39:52, kjellander_webrtc wrote:
> > That would be nice, to use presubmit_canned_checks.PanProjectChecks instead
of
> > duplicating a lot like below!
> > See
> >
>
https://cs.chromium.org/chromium/tools/depot_tools/presubmit_canned_checks.py...
> 
> I'd need some more detailed guidance if you want me to do that in this cl, I'm
> not familiar at all with the presubmit logic.

No let's do it in the future. I filed
https://bugs.chromium.org/p/webrtc/issues/detail?id=6292 to track that.

https://codereview.webrtc.org/2296613002/diff/20001/talk/LICENSE_THIRD_PARTY
File talk/LICENSE_THIRD_PARTY (left):

https://codereview.webrtc.org/2296613002/diff/20001/talk/LICENSE_THIRD_PARTY#...
talk/LICENSE_THIRD_PARTY:1: This source tree contains third party source code
which is governed by third
On 2016/09/01 13:32:06, nisse-webrtc wrote:
> On 2016/08/31 15:39:52, kjellander_webrtc wrote:
> > These files actually live in webrtc/base/ now so I think we should keep this
> and
> > move it into webrtc/ instead.
> > I guess it was just missed when moving those sources from talk/base to
> > webrtc/base.
> 
> Hmm. A file webrtc/LICENSE_THIRD_PARTY already exists, but with a different
> structure to this one. 
> 
> I'm copying info about these files, except that I dropped the "Governed by"
> lines which didn't fit in the new style, and I dropped libudev.h, which I
> couldn't find in the tree.

Right, libudev was removed a while back. Your merged version looks reasonable to
me.

https://codereview.webrtc.org/2296613002/diff/40001/webrtc/LICENSE_THIRD_PARTY
File webrtc/LICENSE_THIRD_PARTY (right):

https://codereview.webrtc.org/2296613002/diff/40001/webrtc/LICENSE_THIRD_PART...
webrtc/LICENSE_THIRD_PARTY:5: base/base64.c
Most of these have been changed from .c to .cc, so I guess it's best to update
them.

[nisse-webrtc, 2016-09-01 14:04:25]

nisse@webrtc.org changed reviewers:
+ tommi@webrtc.org

[nisse-webrtc, 2016-09-01 14:04:27]

Tommi, do you approve of deleting this now?

Latest from Zeke was that we can kill the talk/ directory if it's causing grief,
provided that the build_ios_libs.sh script is also updated.

https://codereview.webrtc.org/2296613002/diff/20001/COPYING
File COPYING (left):

https://codereview.webrtc.org/2296613002/diff/20001/COPYING#oldcode1
COPYING:1: Refer to talk/COPYING.
On 2016/09/01 13:49:14, kjellander_webrtc wrote:
> On 2016/09/01 13:32:06, nisse-webrtc wrote:
> > On 2016/08/31 15:39:52, kjellander_webrtc wrote:
> > > I suggest copying the contents of that file into this.
> > 
> > talk/COPYING says "Copyright (c) 2013, Google Inc.", while webrtc/LICENSE
says
> > "Copyright (c) 2011, The WebRTC project authors."
> > 
> > It seems a bit sloppy and confusing to have both. Which one is correct?
> 
> We should go with the WebRTC one.

So what about top-level COPYING, should we do without, or should we have a file
with the contents "Refer to webrtc/LICENSE." ?

https://codereview.webrtc.org/2296613002/diff/40001/webrtc/LICENSE_THIRD_PARTY
File webrtc/LICENSE_THIRD_PARTY (right):

https://codereview.webrtc.org/2296613002/diff/40001/webrtc/LICENSE_THIRD_PART...
webrtc/LICENSE_THIRD_PARTY:5: base/base64.c
On 2016/09/01 13:49:15, kjellander_webrtc wrote:
> Most of these have been changed from .c to .cc, so I guess it's best to update
> them.

Done.

[tommi, 2016-09-01 14:25:04]

lgtm since tkchin approves

[kjellander_webrtc, 2016-09-01 19:14:07]

On 2016/09/01 14:04:27, nisse-webrtc wrote:
> Tommi, do you approve of deleting this now?
> 
> Latest from Zeke was that we can kill the talk/ directory if it's causing
grief,
> provided that the build_ios_libs.sh script is also updated.
> 
> https://codereview.webrtc.org/2296613002/diff/20001/COPYING
> File COPYING (left):
> 
> https://codereview.webrtc.org/2296613002/diff/20001/COPYING#oldcode1
> COPYING:1: Refer to talk/COPYING.
> On 2016/09/01 13:49:14, kjellander_webrtc wrote:
> > On 2016/09/01 13:32:06, nisse-webrtc wrote:
> > > On 2016/08/31 15:39:52, kjellander_webrtc wrote:
> > > > I suggest copying the contents of that file into this.
> > > 
> > > talk/COPYING says "Copyright (c) 2013, Google Inc.", while webrtc/LICENSE
> says
> > > "Copyright (c) 2011, The WebRTC project authors."
> > > 
> > > It seems a bit sloppy and confusing to have both. Which one is correct?
> > 
> > We should go with the WebRTC one.
> 
> So what about top-level COPYING, should we do without, or should we have a
file
> with the contents "Refer to webrtc/LICENSE." ?

After reading at
http://stackoverflow.com/questions/5678462/should-i-provide-a-license-txt-or-...
it seems COPYING and LICENSE is somewhat the same. Since we have LICENSE I don't
think it makes sense to have the other.

> 
> https://codereview.webrtc.org/2296613002/diff/40001/webrtc/LICENSE_THIRD_PARTY
> File webrtc/LICENSE_THIRD_PARTY (right):
> 
>
https://codereview.webrtc.org/2296613002/diff/40001/webrtc/LICENSE_THIRD_PART...
> webrtc/LICENSE_THIRD_PARTY:5: base/base64.c
> On 2016/09/01 13:49:15, kjellander_webrtc wrote:
> > Most of these have been changed from .c to .cc, so I guess it's best to
update
> > them.
> 
> Done.

[kjellander_webrtc, 2016-09-01 19:16:24]

one more comment.

https://codereview.webrtc.org/2296613002/diff/40001/webrtc/LICENSE_THIRD_PARTY
File webrtc/LICENSE_THIRD_PARTY (right):

https://codereview.webrtc.org/2296613002/diff/40001/webrtc/LICENSE_THIRD_PART...
webrtc/LICENSE_THIRD_PARTY:5: base/base64.c
On 2016/09/01 14:04:27, nisse-webrtc wrote:
> On 2016/09/01 13:49:15, kjellander_webrtc wrote:
> > Most of these have been changed from .c to .cc, so I guess it's best to
update
> > them.
> 
> Done.

Not done. I see:
webrtc/base/base64.cc
webrtc/base/md5.cc 
webrtc/base/sha1.cc

[nisse-webrtc, 2016-09-02 07:54:02]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-09-02 07:54:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org, tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2296613002/#ps60001 (title:
"Update filenames for c -> c++ conversion.")

[commit-bot: I haz the power, 2016-09-02 07:54:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-02 08:28:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 08:28:29]

Try jobs failed on following builders:
  mac_asan on master.tryserver.webrtc (JOB_FAILED, no build URL)

[nisse-webrtc, 2016-09-02 08:33:15]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-09-02 08:33:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-02 10:07:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-02 10:07:17]

Description was changed from

==========
Delete talk directory, and references from build_ios_libs.sh.

BUG=webrtc:4256
==========

to

==========
Delete talk directory, and references from build_ios_libs.sh.

BUG=webrtc:4256

Committed: https://crrev.com/3d21e23df22d885b6a58720bec0f131391d40508
Cr-Commit-Position: refs/heads/master@{#14040}
==========

[commit-bot: I haz the power, 2016-09-02 10:07:18]

Patchset 4 (id:??) landed as
https://crrev.com/3d21e23df22d885b6a58720bec0f131391d40508
Cr-Commit-Position: refs/heads/master@{#14040}