COPYING - Issue 2296613002: Delete talk directory, and references from build_ios_libs.sh.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: COPYING

Issue 2296613002: Delete talk directory, and references from build_ios_libs.sh. (Closed)

Patch Set: Drop a few remaining references to talk/. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	(Empty)
1 Refer to talk/COPYING.
kjellander_webrtc 2016/08/31 15:39:52 I suggest copying the contents of that file into t I suggest copying the contents of that file into this. nisse-webrtc 2016/09/01 13:32:06 talk/COPYING says "Copyright (c) 2013, Google Inc. Show quoted text On 2016/08/31 15:39:52, kjellander_webrtc wrote: > I suggest copying the contents of that file into this. talk/COPYING says "Copyright (c) 2013, Google Inc.", while webrtc/LICENSE says "Copyright (c) 2011, The WebRTC project authors." It seems a bit sloppy and confusing to have both. Which one is correct? kjellander_webrtc 2016/09/01 13:49:14 We should go with the WebRTC one. Show quoted text On 2016/09/01 13:32:06, nisse-webrtc wrote: > On 2016/08/31 15:39:52, kjellander_webrtc wrote: > > I suggest copying the contents of that file into this. > > talk/COPYING says "Copyright (c) 2013, Google Inc.", while webrtc/LICENSE says > "Copyright (c) 2011, The WebRTC project authors." > > It seems a bit sloppy and confusing to have both. Which one is correct? We should go with the WebRTC one. nisse-webrtc 2016/09/01 14:04:27 So what about top-level COPYING, should we do with Show quoted text On 2016/09/01 13:49:14, kjellander_webrtc wrote: > On 2016/09/01 13:32:06, nisse-webrtc wrote: > > On 2016/08/31 15:39:52, kjellander_webrtc wrote: > > > I suggest copying the contents of that file into this. > > > > talk/COPYING says "Copyright (c) 2013, Google Inc.", while webrtc/LICENSE says > > "Copyright (c) 2011, The WebRTC project authors." > > > > It seems a bit sloppy and confusing to have both. Which one is correct? > > We should go with the WebRTC one. So what about top-level COPYING, should we do without, or should we have a file with the contents "Refer to webrtc/LICENSE." ?
OLD	NEW

« no previous file with comments | « no previous file | LICENSE_THIRD_PARTY » ('j') | PRESUBMIT.py » ('J')