Chromium Code Reviews| OLD | NEW | 
|---|---|
| 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. | 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. | 
| 2 # | 2 # | 
| 3 # Use of this source code is governed by a BSD-style license | 3 # Use of this source code is governed by a BSD-style license | 
| 4 # that can be found in the LICENSE file in the root of the source | 4 # that can be found in the LICENSE file in the root of the source | 
| 5 # tree. An additional intellectual property rights grant can be found | 5 # tree. An additional intellectual property rights grant can be found | 
| 6 # in the file PATENTS. All contributing project authors may | 6 # in the file PATENTS. All contributing project authors may | 
| 7 # be found in the AUTHORS file in the root of the source tree. | 7 # be found in the AUTHORS file in the root of the source tree. | 
| 8 | 8 | 
| 9 import json | 9 import json | 
| 10 import os | 10 import os | 
| (...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 56 NATIVE_API_DIRS = ( | 56 NATIVE_API_DIRS = ( | 
| 57 'webrtc', | 57 'webrtc', | 
| 58 'webrtc/api', | 58 'webrtc/api', | 
| 59 'webrtc/media', | 59 'webrtc/media', | 
| 60 'webrtc/modules/audio_device/include', | 60 'webrtc/modules/audio_device/include', | 
| 61 'webrtc/pc', | 61 'webrtc/pc', | 
| 62 ) | 62 ) | 
| 63 # These directories should not be used but are maintained only to avoid breaking | 63 # These directories should not be used but are maintained only to avoid breaking | 
| 64 # some legacy downstream code. | 64 # some legacy downstream code. | 
| 65 LEGACY_API_DIRS = ( | 65 LEGACY_API_DIRS = ( | 
| 66 'talk/app/webrtc', | |
| 67 'webrtc/base', | 66 'webrtc/base', | 
| 68 'webrtc/common_audio/include', | 67 'webrtc/common_audio/include', | 
| 69 'webrtc/modules/audio_coding/include', | 68 'webrtc/modules/audio_coding/include', | 
| 70 'webrtc/modules/audio_conference_mixer/include', | 69 'webrtc/modules/audio_conference_mixer/include', | 
| 71 'webrtc/modules/audio_processing/include', | 70 'webrtc/modules/audio_processing/include', | 
| 72 'webrtc/modules/bitrate_controller/include', | 71 'webrtc/modules/bitrate_controller/include', | 
| 73 'webrtc/modules/congestion_controller/include', | 72 'webrtc/modules/congestion_controller/include', | 
| 74 'webrtc/modules/include', | 73 'webrtc/modules/include', | 
| 75 'webrtc/modules/remote_bitrate_estimator/include', | 74 'webrtc/modules/remote_bitrate_estimator/include', | 
| 76 'webrtc/modules/rtp_rtcp/include', | 75 'webrtc/modules/rtp_rtcp/include', | 
| (...skipping 375 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 452 r'^tools[\\\/]valgrind-webrtc[\\\/].*\.py$', | 451 r'^tools[\\\/]valgrind-webrtc[\\\/].*\.py$', | 
| 453 r'^tools[\\\/]valgrind[\\\/].*\.py$', | 452 r'^tools[\\\/]valgrind[\\\/].*\.py$', | 
| 454 r'^tools[\\\/]win[\\\/].*\.py$', | 453 r'^tools[\\\/]win[\\\/].*\.py$', | 
| 455 r'^xcodebuild.*[\\\/].*\.py$',), | 454 r'^xcodebuild.*[\\\/].*\.py$',), | 
| 456 disabled_warnings=['F0401', # Failed to import x | 455 disabled_warnings=['F0401', # Failed to import x | 
| 457 'E0611', # No package y in x | 456 'E0611', # No package y in x | 
| 458 'W0232', # Class has no __init__ method | 457 'W0232', # Class has no __init__ method | 
| 459 ], | 458 ], | 
| 460 pylintrc='pylintrc')) | 459 pylintrc='pylintrc')) | 
| 461 | 460 | 
| 461 # TODO(nisse): talk/ is no more, so make below checks simpler? | |
| 
 
kjellander_webrtc
2016/08/31 15:39:52
That would be nice, to use presubmit_canned_checks
 
nisse-webrtc
2016/09/01 13:32:06
I'd need some more detailed guidance if you want m
 
kjellander_webrtc
2016/09/01 13:49:15
No let's do it in the future. I filed https://bugs
 
 | |
| 462 # WebRTC can't use the presubmit_canned_checks.PanProjectChecks function since | 462 # WebRTC can't use the presubmit_canned_checks.PanProjectChecks function since | 
| 463 # we need to have different license checks in talk/ and webrtc/ directories. | 463 # we need to have different license checks in talk/ and webrtc/ directories. | 
| 464 # Instead, hand-picked checks are included below. | 464 # Instead, hand-picked checks are included below. | 
| 465 | 465 | 
| 466 # .m and .mm files are ObjC files. For simplicity we will consider .h files in | 466 # .m and .mm files are ObjC files. For simplicity we will consider .h files in | 
| 467 # ObjC subdirectories ObjC headers. | 467 # ObjC subdirectories ObjC headers. | 
| 468 objc_filter_list = (r'.+\.m$', r'.+\.mm$', r'.+objc\/.+\.h$') | 468 objc_filter_list = (r'.+\.m$', r'.+\.mm$', r'.+objc\/.+\.h$') | 
| 469 # Skip long-lines check for DEPS, GN and GYP files. | 469 # Skip long-lines check for DEPS, GN and GYP files. | 
| 470 build_file_filter_list = (r'.+\.gyp$', r'.+\.gypi$', r'.+\.gn$', r'.+\.gni$', | 470 build_file_filter_list = (r'.+\.gyp$', r'.+\.gypi$', r'.+\.gn$', r'.+\.gni$', | 
| 471 'DEPS') | 471 'DEPS') | 
| (...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 538 for builder in masters[master]: | 538 for builder in masters[master]: | 
| 539 if 'presubmit' in builder: | 539 if 'presubmit' in builder: | 
| 540 # Do not trigger presubmit builders, since they're likely to fail | 540 # Do not trigger presubmit builders, since they're likely to fail | 
| 541 # (e.g. OWNERS checks before finished code review), and we're running | 541 # (e.g. OWNERS checks before finished code review), and we're running | 
| 542 # local presubmit anyway. | 542 # local presubmit anyway. | 
| 543 pass | 543 pass | 
| 544 else: | 544 else: | 
| 545 try_config[master][builder] = ['defaulttests'] | 545 try_config[master][builder] = ['defaulttests'] | 
| 546 | 546 | 
| 547 return try_config | 547 return try_config | 
| OLD | NEW |