Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: PRESUBMIT.py

Issue 2296613002: Delete talk directory, and references from build_ios_libs.sh. (Closed)
Patch Set: Drop a few remaining references to talk/. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 00bcc3e545910a89f381d575d74d94e877bff554..f07f49b9c83b72deee97583389b3cc87d2777f95 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -63,7 +63,6 @@ NATIVE_API_DIRS = (
# These directories should not be used but are maintained only to avoid breaking
# some legacy downstream code.
LEGACY_API_DIRS = (
- 'talk/app/webrtc',
'webrtc/base',
'webrtc/common_audio/include',
'webrtc/modules/audio_coding/include',
@@ -459,6 +458,7 @@ def _CommonChecks(input_api, output_api):
],
pylintrc='pylintrc'))
+ # TODO(nisse): talk/ is no more, so make below checks simpler?
kjellander_webrtc 2016/08/31 15:39:52 That would be nice, to use presubmit_canned_checks
nisse-webrtc 2016/09/01 13:32:06 I'd need some more detailed guidance if you want m
kjellander_webrtc 2016/09/01 13:49:15 No let's do it in the future. I filed https://bugs
# WebRTC can't use the presubmit_canned_checks.PanProjectChecks function since
# we need to have different license checks in talk/ and webrtc/ directories.
# Instead, hand-picked checks are included below.

Powered by Google App Engine
This is Rietveld 408576698