PRESUBMIT.py - Issue 2296613002: Delete talk directory, and references from build_ios_libs.sh.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 2296613002: Delete talk directory, and references from build_ios_libs.sh. (Closed)

Patch Set: Update filenames for c -> c++ conversion. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 00bcc3e545910a89f381d575d74d94e877bff554..f07f49b9c83b72deee97583389b3cc87d2777f95 100755

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -63,7 +63,6 @@ NATIVE_API_DIRS = (

# These directories should not be used but are maintained only to avoid breaking

# some legacy downstream code.

LEGACY_API_DIRS = (

- 'talk/app/webrtc',

'webrtc/base',

'webrtc/common_audio/include',

'webrtc/modules/audio_coding/include',

@@ -459,6 +458,7 @@ def _CommonChecks(input_api, output_api):

pylintrc='pylintrc'))

+ # TODO(nisse): talk/ is no more, so make below checks simpler?

# WebRTC can't use the presubmit_canned_checks.PanProjectChecks function since

# we need to have different license checks in talk/ and webrtc/ directories.

# Instead, hand-picked checks are included below.

« no previous file with comments | « LICENSE_THIRD_PARTY ('k') | all.gyp » ('j') | no next file with comments »