Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2288593004: Fix Chromium clang plugin warnings (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, Andrew MacDonald, hlundin-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix Chromium clang plugin warnings BUG=webrtc:163

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -20 lines) Patch
M webrtc/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/common.h View 1 chunk +2 lines, -9 lines 2 comments Download
A + webrtc/common.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M webrtc/common.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/common_audio/blocker.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_audio/blocker.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/common_audio/channel_buffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_audio/channel_buffer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/common_audio/lapped_transform.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/lapped_transform.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/test/test_utils.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/test/test_utils.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 2288133002 Patch 1

Messages

Total messages: 10 (5 generated)
kwiberg-webrtc
https://codereview.webrtc.org/2288593004/diff/20001/webrtc/common.h File webrtc/common.h (left): https://codereview.webrtc.org/2288593004/diff/20001/webrtc/common.h#oldcode77 webrtc/common.h:77: // on the headers. I had to remove this ...
4 years, 3 months ago (2016-08-29 08:28:18 UTC) #3
kjellander_webrtc
lgtm https://codereview.webrtc.org/2288593004/diff/20001/webrtc/common.h File webrtc/common.h (left): https://codereview.webrtc.org/2288593004/diff/20001/webrtc/common.h#oldcode77 webrtc/common.h:77: // on the headers. On 2016/08/29 08:28:18, kwiberg-webrtc ...
4 years, 3 months ago (2016-08-29 19:18:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2288593004/20001
4 years, 3 months ago (2016-08-29 19:21:46 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/942c8515bc5f0936c1ebf894a426adf4d5392fc6 Cr-Commit-Position: refs/heads/master@{#13961}
4 years, 3 months ago (2016-08-29 20:10:40 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 20:11:34 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698