Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2288133002: Fix Chromium clang plugin warnings (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix Chromium clang plugin warnings NOTRY=true BUG=webrtc:163 Committed: https://crrev.com/9e102114dc3b3c80e2227ec3e7eda532e67f8f5d Cr-Commit-Position: refs/heads/master@{#13962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M webrtc/common_audio/sparse_fir_filter.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_audio/sparse_fir_filter.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 2 chunks +0 lines, -9 lines 0 comments Download
M webrtc/modules/audio_processing/splitting_filter.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_processing/splitting_filter.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/three_band_filter_bank.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_processing/three_band_filter_bank.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2288593004 Patch 20001

Dependent Patchsets:

Issue 2288153002 Patch 1

Messages

Total messages: 10 (5 generated)
kwiberg-webrtc
4 years, 3 months ago (2016-08-29 09:26:30 UTC) #2
kjellander_webrtc
lgtm use NOTRY=True to avoid the faulty bot.
4 years, 3 months ago (2016-08-29 11:11:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2288133002/1
4 years, 3 months ago (2016-08-29 20:40:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-29 20:43:06 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 20:43:12 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9e102114dc3b3c80e2227ec3e7eda532e67f8f5d
Cr-Commit-Position: refs/heads/master@{#13962}

Powered by Google App Engine
This is Rietveld 408576698