Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2288153002: Fix Chromium clang plugin warnings (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix Chromium clang plugin warnings NOTRY=true BUG=webrtc:163

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -26 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/aec/echo_cancellation.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec/echo_cancellation.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.h View 5 chunks +9 lines, -17 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 2 chunks +38 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/echo_control_mobile_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/level_controller/signal_classifier.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/level_controller/signal_classifier.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
kwiberg-webrtc
4 years, 3 months ago (2016-08-29 09:45:08 UTC) #2
kjellander_webrtc
lgtm
4 years, 3 months ago (2016-08-29 19:13:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2288153002/1
4 years, 3 months ago (2016-08-29 21:02:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/15948)
4 years, 3 months ago (2016-08-29 21:27:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2288153002/1
4 years, 3 months ago (2016-08-29 21:37:06 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/83ffe453ec2f1ec165a0ffc58a1327599505349c Cr-Commit-Position: refs/heads/master@{#13964}
4 years, 3 months ago (2016-08-29 21:46:20 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 21:46:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698