Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2286283002: Fix Chromium clang plugin warnings (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix Chromium clang plugin warnings NOTRY=true BUG=webrtc:163 Committed: https://crrev.com/3cc87749351a08955ea0c50ac100ffa471de7cc3 Cr-Commit-Position: refs/heads/master@{#13965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -25 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 3 chunks +0 lines, -18 lines 0 comments Download
M webrtc/modules/audio_processing/test/aec_dump_based_simulator.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_simulator.h View 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_simulator.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/test/wav_based_simulator.h View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/test/wav_based_simulator.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2288153002 Patch 1

Messages

Total messages: 10 (5 generated)
kwiberg-webrtc
4 years, 3 months ago (2016-08-29 10:17:55 UTC) #2
kjellander_webrtc
lgtm you might want to use some NOTRY=True for build-only changes like these CLs.
4 years, 3 months ago (2016-08-29 11:05:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2286283002/1
4 years, 3 months ago (2016-08-29 22:01:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-29 22:10:41 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 22:10:51 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3cc87749351a08955ea0c50ac100ffa471de7cc3
Cr-Commit-Position: refs/heads/master@{#13965}

Powered by Google App Engine
This is Rietveld 408576698