Fix Chromium clang plugin warnings

webrtc/common.h

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 53 matching lines @@
   // Callers that access options too often are encouraged to cache the result.
   // Returned references are owned by this.
   //
   // Requires std::is_default_constructible<T>
   template<typename T> const T& Get() const;
 
   // Set the option, deleting any previous instance of the same.
   // This instance gets ownership of the newly set value.
   template<typename T> void Set(T* value);
 
-  Config() {}
-  ~Config() {
-    // Note: this method is inline so webrtc public API depends only
-    // on the headers.

[kwiberg-webrtc, 2016/08/29 08:28:18]

I had to remove this comment, because it's not true anymore. Hopefully it wasn't
vital...

[kjellander_webrtc, 2016/08/29 19:18:09]

Right, if moving this breaks anything it's the right thing to do since targets
should properly depend on targets with .cc files, not just including headers
blindly.

-    for (OptionMap::iterator it = options_.begin();
-         it != options_.end(); ++it) {
-      delete it->second;
-    }
-  }
+  Config();
+  ~Config();
 
  private:
   struct BaseOption {
     virtual ~BaseOption() {}
   };
 
   template<typename T>
   struct Option : BaseOption {
     explicit Option(T* v): value(v) {}
     ~Option() {
@@ skipping 39 matching lines @@
 template<typename T>
 void Config::Set(T* value) {
   BaseOption*& it = options_[identifier<T>()];
   delete it;
   it = new Option<T>(value);
 }
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_COMMON_H_