Voice Engine: Remove RED support

Voice Engine: Remove RED support

It was already disabled for browsers by design, and for everyone else
because of a bug.

BUG=webrtc:5922
Committed: https://crrev.com/9a38cabf24d07a3d26c4448cfbed7d5864e48ac0
Cr-Commit-Position: refs/heads/master@{#13138}

[kwiberg-webrtc, 2016-06-09 12:08:01]

kwiberg@webrtc.org changed reviewers:
+ ossu@webrtc.org, solenberg@webrtc.org

[the sun, 2016-06-13 08:17:39]

https://codereview.webrtc.org/2055493003/diff/1/webrtc/voice_engine/channel.cc
File webrtc/voice_engine/channel.cc (left):

https://codereview.webrtc.org/2055493003/diff/1/webrtc/voice_engine/channel.c...
webrtc/voice_engine/channel.cc:2889: if (SetRedPayloadType(redPayloadtype) < 0)
{
Can you remove SetRedPayloadType() as well?

https://codereview.webrtc.org/2055493003/diff/1/webrtc/voice_engine/channel.h
File webrtc/voice_engine/channel.h (right):

https://codereview.webrtc.org/2055493003/diff/1/webrtc/voice_engine/channel.h...
webrtc/voice_engine/channel.h:364: //int SetREDStatus(bool enable, int
redPayloadtype);
remove

[the sun, 2016-06-13 08:21:17]

https://codereview.webrtc.org/2055493003/diff/1/webrtc/voice_engine/channel.cc
File webrtc/voice_engine/channel.cc (left):

https://codereview.webrtc.org/2055493003/diff/1/webrtc/voice_engine/channel.c...
webrtc/voice_engine/channel.cc:3495: if
(_rtpRtcpModule->SetSendREDPayloadType(red_payload_type) != 0) {
Can you make a follow-up CL to remove also RtpRtcp::SetSendREDPayloadType() and
RtpRtcp::SendREDPayloadType()? They appear unused once
voe::Channel::SetRedPayloadType() is removed.

[kwiberg-webrtc, 2016-06-13 11:21:14]

New patch set uploaded.

https://codereview.webrtc.org/2055493003/diff/1/webrtc/voice_engine/channel.cc
File webrtc/voice_engine/channel.cc (left):

https://codereview.webrtc.org/2055493003/diff/1/webrtc/voice_engine/channel.c...
webrtc/voice_engine/channel.cc:2889: if (SetRedPayloadType(redPayloadtype) < 0)
{
On 2016/06/13 08:17:39, the sun wrote:
> Can you remove SetRedPayloadType() as well?

Indeed I can. Good catch.

https://codereview.webrtc.org/2055493003/diff/1/webrtc/voice_engine/channel.c...
webrtc/voice_engine/channel.cc:3495: if
(_rtpRtcpModule->SetSendREDPayloadType(red_payload_type) != 0) {
On 2016/06/13 08:21:17, the sun wrote:
> Can you make a follow-up CL to remove also RtpRtcp::SetSendREDPayloadType()
and
> RtpRtcp::SendREDPayloadType()? They appear unused once
> voe::Channel::SetRedPayloadType() is removed.

Good idea. https://codereview.webrtc.org/2066473002

https://codereview.webrtc.org/2055493003/diff/1/webrtc/voice_engine/channel.h
File webrtc/voice_engine/channel.h (right):

https://codereview.webrtc.org/2055493003/diff/1/webrtc/voice_engine/channel.h...
webrtc/voice_engine/channel.h:364: //int SetREDStatus(bool enable, int
redPayloadtype);
On 2016/06/13 08:17:39, the sun wrote:
> remove

Thanks. Done.

[the sun, 2016-06-13 11:57:21]

lgtm

[ossu, 2016-06-14 15:41:58]

lgtm

[kwiberg-webrtc, 2016-06-14 17:18:27]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-06-14 17:18:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055493003/40001

[commit-bot: I haz the power, 2016-06-14 18:21:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-14 18:21:51]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-14 18:21:53]

Description was changed from

==========
Voice Engine: Remove RED support

It was already disabled for browsers by design, and for everyone else
because of a bug.

BUG=webrtc:5922
==========

to

==========
Voice Engine: Remove RED support

It was already disabled for browsers by design, and for everyone else
because of a bug.

BUG=webrtc:5922

Committed: https://crrev.com/9a38cabf24d07a3d26c4448cfbed7d5864e48ac0
Cr-Commit-Position: refs/heads/master@{#13138}
==========

[commit-bot: I haz the power, 2016-06-14 18:21:54]

Patchset 3 (id:??) landed as
https://crrev.com/9a38cabf24d07a3d26c4448cfbed7d5864e48ac0
Cr-Commit-Position: refs/heads/master@{#13138}